Re: [Gluster-devel] Bitrot stub forget()

2016-02-17 Thread Kotresh Hiremath Ravishankar
I will take care of putting up the patch upstream. Thanks and Regards, Kotresh H R - Original Message - > From: "Venky Shankar" > To: "FNU Raghavendra Manjunath" > Cc: "Gluster Devel" , "Kotresh Hiremath > Ravishankar" > Sent: Thursday, February 18, 2016 9:44:27 AM > Subject: Re: Bitr

Re: [Gluster-devel] Bitrot stub forget()

2016-02-17 Thread Venky Shankar
On Tue, Feb 16, 2016 at 11:38:24PM -0500, FNU Raghavendra Manjunath wrote: > Venky, > > Yes. You are right. We should not remove the quarantine entry in forget. > > We have to remove it upon getting -ve lookups in bit-rot-stub and upon > getting an unlink. > > I have attached a patch for it. >

Re: [Gluster-devel] Bitrot stub forget()

2016-02-16 Thread FNU Raghavendra Manjunath
Venky, Yes. You are right. We should not remove the quarantine entry in forget. We have to remove it upon getting -ve lookups in bit-rot-stub and upon getting an unlink. I have attached a patch for it. Unfortunately rfc.sh is failing for me with the below error. ssh: connect to host git.glust

[Gluster-devel] Bitrot stub forget()

2016-02-16 Thread Venky Shankar
Hey Raghu, Bitrot stub inode forget implementation (br_stub_forget()) deletes the bad object marker (under quarantine directory) if present. This looks incorrect as ->forget() can be trigerred when inode table LRU size exceeeds configured limit - check bug #1308961 which tracks this issue. I rec