Re: [Gluster-devel] Bug in EXPECT family of macros in test framework

2015-01-27 Thread Niels de Vos
On Tue, Jan 27, 2015 at 12:35:35PM +0100, Xavier Hernandez wrote: > Hi, > > I've just discovered that EXPECT, EXPECT_WITHIN and others have a bug that > can hide some failures. > > The problem is that the test is made using a regular expression comparison. > For example, EXPECT checks this: > >

[Gluster-devel] Bug in EXPECT family of macros in test framework

2015-01-27 Thread Xavier Hernandez
Hi, I've just discovered that EXPECT, EXPECT_WITHIN and others have a bug that can hide some failures. The problem is that the test is made using a regular expression comparison. For example, EXPECT checks this: if ! [[ "$a" =~ $e ]]; then There are some tests that use a regular expres