Re: [Gluster-devel] Query regarding dictionary logic

2019-05-02 Thread Vijay Bellur
Hi Mohit, Thank you for the update. More inline. On Wed, May 1, 2019 at 11:45 PM Mohit Agrawal wrote: > Hi Vijay, > > I have tried to execute smallfile tool on volume(12x3), i have not found > any significant performance improvement > for smallfile operations, I have configured 4 clients and 8

Re: [Gluster-devel] Query regarding dictionary logic

2019-05-01 Thread Mohit Agrawal
Hi Vijay, I have tried to execute smallfile tool on volume(12x3), i have not found any significant performance improvement for smallfile operations, I have configured 4 clients and 8 thread to run operations. I have generated statedump and found below data for dictionaries specific to gluster pro

Re: [Gluster-devel] Query regarding dictionary logic

2019-04-30 Thread Mohit Agrawal
Thanks, Amar for sharing the patch, I will test and share the result. On Tue, Apr 30, 2019 at 2:23 PM Amar Tumballi Suryanarayan < atumb...@redhat.com> wrote: > Shreyas/Kevin tried to address it some time back using > https://bugzilla.redhat.com/show_bug.cgi?id=1428049 ( > https://review.gluster.

Re: [Gluster-devel] Query regarding dictionary logic

2019-04-30 Thread Amar Tumballi Suryanarayan
Shreyas/Kevin tried to address it some time back using https://bugzilla.redhat.com/show_bug.cgi?id=1428049 ( https://review.gluster.org/16830) I vaguely remember the reason to keep the hash value 1 was done during the time when we had dictionary itself sent as on wire protocol, and in most other p

Re: [Gluster-devel] Query regarding dictionary logic

2019-04-29 Thread Mohit Agrawal
sure Vijay, I will try and update. Regards, Mohit Agrawal On Tue, Apr 30, 2019 at 11:44 AM Vijay Bellur wrote: > Hi Mohit, > > On Mon, Apr 29, 2019 at 7:15 AM Mohit Agrawal wrote: > >> Hi All, >> >> I was just looking at the code of dict, I have one query current >> dictionary logic. >> I

Re: [Gluster-devel] Query regarding dictionary logic

2019-04-29 Thread Vijay Bellur
Hi Mohit, On Mon, Apr 29, 2019 at 7:15 AM Mohit Agrawal wrote: > Hi All, > > I was just looking at the code of dict, I have one query current > dictionary logic. > I am not able to understand why we use hash_size is 1 for a > dictionary.IMO with the > hash_size of 1 dictionary always work

[Gluster-devel] Query regarding dictionary logic

2019-04-29 Thread Mohit Agrawal
Hi All, I was just looking at the code of dict, I have one query current dictionary logic. I am not able to understand why we use hash_size is 1 for a dictionary.IMO with the hash_size of 1 dictionary always work like a list, not a hash, for every lookup in dictionary complexity is O(n).