Re: [Gluster-devel] io-stats: Fix overwriting of client profile by the bricks

2016-05-26 Thread Shyam
On 05/26/2016 06:19 PM, Jeff Darcy wrote: I think we need to reconsider the above change. The bug is real and needs a fix, but maybe we append the xlator name to the end of the provided filename and dump the stats into that, than unwind from the first instance of io-stats. I assume you mean the

Re: [Gluster-devel] io-stats: Fix overwriting of client profile by the bricks

2016-05-26 Thread Jeff Darcy
> >> I think we need to reconsider the above change. The bug is real and > >> needs a fix, but maybe we append the xlator name to the end of the > >> provided filename and dump the stats into that, than unwind from the > >> first instance of io-stats. > > > > I assume you mean the first instance of

Re: [Gluster-devel] io-stats: Fix overwriting of client profile by the bricks

2016-05-26 Thread Shyam
On 05/26/2016 05:32 PM, Jeff Darcy wrote: I think we need to reconsider the above change. The bug is real and needs a fix, but maybe we append the xlator name to the end of the provided filename and dump the stats into that, than unwind from the first instance of io-stats. I assume you mean t

Re: [Gluster-devel] io-stats: Fix overwriting of client profile by the bricks

2016-05-26 Thread Jeff Darcy
> I think we need to reconsider the above change. The bug is real and > needs a fix, but maybe we append the xlator name to the end of the > provided filename and dump the stats into that, than unwind from the > first instance of io-stats. I assume you mean the first instance of io-stats that rec

[Gluster-devel] io-stats: Fix overwriting of client profile by the bricks

2016-05-26 Thread Shyam
This is regarding this commit: - http://review.gluster.org/#/c/13872/ - commit 0facb11220aea20a6573b656785922219c9650cf The change in the code will now dump the stats from the first io-stats xlator that it encounters, and not further wind the setxattr to other io-stats in the stack (either clie