Re: [Gluster-devel] static analysis updated

2016-12-20 Thread Raghavendra Talur
On Mon, Dec 19, 2016 at 11:36 PM, Jeff Darcy wrote: >> Thank you Kaleb. Shall we start somwhere in terms of automation? >> >> The cppcheck results look the shortest[1]. If we can commit to fixing all of >> them in the next 1 month, I can kick off a non-voting smoke job. We'll make >> it >> vote af

Re: [Gluster-devel] static analysis updated

2016-12-20 Thread Nigel Babu
On Mon, Dec 19, 2016 at 01:06:35PM -0500, Jeff Darcy wrote: > Before we get to automation, shouldn't we have a discussion about what > "defects" we should filter out? For example, we already have a problem > with compilers spitting out warnings about unused variables in generated > code, and then

Re: [Gluster-devel] static analysis updated

2016-12-19 Thread Jeff Darcy
> [xlators/experimental/fdl/src/dump-tmpl.c] -> > [xlators/experimental/fdl/src/dump-tmpl.c]: (error) syntax error > [xlators/experimental/fdl/src/recon-tmpl.c] -> > [xlators/experimental/fdl/src/recon-tmpl.c]: (error) syntax error > [xlators/experimental/jbr-client/src/fop-template.c] -> > [xlator

Re: [Gluster-devel] static analysis updated

2016-12-19 Thread Kaleb S. KEITHLEY
On 12/19/2016 01:06 PM, Jeff Darcy wrote: >> Thank you Kaleb. Shall we start somwhere in terms of automation? >> >> The cppcheck results look the shortest[1]. If we can commit to fixing all of >> them in the next 1 month, I can kick off a non-voting smoke job. We'll make >> it >> vote after 1 month

Re: [Gluster-devel] static analysis updated

2016-12-19 Thread Jeff Darcy
> Thank you Kaleb. Shall we start somwhere in terms of automation? > > The cppcheck results look the shortest[1]. If we can commit to fixing all of > them in the next 1 month, I can kick off a non-voting smoke job. We'll make > it > vote after 1 month. I guss the cli and experimental xlator (and a

Re: [Gluster-devel] static analysis updated

2016-12-19 Thread Nigel Babu
On Mon, Dec 19, 2016 at 12:56:27PM -0500, Kaleb S. KEITHLEY wrote: > On 12/19/2016 12:49 PM, Nigel Babu wrote: > > Thank you Kaleb. Shall we start somwhere in terms of automation? > > > > The cppcheck results look the shortest[1]. If we can commit to fixing all of > > them in the next 1 month, I ca

Re: [Gluster-devel] static analysis updated

2016-12-19 Thread Kaleb S. KEITHLEY
On 12/19/2016 12:56 PM, Kaleb S. KEITHLEY wrote: > On 12/19/2016 12:49 PM, Nigel Babu wrote: >> Thank you Kaleb. Shall we start somwhere in terms of automation? >> >> The cppcheck results look the shortest[1]. If we can commit to fixing all of >> them in the next 1 month, I can kick off a non-votin

Re: [Gluster-devel] static analysis updated

2016-12-19 Thread Kaleb S. KEITHLEY
On 12/19/2016 12:49 PM, Nigel Babu wrote: > Thank you Kaleb. Shall we start somwhere in terms of automation? > > The cppcheck results look the shortest[1]. If we can commit to fixing all of > them in the next 1 month, I can kick off a non-voting smoke job. We'll make it > vote after 1 month. I gue

Re: [Gluster-devel] static analysis updated

2016-12-19 Thread Nigel Babu
Thank you Kaleb. Shall we start somwhere in terms of automation? The cppcheck results look the shortest[1]. If we can commit to fixing all of them in the next 1 month, I can kick off a non-voting smoke job. We'll make it vote after 1 month. I guss the cli and experimental xlator (and a few more xl

[Gluster-devel] static analysis updated

2016-12-19 Thread Kaleb S. KEITHLEY
Hi, Nightly runs of static analyzers have been migrated to a new host (inside Red Hat) running Fedora 25. (The old host was running F23.) With that update comes clang-3.8 (from 3.7) and cppcheck-1.75 (from 1.70). Independent of that, coverity was updated from 7.7.0 to 8.6.0. As always the resul