Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-18 Thread Kotresh Hiremath Ravishankar
On Tue, Sep 18, 2018 at 2:44 PM, Amar Tumballi wrote: > > > On Tue, Sep 18, 2018 at 2:33 PM, Kotresh Hiremath Ravishankar < > khire...@redhat.com> wrote: > >> I have a different problem. clang is complaining on the 4.1 back port of >> a patch which is merged in master before >> clang-format is br

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-18 Thread Amar Tumballi
On Tue, Sep 18, 2018 at 2:33 PM, Kotresh Hiremath Ravishankar < khire...@redhat.com> wrote: > I have a different problem. clang is complaining on the 4.1 back port of a > patch which is merged in master before > clang-format is brought in. Is there a way I can get smoke +1 for 4.1 as > it won't be

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-18 Thread Kotresh Hiremath Ravishankar
I have a different problem. clang is complaining on the 4.1 back port of a patch which is merged in master before clang-format is brought in. Is there a way I can get smoke +1 for 4.1 as it won't be neat to have clang changes in 4.1 and not in master for same patch. It might further affect the clea

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-18 Thread Ravishankar N
On 09/18/2018 02:02 PM, Hari Gowtham wrote: I see that the procedure mentioned in the coding standard document is buggy. git show --pretty="format:" --name-only | grep -v "contrib/" | egrep "*\.[ch]$" | xargs clang-format -i The above command edited the whole file. which is not supposed to h

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-18 Thread Hari Gowtham
I see that the procedure mentioned in the coding standard document is buggy. git show --pretty="format:" --name-only | grep -v "contrib/" | egrep "*\.[ch]$" | xargs clang-format -i The above command edited the whole file. which is not supposed to happen. +1 for the readability of the code having

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-16 Thread Amar Tumballi
On Mon, Sep 17, 2018 at 10:00 AM, Ravishankar N wrote: > > On 09/13/2018 03:34 PM, Niels de Vos wrote: > >> On Thu, Sep 13, 2018 at 02:25:22PM +0530, Ravishankar N wrote: >> ... >> >>> What rules does clang impose on function/argument wrapping and >>> alignment? I >>> somehow found the new code w

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-16 Thread Ravishankar N
On 09/13/2018 03:34 PM, Niels de Vos wrote: On Thu, Sep 13, 2018 at 02:25:22PM +0530, Ravishankar N wrote: ... What rules does clang impose on function/argument wrapping and alignment? I somehow found the new code wrapping to be random and highly unreadable. An example of 'before and after' th

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-13 Thread Niels de Vos
On Thu, Sep 13, 2018 at 02:25:22PM +0530, Ravishankar N wrote: ... > What rules does clang impose on function/argument wrapping and alignment? I > somehow found the new code wrapping to be random and highly unreadable. An > example of 'before and after' the clang format patches went in: > https://p

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-13 Thread Ravishankar N
On 09/12/2018 07:31 PM, Amar Tumballi wrote: Top posting: All is well at the tip of glusterfs master branch now. We will post a postmortem report of events and what went wrong in this activity, later. With this, Shyam, you can go ahead with release-v5.0 branching. -Amar On Wed, Sep 12, 20

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-12 Thread Amar Tumballi
Top posting: All is well at the tip of glusterfs master branch now. We will post a postmortem report of events and what went wrong in this activity, later. With this, Shyam, you can go ahead with release-v5.0 branching. -Amar On Wed, Sep 12, 2018 at 6:21 PM, Amar Tumballi wrote: > > > On Wed

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-12 Thread Amar Tumballi
On Wed, Sep 12, 2018 at 5:36 PM, Amar Tumballi wrote: > > > On Mon, Aug 27, 2018 at 8:47 AM, Amar Tumballi > wrote: > >> >> >> On Wed, Aug 22, 2018 at 12:35 PM, Amar Tumballi >> wrote: >> >>> Hi All, >>> >>> Below is an update about the project’s move towards using >>> clang-formatter for impos

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-09-12 Thread Amar Tumballi
On Mon, Aug 27, 2018 at 8:47 AM, Amar Tumballi wrote: > > > On Wed, Aug 22, 2018 at 12:35 PM, Amar Tumballi > wrote: > >> Hi All, >> >> Below is an update about the project’s move towards using clang-formatter >> for imposing few coding-standards. >> >> Gluster project, since inception followed

Re: [Gluster-devel] Clang-Formatter for GlusterFS.

2018-08-26 Thread Amar Tumballi
On Wed, Aug 22, 2018 at 12:35 PM, Amar Tumballi wrote: > Hi All, > > Below is an update about the project’s move towards using clang-formatter > for imposing few coding-standards. > > Gluster project, since inception followed certain basic coding standard, > which was (at that time) easy to follo