Re: [Gluster-devel] Should we enable contention notification by default ?

2019-06-05 Thread Xavi Hernandez
Missed the patch link: https://review.gluster.org/c/glusterfs/+/22828 On Thu, Jun 6, 2019 at 8:32 AM Xavi Hernandez wrote: > On Thu, May 2, 2019 at 5:45 PM Atin Mukherjee > wrote: > >> >> >> On Thu, 2 May 2019 at 20:38, Xavi Hernandez >> wrote: >> >>> On Thu, May 2, 2019 at 4:06 PM Atin Mukher

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-06-05 Thread Xavi Hernandez
On Thu, May 2, 2019 at 5:45 PM Atin Mukherjee wrote: > > > On Thu, 2 May 2019 at 20:38, Xavi Hernandez wrote: > >> On Thu, May 2, 2019 at 4:06 PM Atin Mukherjee >> wrote: >> >>> >>> >>> On Thu, 2 May 2019 at 19:14, Xavi Hernandez >>> wrote: >>> On Thu, 2 May 2019, 15:37 Milind Changire,

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-05-02 Thread Atin Mukherjee
On Thu, 2 May 2019 at 20:38, Xavi Hernandez wrote: > On Thu, May 2, 2019 at 4:06 PM Atin Mukherjee > wrote: > >> >> >> On Thu, 2 May 2019 at 19:14, Xavi Hernandez >> wrote: >> >>> On Thu, 2 May 2019, 15:37 Milind Changire, wrote: >>> On Thu, May 2, 2019 at 6:44 PM Xavi Hernandez wro

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-05-02 Thread Xavi Hernandez
On Thu, May 2, 2019 at 4:06 PM Atin Mukherjee wrote: > > > On Thu, 2 May 2019 at 19:14, Xavi Hernandez wrote: > >> On Thu, 2 May 2019, 15:37 Milind Changire, wrote: >> >>> On Thu, May 2, 2019 at 6:44 PM Xavi Hernandez >>> wrote: >>> Hi Ashish, On Thu, May 2, 2019 at 2:17 PM Ashi

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-05-02 Thread Atin Mukherjee
On Thu, 2 May 2019 at 19:14, Xavi Hernandez wrote: > On Thu, 2 May 2019, 15:37 Milind Changire, wrote: > >> On Thu, May 2, 2019 at 6:44 PM Xavi Hernandez >> wrote: >> >>> Hi Ashish, >>> >>> On Thu, May 2, 2019 at 2:17 PM Ashish Pandey >>> wrote: >>> Xavi, I would like to keep th

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-05-02 Thread Xavi Hernandez
On Thu, 2 May 2019, 15:37 Milind Changire, wrote: > On Thu, May 2, 2019 at 6:44 PM Xavi Hernandez > wrote: > >> Hi Ashish, >> >> On Thu, May 2, 2019 at 2:17 PM Ashish Pandey wrote: >> >>> Xavi, >>> >>> I would like to keep this option (features.lock-notify-contention) >>> enabled by default. >>

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-05-02 Thread Milind Changire
On Thu, May 2, 2019 at 6:44 PM Xavi Hernandez wrote: > Hi Ashish, > > On Thu, May 2, 2019 at 2:17 PM Ashish Pandey wrote: > >> Xavi, >> >> I would like to keep this option (features.lock-notify-contention) >> enabled by default. >> However, I can see that there is one more option which will impa

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-05-02 Thread Xavi Hernandez
Hi Ashish, On Thu, May 2, 2019 at 2:17 PM Ashish Pandey wrote: > Xavi, > > I would like to keep this option (features.lock-notify-contention) enabled > by default. > However, I can see that there is one more option which will impact the > working of this option which is "notify-contention-delay"

Re: [Gluster-devel] Should we enable contention notification by default ?

2019-05-02 Thread Ashish Pandey
Xavi, I would like to keep this option (features.lock-notify-contention) enabled by default. However, I can see that there is one more option which will impact the working of this option which is "notify-contention-delay" .description = "This value determines the minimum amount of time " "(i