Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-23 Thread Soumya Koduri
o" , "Gluster Devel" Sent: Sunday, April 20, 2014 11:59:40 PM Subject: Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU One more late thought... Maybe this should show up as "known issues" in the recently released gluster 3.5 beta and 3.5 GA release notes (unless

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-20 Thread Bharata B Rao
On Sun, Apr 20, 2014 at 11:57 PM, Deepak Shetty wrote: > This also tells us that the gfapi based validation/QE testcases needs to > take this scenario in to account > so that in future this can be caught sooner :) > > Bharata, > Does the existing QEMU testcase for gfapi cover this ? > If are

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-20 Thread Vijay Bellur
plications using libgfapi. >>> >>> Thanks, >>> Soumya >>> >>> >>> - Original Message - >>> From: "Bharata B Rao" >>> To: "Deepak Shetty" >>> Cc: "Gluster Devel" &g

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-20 Thread Deepak Shetty
#x27;t involve >> any changes in the applications using libgfapi. >> >> Thanks, >> Soumya >> >> >> - Original Message ----- >> From: "Bharata B Rao" >> To: "Deepak Shetty" >> Cc: "Gluster Devel" >> Sen

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-20 Thread Deepak Shetty
t; From: "Bharata B Rao" > To: "Deepak Shetty" > Cc: "Gluster Devel" > Sent: Friday, April 18, 2014 8:31:28 AM > Subject: Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU > > On Thu, Apr 17, 2014 at 7:56 PM, Deepak Shetty < dpkshe...@gma

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-18 Thread Soumya Koduri
> Anyone from gluster looking into this fix/enhancement ? I will work on this fix. Thanks, Soumya - Original Message - From: "Bharata B Rao" To: "Soumya Koduri" Cc: "Deepak Shetty" , "Gluster Devel" Sent: Friday, April 18, 2014 8:28:21 P

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-18 Thread Soumya Koduri
t; Cc: "Gluster Devel" Sent: Friday, April 18, 2014 8:31:28 AM Subject: Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU On Thu, Apr 17, 2014 at 7:56 PM, Deepak Shetty < dpkshe...@gmail.com > wrote: The glfs_lock indeed seems to work only when glfs_init i

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-18 Thread Bharata B Rao
On Fri, Apr 18, 2014 at 8:23 PM, Soumya Koduri wrote: > Posted my comments in the bug link. > Thanks. > > " glfs_init" cannot be called before as it checks for > cmds_args->volfile_server which is initialized only in > "glfs_set_volfile_server". > As Deepak had mentioned, we should either defi

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-17 Thread Bharata B Rao
On Thu, Apr 17, 2014 at 7:56 PM, Deepak Shetty wrote: > > The glfs_lock indeed seems to work only when glfs_init is succesfull! > We can call glfs_unset_volfile_server for the error case of > glfs_set_volfile_server as a good practice. > But it does look like we need a opposite of glfs_new (maybe

Re: [Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-17 Thread Deepak Shetty
On Thu, Apr 17, 2014 at 6:58 PM, Bharata B Rao wrote: > Hi, > > In QEMU, we initialize gfapi in the following manner: > > > glfs = glfs_new(); > if (!glfs) >goto out; > if (glfs_set_volfile_server() < 0) >goto out; > if (glfs_set_logging() < 0) >goto out; > if (glf

[Gluster-devel] Behaviour of glfs_fini() affecting QEMU

2014-04-17 Thread Bharata B Rao
Hi, In QEMU, we initialize gfapi in the following manner: glfs = glfs_new(); if (!glfs) goto out; if (glfs_set_volfile_server() < 0) goto out; if (glfs_set_logging() < 0) goto out; if (glfs_init(glfs)) goto out; ... out: if (glfs) glfs_fini(glfs)