https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #15 from Xavi Hernandez ---
(In reply to Jeff Darcy from comment #13)
> IndentCaseLabels: personally I don't like indenting case labels because they
> create a gap with no close brace - unless people put braces around cases,
> whic
https://bugzilla.redhat.com/show_bug.cgi?id=1568488
Prashanth Pai changed:
What|Removed |Added
CC||p...@redhat.com
--- Comment #2 from P
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
Amar Tumballi changed:
What|Removed |Added
Priority|unspecified |high
--- Comment #14 from Amar Tumbal
https://bugzilla.redhat.com/show_bug.cgi?id=1568488
Nigel Babu changed:
What|Removed |Added
CC||nig...@redhat.com
--- Comment #1 from Ni
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #13 from Jeff Darcy ---
IndentCaseLabels: personally I don't like indenting case labels because they
create a gap with no close brace - unless people put braces around cases, which
is a bad habit for other reasons - but I know I'm
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #12 from Xavi Hernandez ---
Using Chromium as base, basically the changes you propose seem ok. I would like
to propose these additional changes:
* I prefer to use 4 spaces for indent. 2 seems too few to me.
* IndentCaseLabels = t
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #11 from Jeff Darcy ---
Whatever we pick is going to require some tweaking. Some of the things I
notice:
* All use two-space indents, which I personally find atrocious.
* All put a function's type on the same line as its name.
https://bugzilla.redhat.com/show_bug.cgi?id=1568488
Bug ID: 1568488
Summary: Is fstat.gluster.org capturing all the regression
failures?
Product: GlusterFS
Version: mainline
Component: project-infrastructure
Assign
Super useful. Thanks Nigel (and Amar for the idea).
On Tue, Apr 17, 2018 at 12:04 PM, Nigel Babu wrote:
> Hello folks,
>
> In the past if you had a patch that was fixing a brick multiplex failure,
> you couldn't test whether it actually fixed brick multiplex failures
> easily. You had two option
https://bugzilla.redhat.com/show_bug.cgi?id=1549000
Amar Tumballi changed:
What|Removed |Added
Status|MODIFIED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #10 from Amar Tumballi ---
(Update from Nigel)
Which format should we start with as base? Google/LLVM/Mozilla/Webkit/Chromium
*
[Chromium](https://gist.github.com/nigelbabu/667f3b626779bb14858aa4b520e67c18#file-chromium-c)
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #9 from Amar Tumballi ---
(In reply to Nigel Babu from comment #7)
> Alright. So we have agreement that this is a good idea. How do we want to
> implement this? As a check or as a pre-commit hook?
This is a multi-step process!
0.
https://bugzilla.redhat.com/show_bug.cgi?id=1564149
--- Comment #8 from Amar Tumballi ---
(In reply to Shreyas Siravara from comment #6)
> Whoever came up with this idea is a genius, and I totally ack it :)
All credits for this to Shreyas Siravara! As the original idea was proposed
while we we
13 matches
Mail list logo
