mpn_mul_fft type overflow issue

2013-09-18 Thread Mark Sofroniou
Hello GMP developers. I wasn't quite sure if this message should be sent to gmp-bugs or to gmp-devel. Since this isn't the first issue due to types of internal variables (e.g. http://gmplib.org/list-archives/gmp-bugs/2009-July/001538.html) I thought it might deserve some discussion. Apologies if

Re: mpn_mul_fft type overflow issue

2013-09-18 Thread Mark Sofroniou
On 09/18/2013 05:27 AM, Torbjorn Granlund wrote: Hello Mark! I cannot say that we were unaware of these type probems in mul_fft.c. Since I have no machine where to test changes, I have postponed fixing these problems. I am glad you have had a chance to clean this up. Hi Torbjorn, thanks for

Re: mpn_mul_fft type overflow issue

2013-09-18 Thread Torbjorn Granlund
Mark Sofroniou ma...@wolfram.com writes: Thanks. I wasn't completely sure what the right type was in all cases. Most of the changes are to use mp_size_t instead of int - these are the important ones. There are a couple (related to the variables K2 and K3) that change unsigned int to