Re: TODO for 5.2

2013-12-29 Thread Niels Möller
Torbjorn Granlund writes: > I notice you make this non-public. Is it premature to make it part of > the public interface? Pushed now, with declarations moved to gmp-h.in. I noticed one peculiarity when testing: for m = 1, mpz_invert considers every a uninvertible, while mpn_sec_minvert conside

Re: TODO for 5.2

2013-12-29 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: I just put the declarations together with the other mpn_sec_* functions. I think it makes sense to make mpn_sec_div_*, mpn_sec_minvert and mpn_sec_powm public together. Does mpn_sec_powm need more work (besides the rename) before made public?

Re: TODO for 5.2

2013-12-29 Thread Niels Möller
Torbjorn Granlund writes: > I notice you make this non-public. Is it premature to make it part of > the public interface? I just put the declarations together with the other mpn_sec_* functions. I think it makes sense to make mpn_sec_div_*, mpn_sec_minvert and mpn_sec_powm public together. Does

Re: TODO for 5.2

2013-12-29 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: > * Finalise and commit mpn_sec_minvert. Here's a new version, including tests. Seems to work. I'll try to get this committed fairly soon. Nice! I notice you make this non-public. Is it premature to make it part of the public interface?

Re: TODO for 5.2

2013-12-29 Thread Niels Möller
Torbjorn Granlund writes: > * Finalise and commit mpn_sec_minvert. Here's a new version, including tests. Seems to work. I'll try to get this committed fairly soon. It would be good to also add some support in speed, so performance can be compared easily to gcdext and powm. Regards, /Niels di