Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-05 Thread Niels Möller
David Miller da...@davemloft.net writes: And it causes the debugging problem Richard mentioned too. I really want to step in the orignal source file, the thing I'm going to edit to fix the bug, not some intermediate file. Does it help to just add -s to the m4 invocation? Regards, /Niels --

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-05 Thread Niels Möller
Richard Henderson r...@twiddle.net writes: But perhaps more importantly, everyone who programs in C understands how the preprocessor works. Actually, I think that's incorrect. Everyone has some *familiarity* with the C preprocessor, which surely is an advantage. And maybe most C programmers

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-05 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: Actually, I think that's incorrect. Everyone has some *familiarity* with the C preprocessor, which surely is an advantage. And maybe most C programmers think they they understand it. But in my experience, very few understand the fine details

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-05 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: ni...@lysator.liu.se (Niels Möller) writes: I would expect #line to cause syntax problem for macines where # is not a comment charachter. Like ARM, where #17 is the small constant argument 17. GNU as on my arm doesn't complain about #line as

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-05 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: Ehum, I don't understand with which cpp quirk that indirection is coping... The point of the indirection is to get macro arguments expanded *before* substitution. Which matters only (I think) when using the # and ## cpp operators. Example: gcc -E on

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-05 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: That would certainly cause some additional confusion. Any suggestion for appropriate m4 quote characters to use? ;-) I think one should be kind and use [ and ]. The resulting C dialect, where indexing would be written arr[[i]] is not too bad...

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Niels Möller
Richard Henderson r...@twiddle.net writes: Although I'm frankly a bit confused as to why we're using m4 for the assembly macro-isation, as opposed to the C preprocessor. Different taste, I guess. I don't know why GMP moved to m4, but personally, I wouldn't use cpp for anything that isn't C

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Torbjorn Granlund
Richard Henderson r...@twiddle.net writes: This does not adjust the public interface at all, or tidy the internal namespace at all. What it does do is annotate the source (in as few places as possible) so that we automatically create and use the hidden internal aliases inside the

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Torbjorn Granlund
Did you use gmp-func-list.txt for determining which functions to make public? -- Torbjörn ___ gmp-devel mailing list gmp-devel@gmplib.org http://gmplib.org/mailman/listinfo/gmp-devel

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Richard Henderson
On 03/04/2013 12:25 PM, Torbjorn Granlund wrote: Did you use gmp-func-list.txt for determining which functions to make public? No, I used the existing gmp-h.in file, as I mentioned elsewhere. Note that all symbols that are visible today are still visible with the patch. I'm not really

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Torbjorn Granlund
Richard Henderson r...@twiddle.net writes: No, I used the existing gmp-h.in file, as I mentioned elsewhere. Note that all symbols that are visible today are still visible with the patch. I'm not really cleaning up the set of exported symbols. Just making sure that gmp itself

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Richard Henderson
On 03/04/2013 12:21 PM, Torbjorn Granlund wrote: What sort of paperwork do you and Red hat have in place? We need to extend it as soon as possible, if the current paperwork needs amending. (Last time, for David Miller, it took something like two months, and only after some nagging.)

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread David Miller
From: Richard Henderson r...@twiddle.net Date: Mon, 04 Mar 2013 12:47:47 -0800 On 03/04/2013 12:21 PM, Torbjorn Granlund wrote: What sort of paperwork do you and Red hat have in place? We need to extend it as soon as possible, if the current paperwork needs amending. (Last time, for David

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Richard Henderson
On 03/04/2013 12:47 PM, Torbjorn Granlund wrote: But we might as well address this in the next stage. Do you agree? Yes. I think the macros added here will aid in cleaning things up. r~ ___ gmp-devel mailing list gmp-devel@gmplib.org

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread David Miller
From: Torbjorn Granlund t...@gmplib.org Date: Mon, 04 Mar 2013 23:07:07 +0100 I actually really like m4. It is tiny yet really powerful, being Turing complete. A friend of mine implemented a bignum library in m4, inspired by GMP's m4 usage, I think. Convinced of m4's greatness now? :-) I

Re: [PATCH 00/20] Create and use hidden aliases in libgmp.so

2013-03-04 Thread Richard Henderson
On 03/04/2013 12:21 PM, Torbjorn Granlund wrote: I've tried to do this in a series of steps that are as mechanical as possible, and therefore as easy to review as possible. Is the patch set intended to be applied as a whole, or will applying each (in number order) give something which