gnome-screensaver UI review changes

2006-02-14 Thread William Jon McCann
Hi, There were two minor UI changes that resulted from the review today. I'd like to commit the patch on the following bug with your approval: http://bugzilla.gnome.org/show_bug.cgi?id=331185 This also involves a string change. Is it OK? Thanks, Jon ___

Re: gnome-screensaver UI review changes

2006-02-14 Thread John (J5) Palmieri
* src/gs-lock-plug.c (get_user_on_host_name, create_page_one): Display "username on host" string instead of just "username". What is the effect of this on translations? The other change looks fine. On Tue, 2006-02-14 at 15:14 -0500, William Jon McCann wrote: > Hi, > > There were two minor UI c

Re: gnome-screensaver UI review changes

2006-02-14 Thread Elijah Newren
On 2/14/06, William Jon McCann <[EMAIL PROTECTED]> wrote: > Hi, > > There were two minor UI changes that resulted from the review today. > > I'd like to commit the patch on the following bug with your approval: > http://bugzilla.gnome.org/show_bug.cgi?id=331185 > > This also involves a string chang

Re: gnome-screensaver UI review changes

2006-02-14 Thread William Jon McCann
Hi John, John (J5) Palmieri wrote: * src/gs-lock-plug.c (get_user_on_host_name, create_page_one): Display "username on host" string instead of just "username". What is the effect of this on translations? The other change looks fine. The translatable string is _("%s on %s") and it will have

Re: gnome-screensaver UI review changes

2006-02-14 Thread Joachim Noreiko
--- Elijah Newren <[EMAIL PROTECTED]> wrote: > On 2/14/06, William Jon McCann <[EMAIL PROTECTED]> > wrote: > > Hi, > > > > There were two minor UI changes that resulted from > the review today. > > > > I'd like to commit the patch on the following bug > with your approval: > > http://bugzilla.gno

Re: gnome-screensaver UI review changes

2006-02-14 Thread Danilo Šegan
Hi William, Yesterday at 21:43, William Jon McCann wrote: > The translatable string is _("%s on %s") and it will have a comment > for translators that says: > Translators: this is "username on hostname" > > Perhaps the i18n team can let me know if there is something else that > should be done. I

Re: gnome-screensaver UI review changes

2006-02-15 Thread Calum Benson
On 15 Feb 2006, at 12:38, Sankarshan Mukhopadhyay wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 William Jon McCann wrote: The translatable string is _("%s on %s") and it will have a comment for translators that says: Translators: this is "username on hostname" 'username on hostnam

Re: gnome-screensaver UI review changes

2006-02-15 Thread Danilo Šegan
Hi Calum, William, Today at 16:14, Calum Benson wrote: > If anyone can suggest any nice, l10n-friendly ways to do this, feel > free-- otherwise, we should probably just file it as a bug and fix it > in 2.16 when we've had more time to think about it. Perhaps: Row 1: username Row 2: hostname (W

Re: gnome-screensaver UI review changes

2006-02-15 Thread Calum Benson
On Wed, 2006-02-15 at 17:15 +0100, Danilo Šegan wrote: > Perhaps: > > Row 1: username > Row 2: hostname > > (Without the "Row %d:" labels, of course ;) > > I don't know how would it affect the UI or would this be clean enough. Yeah, this was one of the suggestions we had yesterday... I just th

Re: gnome-screensaver UI review changes

2006-02-15 Thread William Jon McCann
Hi Danilo, Danilo Šegan wrote: Hi Calum, William, Today at 16:14, Calum Benson wrote: If anyone can suggest any nice, l10n-friendly ways to do this, feel free-- otherwise, we should probably just file it as a bug and fix it in 2.16 when we've had more time to think about it. Perhaps: Row 1

Re: gnome-screensaver UI review changes

2006-02-15 Thread Sankarshan Mukhopadhyay
Danilo Šegan wrote: > Perhaps: > > Row 1: username > Row 2: hostname Might just make the dialog box a bit stretchy :) else it might just be *the* way out. Can anyone take trouble to throw in a mockup ? -Sankarshan -- >From Untruth, lead me to the Truth, >From Darkness, Lead me towards the L

Re: gnome-screensaver UI review changes

2006-02-16 Thread Sankarshan Mukhopadhyay
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 William Jon McCann wrote: > The translatable string is _("%s on %s") and it will have a comment for > translators that says: > Translators: this is "username on hostname" 'username on hostname' is a potential minefield for L10n teams - is this really

Re: gnome-screensaver UI review changes

2006-02-19 Thread Vincent Untz
Le mercredi 15 février 2006 à 11:43 -0500, William Jon McCann a écrit : > Hi Danilo, > > Danilo Šegan wrote: > > Anyway, you've got my I18N approval, but at least add a suggestive > > translator comment such as "Translators: You can translate this to > > '[EMAIL PROTECTED]' if it's otherwise trick