Re: Request for review: patch for bug 499496

2007-12-25 Thread Derek Atkins
Hi, Daniel Harding <[EMAIL PROTECTED]> writes: > Hello, > > I have put together a patch for a bug I filed a few weeks back. This is > my first attempt to make any real changes to the GnuCash sources, so I'd > appreciate feedback on both my approach to addressing the bug, as well > as the form

Re: please review patch on bug 347274

2007-12-25 Thread Derek Atkins
Andrew Ziem <[EMAIL PROTECTED]> writes: > Hello, > > Please review my patch against GnuCash 2.2.1. Thanks. :) > > http://bugzilla.gnome.org/show_bug.cgi?id=347274 > http://bugzilla.gnome.org/attachment.cgi?id=100912&action=view I guess it looks good, although "bitwise-ior" isn't a valid scheme

Re: [PATCH] Fixed "Balance" row not appearing on owner reports (Vendor, etc...) if no transactions occur after "From" date

2007-12-25 Thread Derek Atkins
Applied to trunk as r16729. Note that I had to make a small change because 'txns' might be null Thanks, -derek "Jeff Green" <[EMAIL PROTECTED]> writes: > The "balance" row should show the total for all transactions (if any) > occurring before the "From" date selected in the report's options (de

Re: [PATCH] Fixed "payable/receivable aging" reports not including bills/invoices more than 360 days old

2007-12-25 Thread Derek Atkins
"Jeff Green" <[EMAIL PROTECTED]> writes: > Reports now include totals for all bills/invoices in the "91+ days" column > since time 0 (beginning of the Epoch) instead of 360 days before the current > date. Applied (r16728) Thanks, > Jeff Green -derek -- Derek Atkins, SB '93 MIT EE, SM

make check on Windows [WAS Re: 16690 breaks `make check`]

2007-12-25 Thread Daniel Harding
Derek Atkins wrote: > Quoting Daniel Harding <[EMAIL PROTECTED]>: > > > Found a build problem, at least on Windows. The Makefile attempts to > > create links to several .scm files from the build directory to the > > source directory. Because Windows filesystems do not support links, it > >

Commit access for trunk

2007-12-25 Thread Phil Longstaff
Do I have commit access for trunk? For changes which would make the gda backend easier (e.g. further work on converting engine objects to be GObject based), I would prefer to make the change in the trunk and then merge into the GDA branch. If I don't have access, may I have it? Phil

Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-25 Thread Derek Atkins
Quoting Daniel Harding <[EMAIL PROTECTED]>: > Found a build problem, at least on Windows. The Makefile attempts to > create links to several .scm files from the build directory to the > source directory. Because Windows filesystems do not support links, it > simply does a copy instead. But, bec

Re: Guile 1.8 error

2007-12-25 Thread Derek Atkins
Hi, Quoting Mike Alexander <[EMAIL PROTECTED]>: > Is Gnucash (as of r16711) supposed to work with Guile 1.8.3? Macports I don't think it's ever been tested. It's known to have some issues with the combination of guile 1.8 and slib that MacPorts has been using for a while, but I don't know abou

Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-25 Thread Daniel Harding
[resending to the list, because I realized my original reply went only to Andrew] Andrew Sackville-West wrote on 24 Dec 2007 9:12 PM: On Mon, Dec 24, 2007 at 03:04:00PM +0430, Daniel Harding wrote: Andrew Sackville-West wrote: On Sun, Dec 23, 2007 at 11:19:42PM -0800, Andrew Sackville