Re: [GNC-dev] Test failure on current master branch

2023-03-14 Thread Geert Janssens
Got a chance to test this yesterday. Your change fixed it indeed. Regards, Geert Op donderdag 2 maart 2023 21:36:00 CET schreef John Ralls: > Found and fixed it. It turns out that string->number isn't locale-sensitive, > std::to_string is. I replaced it with ostringstream and pushed. > > Regard

Re: [GNC-dev] Test failure on current master branch

2023-03-02 Thread John Ralls
Found and fixed it. It turns out that string->number isn't locale-sensitive, std::to_string is. I replaced it with ostringstream and pushed. Regards, John Ralls > On Mar 2, 2023, at 9:16 AM, john wrote: > > Geert, > > Aha! That would certainly explain why I couldn't reproduce it. That change

Re: [GNC-dev] Test failure on current master branch

2023-03-02 Thread john
Geert, Aha! That would certainly explain why I couldn't reproduce it. That change is from https://github.com/Gnucash/gnucash/commit/408b5ec2165fb43bef18b80ff44ba4d2f1b67f5f. Yes, no doubt string->number expects the number to be represented in the current locale, so it wants "42,0" and gettin

Re: [GNC-dev] Test failure on current master branch

2023-03-02 Thread Geert Janssens
I still haven't figured out exactly where it goes wrong, but I did discover it's a locale related issue. For some reason this particular test has become locale sensitive. If I run the test as follows: LC_ALL=C ctest -V -R test-gnc-option-scheme-output it passes. If however I do this: LC_ALL=fr_

Re: [GNC-dev] Test failure on current master branch

2023-02-28 Thread John Ralls
Geert, I can't replicate that, tried on Debian 10, Debian Unstable, and Arch. I'm installing a Fedora 37 VM but I'm out of time for today and won't get to the point of a test build of GnuCash. Regards, John Ralls > On Feb 28, 2023, at 2:07 PM, Geert Janssens > wrote: > > Hi, > > With the c

[GNC-dev] Test failure on current master branch

2023-02-28 Thread Geert Janssens
Hi, With the current master branch I get the following test failure: ctest --rerun-failed --output-on-failure Test project /home/janssege/Development/gnucash/master/build Start 120: test-gnc-option-scheme-output 1/1 Test #120: test-gnc-option-scheme-output ***Failed0.22 sec gnc:mak

[GNC-dev] Test failure on master

2022-12-19 Thread Geert Janssens
Hi, I ran our test suite a few moments ago and I get a test failure for the finance-quote related tests. Below is the relevant detail from the test logs: [ RUN ] GncQuotesTest.online_wiggle * 22:02:03 WARN [GncFQQuoteSource::GncFQQuoteSource()] No Alpha Vantage API key set, currency q

[GNC-dev] Test of AqBanking dialogs (DirectOFX etc.)

2019-05-11 Thread Frank H. Ellenberger
Dear AqBanking users (DirectOFX etc.) The dialogs were converted and I sent a separate mail already to the FinTS users on the german list. As there are other modules, too, I ask you to test them either on a current built from the Gnucash Git repo or a nightly Windows built [https://code.gnucash.or

Re: [GNC-dev] Test

2019-02-04 Thread Derek Atkins
The mailman output queue got hung up during the upgrades and mail was being received but not sent. I restarted the queue runners and mail started flowing, but it took a while to clear out the queue. The queue was empty when I went to bed. -derek Sent using my mobile device. Please excuse any t

Re: [GNC-dev] Test

2019-02-04 Thread Liz
On Sun, 03 Feb 2019 21:21:22 -0500 Derek Atkins wrote: > Testing mailman... > -derek It's fine, the spam is arriving in a normal fashion. Thanks for the efforts you are making to keep all running. Liz ___ gnucash-devel mailing list gnucash-devel@gnuc

[GNC-dev] Test

2019-02-03 Thread Derek Atkins
Testing mailman... -derek -- Derek Atkins 617-623-3745 de...@ihtfp.com www.ihtfp.com Computer and Internet Security Consultant ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash

Re: [GNC-dev] Test failure

2019-01-27 Thread Stephen M. Butler
On 1/26/19 11:20 PM, Christopher Lam wrote: > > Ok my bad > > May be safer to reuse your own gnucash repository > > * cd gnucash > * git remote add chris https://github.com/christopherlam/gnucash.git > * git fetch --all > * git checkout chris/maint-chartjs-budget-barchart > * dpkg etc > >

Re: [GNC-dev] Test failure

2019-01-27 Thread John Ralls
You can do it that way or you can do git clone https://github.com/christopherlam/gnucash.git -b maint-chartjs-budget-barchart/ or git clone https://github.com/christopherlam/gnucash.git git checkout -b maint-chartjs-budget-barchart/ or the way we do for testing pull requests; this is a bit f

Re: [GNC-dev] Test failure

2019-01-26 Thread Christopher Lam
Ok my bad May be safer to reuse your own gnucash repository * cd gnucash * git remote add chris https://github.com/christopherlam/gnucash.git * git fetch --all * git checkout chris/maint-chartjs-budget-barchart * dpkg etc and to revert to main branch: * git checkout maint On 27/1/19 3

Re: [GNC-dev] Test failure

2019-01-26 Thread Stephen M. Butler
On 1/26/19 10:54 PM, Christopher Lam wrote: > Stephen please spend some CPU burning time on my chartJS branch which > needs beta testing? > > $git clone > https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart Thought I'd start this while headed toward some z's.  Too tired t

Re: [GNC-dev] Test failure

2019-01-26 Thread Christopher Lam
Stephen please spend some CPU burning time on my chartJS branch which needs beta testing? $git clone https://github.com/christopherlam/gnucash/tree/maint-chartjs-budget-barchart On 27/1/19 2:52 pm, Stephen M. Butler wrote: On 1/26/19 10:29 PM, John Ralls wrote: Stephen, By all means learn

Re: [GNC-dev] Test failure

2019-01-26 Thread Stephen M. Butler
On 1/26/19 10:29 PM, John Ralls wrote: > Stephen, > > By all means learn about git bisect, it's an extremely useful troubleshooting > tool. But don't exercise yourself too much about this particular failure, > Chris and I know exactly what commit caused it and that the underlying cause > is a bu

Re: [GNC-dev] Test failure

2019-01-26 Thread John Ralls
Stephen, By all means learn about git bisect, it's an extremely useful troubleshooting tool. But don't exercise yourself too much about this particular failure, Chris and I know exactly what commit caused it and that the underlying cause is a bug in ICU (International Components for Unicode, ht

Re: [GNC-dev] Test failure

2019-01-26 Thread Christopher Lam
Thank you Stephen for your results. It would seem that the test-transaction failure is caused by a faulty libicu-dev whereas my failure caused by some other issue related to Time zones. C On Sun., 27 Jan. 2019, 09:55 Stephen M. Butler On 1/26/19 3:13 AM, Christopher Lam wrote: > > Another exper

Re: [GNC-dev] Test failure

2019-01-26 Thread Stephen M. Butler
On 1/26/19 3:13 AM, Christopher Lam wrote: > Another experiment. Try prefix your build with "TZ=UTC " on current > maint. > > Eg if using ninja, it'll be "TZ=UTC ninja check" TZ=UTC dpkg- -rfakeroot -b -uc End testing: Jan 27 01:47 UTC + exit 2 debian/rules:65: recipe for target 'override_

Re: [GNC-dev] Test failure

2019-01-26 Thread Christopher Lam
Another experiment. Try prefix your build with "TZ=UTC " on current maint. Eg if using ninja, it'll be "TZ=UTC ninja check" On Fri., 25 Jan. 2019, 11:52 Stephen M. Butler On 1/24/19 7:36 PM, Christopher Lam wrote: > > Revert is a git terminology, not a gnucash one. Welcome to version > > control

Re: [GNC-dev] Test failure

2019-01-24 Thread Stephen M. Butler
On 1/24/19 7:36 PM, Christopher Lam wrote: > Revert is a git terminology, not a gnucash one. Welcome to version > control. That's the manual to which I referred.  It meant something else to my mind when I first saw your post.  But, after further thought, my previous thought was faulty. My first

Re: [GNC-dev] Test failure

2019-01-24 Thread Christopher Lam
Revert is a git terminology, not a gnucash one. Welcome to version control. Please remember this revert is reverting a buggy code with a previous buggy code, so, cannot be consisted safe to package; best wait until the clever devs can find a proper fix for gnc-date. On Fri., 25 Jan. 2019, 05:46 S

Re: [GNC-dev] Test failure

2019-01-24 Thread Stephen M. Butler
OH!  Light bulb on! OK.  I understand what you said earlier.  I'll put the patches back into the packaging. Thanks for clearing that up. --Steve PS Looking in manual for 'revert' command. On 1/24/19 1:06 PM, Christopher Lam wrote: > Because e31f4c3f9 is causing errors on my build as well in d

Re: [GNC-dev] Test failure

2019-01-24 Thread Christopher Lam
Because e31f4c3f9 is causing errors on my build as well in different ways. PS e31f4c3f9 must not be reverted for your packaging - please be patient while a proper fix is pending. On 25/1/19 3:48 am, Stephen M. Butler wrote: On 1/24/19 2:32 AM, Christopher Lam wrote: Stephen this bug is in 3.

Re: [GNC-dev] Test failure

2019-01-24 Thread Stephen M. Butler
On 1/24/19 2:32 AM, Christopher Lam wrote: > Stephen this bug is in 3.4 and was fixed in commit 95bee405c > > Could you try "git revert e31f4c3f9" as a test for your "31/12/70" > test-transaction errors? That worked.  Thank you.  BTW, how did you find that it was fixed?  I ask, because there is a

Re: [GNC-dev] Test failure

2019-01-24 Thread Christopher Lam
Stephen this bug is in 3.4 and was fixed in commit 95bee405c Could you try "git revert e31f4c3f9" as a test for your "31/12/70" test-transaction errors? On 24/1/19 3:05 am, Stephen M. Butler wrote: Found this patch on the debian version for 3.4 Origin: upstream, https://bugs.gnucash.org/atta

[GNC-dev] Test failure

2019-01-23 Thread Stephen M. Butler
Found this patch on the debian version for 3.4 Origin: upstream, https://bugs.gnucash.org/attachment.cgi?id=373094 Bug-Upstream: https://bugs.gnucash.org/show_bug.cgi?id=797008 Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=918057 From: Maxim Cournoyer Date: Wed, 2 Jan 2019 14:46:2