Re: Patch Re: Bug 625193 To move utils to core

2010-08-31 Thread Geert Janssens
On Tuesday 24 August 2010, Mike Evans wrote: > On Monday August 23 2010 21:25:42 Christian Stimming wrote: > > Am Monday 23 August 2010 schrieb Mike Evans: > > > On Monday August 23 2010 18:42:40 Geert Janssens wrote: > > > > Mike, > > > > > > > > Geert > > > > > > Hopefully a better (combined) pat

Re: Patch Re: Bug 625193 To move utils to core

2010-08-24 Thread Mike Evans
On Monday August 23 2010 21:25:42 Christian Stimming wrote: > Am Monday 23 August 2010 schrieb Mike Evans: > > On Monday August 23 2010 18:42:40 Geert Janssens wrote: > > > Mike, > > > > > > Geert > > > > Hopefully a better (combined) patch. > > Yes, this patch looks much better. One final thing

Re: Patch Re: Bug 625193 To move utils to core

2010-08-23 Thread Christian Stimming
Am Monday 23 August 2010 schrieb Mike Evans: > On Monday August 23 2010 18:42:40 Geert Janssens wrote: > > Mike, > > > > I'm not too experienced in C coding, but I wonder if it's not cleaner to > > define your general search function with an additional type parameter > > instead of globally declar

Re: Patch Re: Bug 625193 To move utils to core

2010-08-23 Thread Mike Evans
On Monday August 23 2010 18:42:40 Geert Janssens wrote: > Mike, > > I'm not too experienced in C coding, but I wonder if it's not cleaner to > define your general search function with an additional type parameter > instead of globally declaring a type variable. > > I don't find many global varia

Re: Patch Re: Bug 625193 To move utils to core

2010-08-23 Thread Mike Evans
On Monday August 23 2010 18:42:40 Geert Janssens wrote: > On Monday 23 August 2010, Mike Evans wrote: > > On Tuesday August 17 2010 20:54:42 Christian Stimming wrote: > > > Am Monday 16 August 2010 schrieb Mike Evans: > > > > I've attached a patch to move utils.c utils.h to src/engine as > > > > A

Re: Patch Re: Bug 625193 To move utils to core

2010-08-23 Thread Geert Janssens
On Monday 23 August 2010, Mike Evans wrote: > On Tuesday August 17 2010 20:54:42 Christian Stimming wrote: > > Am Monday 16 August 2010 schrieb Mike Evans: > > > I've attached a patch to move utils.c utils.h to src/engine as > > > discussed in Bug 625193. > > > > Committed to SVN, thanks. > > > > O

Re: Patch Re: Bug 625193 To move utils to core

2010-08-23 Thread Mike Evans
On Tuesday August 17 2010 20:54:42 Christian Stimming wrote: > Am Monday 16 August 2010 schrieb Mike Evans: > > I've attached a patch to move utils.c utils.h to src/engine as discussed > > in Bug 625193. > > Committed to SVN, thanks. > > One suggestion for the function naming (in gncIDsearch.h):

Re: Patch Re: Bug 625193 To move utils to core

2010-08-17 Thread Mike Evans
On Tuesday August 17 2010 20:54:42 Christian Stimming wrote: > Am Monday 16 August 2010 schrieb Mike Evans: > > I've attached a patch to move utils.c utils.h to src/engine as discussed > > in Bug 625193. > > Committed to SVN, thanks. > > One suggestion for the function naming (in gncIDsearch.h):

Re: Patch Re: Bug 625193 To move utils to core

2010-08-17 Thread Christian Stimming
Am Monday 16 August 2010 schrieb Mike Evans: > I've attached a patch to move utils.c utils.h to src/engine as discussed in > Bug 625193. Committed to SVN, thanks. One suggestion for the function naming (in gncIDsearch.h): The functions which belong to a hypothetical "core gnucash library" should

Patch Re: Bug 625193 To move utils to core

2010-08-16 Thread Mike Evans
I've attached a patch to move utils.c utils.h to src/engine as discussed in Bug 625193. Mike E -- GPG Key: 1024D/050895C2 Keyserver: http://pgp.mit.edu/ Search String: 0x050895C2 diff --git src/engine/Makefile.am src/engine/Makefile.am index dc99dee..be838d5 100644 --- src/engine/Ma