Re: gnucash master: Fix wrong PWARN calling signature.

2016-07-14 Thread John Ralls
> On Jul 14, 2016, at 7:04 AM, Derek Atkins wrote: > > John Ralls writes: > - PWARN(str.str().c_str()); + PWARN("%s", str.str().c_str()); What's the difference here? >>> >>> I mean, I see that if the string is, for instance, "%s", nothing is output. >>> But did this

Re: gnucash master: Fix wrong PWARN calling signature.

2016-07-14 Thread Derek Atkins
John Ralls writes: >>> - PWARN(str.str().c_str()); >>> + PWARN("%s", str.str().c_str()); >>> What's the difference here? >>> >>> >> >> I mean, I see that if the string is, for instance, "%s", nothing is output. >> But did this come up, or did you catch it visually while looking through >> the

Re: gnucash master: Fix wrong PWARN calling signature.

2016-07-12 Thread John Ralls
> On Jul 12, 2016, at 11:14 AM, Aaron Laws wrote: > > On Tue, Jul 12, 2016 at 2:13 PM, Aaron Laws wrote: > >> >> On Tue, Jul 12, 2016 at 12:57 PM, John Ralls >> wrote: >> >>> Updated via https://github.com/Gnucash/gnucash/commit/01c21da3 (commit) >>>from https://github.com/Gnucas

Re: gnucash master: Fix wrong PWARN calling signature.

2016-07-12 Thread Aaron Laws
On Tue, Jul 12, 2016 at 2:13 PM, Aaron Laws wrote: > > On Tue, Jul 12, 2016 at 12:57 PM, John Ralls > wrote: > >> Updated via https://github.com/Gnucash/gnucash/commit/01c21da3 (commit) >> from https://github.com/Gnucash/gnucash/commit/c11185e9 (commit) >> >> >> >> commit 01c21da3234b

Re: gnucash master: Fix wrong PWARN calling signature.

2016-07-12 Thread Aaron Laws
On Tue, Jul 12, 2016 at 12:57 PM, John Ralls wrote: > Updated via https://github.com/Gnucash/gnucash/commit/01c21da3 (commit) > from https://github.com/Gnucash/gnucash/commit/c11185e9 (commit) > > > > commit 01c21da3234ba637f57cc4b18eb069ef2bcc7aa9 > Author: John Ralls > Date: Tue J