Re: [GNC-dev] Fwd: gnucash master: Multiple changes pushed

2020-05-14 Thread Geert Janssens
Store the register sort and filter > settings in .gcm metadata file (requires at least GnuCash 3.3) > > > -- Forwarded message - > From: Robert Fewell > Date: Thu, 14 May 2020 at 09:36 > Subject: gnucash master: Multiple changes pushed > To: >

[GNC-dev] Fwd: gnucash master: Multiple changes pushed

2020-05-14 Thread Christopher Lam
) -- Forwarded message - From: Robert Fewell Date: Thu, 14 May 2020 at 09:36 Subject: gnucash master: Multiple changes pushed To: Updated via https://github.com/Gnucash/gnucash/commit/6fb50d22 (commit) via https://github.com/Gnucash/gnucash/commit/bf9c4441 (commit) via

Re: [GNC-dev] gnucash master: Multiple changes pushed

2020-05-13 Thread Geert Janssens
Op woensdag 13 mei 2020 14:50:45 CEST schreef Christopher Lam: > Hi the branch name was originally 'maint-'. Github doesn't allow changing > branch names without creating a new PR. So, next time I'll just need to > amend the merge commit message (and also add a #link to PR). That would also be suf

Re: [GNC-dev] gnucash master: Multiple changes pushed

2020-05-13 Thread Christopher Lam
Hi the branch name was originally 'maint-'. Github doesn't allow changing branch names without creating a new PR. So, next time I'll just need to amend the merge commit message (and also add a #link to PR). On Wed, 13 May 2020 at 12:21, Geert Janssens wrote: > Op woensdag 13 mei 2020 14:17:20 CE

Re: [GNC-dev] gnucash master: Multiple changes pushed

2020-05-13 Thread Geert Janssens
Op woensdag 13 mei 2020 14:17:20 CEST schreef Geert Janssens: > Op dinsdag 12 mei 2020 16:06:05 CEST schreef Christopher Lam: > > Updated via https://github.com/Gnucash/gnucash/commit/57fe0515 (commit) > > > > via https://github.com/Gnucash/gnucash/commit/b4d7386d (commit) > > >

Re: [GNC-dev] gnucash master: Multiple changes pushed

2020-05-13 Thread Geert Janssens
Op dinsdag 12 mei 2020 16:06:05 CEST schreef Christopher Lam: > Updatedvia https://github.com/Gnucash/gnucash/commit/57fe0515 > (commit) >via https://github.com/Gnucash/gnucash/commit/b4d7386d (commit) > from https://github.com/Gnucash/gnucash/commit/ebd9db89 (commit) > >

Re: [GNC-dev] gnucash master: Multiple changes pushed

2020-05-02 Thread Geert Janssens
Op vrijdag 1 mei 2020 13:03:53 CEST schreef Robert Fewell: > commit 3602753f5093313592dee6acf92b821fc604c976 > Author: Robert Fewell <14ubo...@gmail.com> > Date: Fri May 1 11:54:58 2020 +0100 > > Remove some Gtk version checks in code > > With the requirement for Gtk+ 3.22, the version

Re: [GNC-dev] gnucash master: Multiple changes pushed

2019-10-06 Thread Geert Janssens
Op maandag 7 oktober 2019 04:51:57 CEST schreef John Ralls: > > On Oct 6, 2019, at 1:02 PM, Geert Janssens > > wrote: > > > > This push didn't make it to github due to a network glitch at > > code.gnucash.org (unable to resolve github.com). > > > > Whoever does the next push to master, please ta

Re: [GNC-dev] gnucash master: Multiple changes pushed

2019-10-06 Thread John Ralls
> On Oct 6, 2019, at 1:02 PM, Geert Janssens wrote: > > This push didn't make it to github due to a network glitch at > code.gnucash.org > (unable to resolve github.com). > > Whoever does the next push to master, please take care these commits are in > your local master branch before doing

Re: [GNC-dev] gnucash master: Multiple changes pushed

2019-10-06 Thread Geert Janssens
And that turned out to be me (with a commit to maint). Problem solved. Geert Op zondag 6 oktober 2019 22:02:21 CEST schreef Geert Janssens: > This push didn't make it to github due to a network glitch at > code.gnucash.org (unable to resolve github.com). > > Whoever does the next push to master,

Re: [GNC-dev] gnucash master: Multiple changes pushed

2019-10-06 Thread Geert Janssens
This push didn't make it to github due to a network glitch at code.gnucash.org (unable to resolve github.com). Whoever does the next push to master, please take care these commits are in your local master branch before doing so. Otherwise you might be tempted to force push to fix the inconsiste

Re: gnucash master: Multiple changes pushed

2017-08-19 Thread John Ralls
> On Aug 19, 2017, at 6:05 PM, Geert Janssens > wrote: > > On zaterdag 19 augustus 2017 17:33:03 CEST John Ralls wrote: >> commit 6a359f86a07b2adcf6233cafc7531656e02cc6df >> Author: John Ralls >> Date: Wed Aug 16 23:16:42 2017 +0200 >> >>Fix mac looking in wrong directory for libgncmod-

Re: gnucash master: Multiple changes pushed

2017-08-19 Thread Geert Janssens
On zaterdag 19 augustus 2017 17:33:03 CEST John Ralls wrote: > commit 6a359f86a07b2adcf6233cafc7531656e02cc6df > Author: John Ralls > Date: Wed Aug 16 23:16:42 2017 +0200 > > Fix mac looking in wrong directory for libgncmod-backend-dbi.dylib. > > diff --git a/libgnucash/backend/dbi/test/te

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread John Ralls
> On Feb 21, 2017, at 9:16 AM, David T. wrote: > > >> On Feb 21, 2017, at 10:06 PM, John Ralls wrote: >> >> >>> On Feb 21, 2017, at 8:43 AM, Derek Atkins wrote: >>> >>> It's weird that this isn't caught by the *compiler* -- isn't an unused >>> parameter a warning/error? >> >> It is by def

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread David T. via gnucash-devel
> On Feb 21, 2017, at 10:06 PM, John Ralls wrote: > > >> On Feb 21, 2017, at 8:43 AM, Derek Atkins wrote: >> >> It's weird that this isn't caught by the *compiler* -- isn't an unused >> parameter a warning/error? > > It is by default, but we turn it off in configure.ac lines 1570 (C++) and

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread John Ralls
> On Feb 21, 2017, at 8:43 AM, Derek Atkins wrote: > > Geert Janssens > writes: > >> Hi John, >> >> Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls: >> >>> @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128 b) >>> } >>> in

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread Geert Janssens
Op dinsdag 21 februari 2017 11:43:35 CET schreef Derek Atkins: > Geert Janssens writes: > > Hi John, > > > > Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls: > >> @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128 > >> b) } > >> > >> inline GncRational operato

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread Derek Atkins
Geert Janssens writes: > Hi John, > > Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls: > >> @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128 b) >> } >> inline GncRational operator+(GncInt128 a, GncRational b) >> { >> -return b + GncRational(a, 1); >> +

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread Geert Janssens
Op dinsdag 21 februari 2017 07:07:58 CET schreef John Ralls: > Interesting. I didn't get that particular failure on Travis; I got it on my > local Ubuntu 14.04 VM which I use to debug Travis failures. It didn't even > occur to me that the exception (which isn't the one the standard requires > and w

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread John Ralls
> On Feb 21, 2017, at 6:17 AM, Geert Janssens > wrote: > > Hi John, > > Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls: > >> @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128 b) >> } >> inline GncRational operator+(GncInt128 a, GncRational b) >> { >> -

Re: gnucash master: Multiple changes pushed

2017-02-21 Thread Geert Janssens
Hi John, Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls: > @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128 b) > } > inline GncRational operator+(GncInt128 a, GncRational b) > { > -return b + GncRational(a, 1); > +return GncRational(a, 1) + a; > }

Re: gnucash master: Multiple changes pushed & Windows

2017-02-06 Thread Stephen Brown
Hi John Sent from Mail for Windows 10 > On Feb 5, 2017, at 12:04 PM, Stephen Brown > wrote: > > Hi All, > > I am still unable to get a clean build of gnucash under Windows 10. > > Does it work for others or is it still my installation? I just did

Re: gnucash master: Multiple changes pushed & Windows

2017-02-05 Thread John Ralls
> On Feb 5, 2017, at 12:04 PM, Stephen Brown > wrote: > > Hi All, > > I am still unable to get a clean build of gnucash under Windows 10. > > Does it work for others or is it still my installation? I just did a clean build starting from `cscript.exe bootstrap_win_dev.vbs`, no problems at al

gnucash master: Multiple changes pushed & Windows

2017-02-05 Thread Stephen Brown
Hi All, I am still unable to get a clean build of gnucash under Windows 10. Does it work for others or is it still my installation? Cheers Stephen Brown ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinf

Re: gnucash master: Multiple changes pushed

2017-02-03 Thread Alex Aycinena
On Thu, Feb 2, 2017 at 11:09 PM, Geert Janssens wrote: > Op donderdag 2 februari 2017 16:35:02 CET schreef Alex Aycinena: > > Geert, > > > > I build on Fedora 25 and after this commit configure fails with: > > > > checking for main in -lgtest_main... no > > checking for /usr/src/gtest/src/gtest-a

Re: gnucash master: Multiple changes pushed

2017-02-02 Thread Geert Janssens
Op donderdag 2 februari 2017 16:35:02 CET schreef Alex Aycinena: > Geert, > > I build on Fedora 25 and after this commit configure fails with: > > checking for main in -lgtest_main... no > checking for /usr/src/gtest/src/gtest-all.cc... no > checking for /usr/src/gtest/gtest-main.cc... no > check

Re: gnucash master: Multiple changes pushed

2017-02-02 Thread John Ralls
> On Feb 2, 2017, at 4:35 PM, Alex Aycinena wrote: > > On Thu, Feb 2, 2017 at 10:03 AM, Geert Janssens > wrote: > >> Updated via https://github.com/Gnucash/gnucash/commit/659c96eb (commit) >> via https://github.com/Gnucash/gnucash/commit/4fdacb9b (commit) >> via https://git

Re: gnucash master: Multiple changes pushed

2017-02-02 Thread Alex Aycinena
On Thu, Feb 2, 2017 at 10:03 AM, Geert Janssens wrote: > Updated via https://github.com/Gnucash/gnucash/commit/659c96eb (commit) > via https://github.com/Gnucash/gnucash/commit/4fdacb9b (commit) > via https://github.com/Gnucash/gnucash/commit/0a8d7a21 (commit) > from

Re: gnucash master: Multiple changes pushed

2016-10-09 Thread John Ralls
> On Oct 9, 2016, at 6:48 PM, Geert Janssens wrote: > > On Sunday 09 October 2016 04:54:11 John Ralls wrote: >> Updated via https://github.com/Gnucash/gnucash/commit/20c0271e >> (commit) via https://github.com/Gnucash/gnucash/commit/b00694fd >> (commit) from https://github.com/Gnucash/g

Re: gnucash master: Multiple changes pushed

2016-10-09 Thread Geert Janssens
On Sunday 09 October 2016 04:54:11 John Ralls wrote: > Updatedvia https://github.com/Gnucash/gnucash/commit/20c0271e > (commit) via https://github.com/Gnucash/gnucash/commit/b00694fd > (commit) from https://github.com/Gnucash/gnucash/commit/6e132d83 > (commit) > > > > commit 20c0271e9

Re: gnucash master: Multiple changes pushed

2016-06-12 Thread Aaron Laws
On Sun, Jun 12, 2016 at 11:48 AM, John Ralls wrote: > > > > > > > I'm not using guid's in my code. These errors are pulled in because of > the Account.h header > > that gets included somewhere. > > > > I saw one commit on the guid_header branch is including guid.hpp > everywhere. Is that what I >

Re: gnucash master: Multiple changes pushed

2016-06-12 Thread John Ralls
> On Jun 12, 2016, at 8:20 AM, Geert Janssens > wrote: > > On Thursday 09 June 2016 18:42:28 John Ralls wrote: >> Updated via https://github.com/Gnucash/gnucash/commit/2bbc1a19 >> (commit) via https://github.com/Gnucash/gnucash/commit/949ff816 >> (commit) via https://github.com/Gnucash

Re: gnucash master: Multiple changes pushed

2016-06-12 Thread Geert Janssens
On Thursday 09 June 2016 18:42:28 John Ralls wrote: > Updatedvia https://github.com/Gnucash/gnucash/commit/2bbc1a19 > (commit) via https://github.com/Gnucash/gnucash/commit/949ff816 > (commit) via https://github.com/Gnucash/gnucash/commit/ce190e34 > (commit) via https://github.com/Gnuca

Re: gnucash master: Multiple changes pushed

2015-11-03 Thread Geert Janssens
Thanks for the heads-up, Alex. Fixed in master now. Regards, Geert On Monday 02 November 2015 13:29:50 Alex Aycinena wrote: > Geert, > > I get this make failure on this change: > > /home/gnucash-dev/gitcheckouts/gnucash-clean/src/gnome/gnc-plugin-page > -register.c: In function 'gnc_plugin_page

Re: gnucash master: Multiple changes pushed

2015-11-02 Thread Alex Aycinena
Geert, I get this make failure on this change: /home/gnucash-dev/gitcheckouts/gnucash-clean/src/gnome/gnc-plugin-page-register.c: In function 'gnc_plugin_page_register_get_query': /home/gnucash-dev/gitcheckouts/gnucash-clean/src/gnome/gnc-plugin-page-register.c:1817:443: error: 'return' with no v

Re: gnucash master: Multiple changes pushed

2015-08-10 Thread Mike Alexander
> On Aug 10, 2015, at 3:05 AM, John Ralls wrote: > > I pushed the change Alex suggested to maint and that got my other change > synced to Github so everything should be OK now. I pushed changes to maint and master that I think fix things up. They replace my change to gnu-fq-helper.in on maste

Re: gnucash master: Multiple changes pushed

2015-08-10 Thread John Ralls
> On Aug 10, 2015, at 7:30 AM, John Ralls wrote: > > >> On Aug 9, 2015, at 11:51 PM, Mike Alexander wrote: >> >> --On August 9, 2015 at 10:36:52 AM +0100 John Ralls >> wrote: >> >>> m On Aug 8, 2015, at 5:00 PM, gnucash-patches-requ...@gnucash.org wrote: commit 1e16ba6c14ccec6222

Re: gnucash master: Multiple changes pushed

2015-08-09 Thread John Ralls
> On Aug 9, 2015, at 11:51 PM, Mike Alexander wrote: > > --On August 9, 2015 at 10:36:52 AM +0100 John Ralls > wrote: > >> m >>> On Aug 8, 2015, at 5:00 PM, gnucash-patches-requ...@gnucash.org >>> wrote: commit 1e16ba6c14ccec6222a8fe798e7824285fd49cac >>> Author: Mike Alexander >>> Date: F

Re: gnucash master: Multiple changes pushed

2015-08-09 Thread Mike Alexander
--On August 9, 2015 at 10:36:52 AM +0100 John Ralls wrote: m On Aug 8, 2015, at 5:00 PM, gnucash-patches-requ...@gnucash.org wrote: commit 1e16ba6c14ccec6222a8fe798e7824285fd49cac Author: Mike Alexander Date: Fri Aug 7 19:43:12 2015 -0400 Quote the date returned by get_quote_time so Sc

Re: gnucash master: Multiple changes pushed

2015-08-09 Thread John Ralls
m > On Aug 8, 2015, at 5:00 PM, gnucash-patches-requ...@gnucash.org wrote: > commit 1e16ba6c14ccec6222a8fe798e7824285fd49cac > Author: Mike Alexander > Date: Fri Aug 7 19:43:12 2015 -0400 > >Quote the date returned by get_quote_time so Scheme can read it. > > commit 655c04bd68d984272d8593e

Re: gnucash master: Multiple changes pushed

2015-08-05 Thread John Ralls
> On Aug 5, 2015, at 6:05 PM, Derek Atkins wrote: > > Geert Janssens writes: > >> On Tuesday 04 August 2015 12:00:06 Derek Atkins wrote: >>> Geert, >>> >>> This change seems like the wrong direction; the point of including the >>> book in the API was to reduce the need for global variables/st

Re: gnucash master: Multiple changes pushed

2015-08-05 Thread Derek Atkins
Geert Janssens writes: > On Tuesday 04 August 2015 12:00:06 Derek Atkins wrote: >> Geert, >> >> This change seems like the wrong direction; the point of including the >> book in the API was to reduce the need for global variables/storage. >> I'd like to see GnuCash move more towards being able t

Re: gnucash master: Multiple changes pushed

2015-08-04 Thread Geert Janssens
On Tuesday 04 August 2015 12:00:06 Derek Atkins wrote: > Geert, > > This change seems like the wrong direction; the point of including the > book in the API was to reduce the need for global variables/storage. > I'd like to see GnuCash move more towards being able to have multiple > files open sim

Re: gnucash master: Multiple changes pushed

2015-08-04 Thread Derek Atkins
Geert, This change seems like the wrong direction; the point of including the book in the API was to reduce the need for global variables/storage. I'd like to see GnuCash move more towards being able to have multiple files open simultaneously, not further away from it. I clearly missed the gnc:*c

Re: gnucash master: Multiple changes pushed

2014-12-08 Thread John Ralls
> On Dec 8, 2014, at 11:33 AM, Geert Janssens > wrote: > > John, > > How do you explain this push ? It's a push to master yet with several commits > from maint. I > don't see a merge happen from maint to master though ? Did you cherry-pick > them ? > Geert, No, I merged, but it did a fas

Re: gnucash master: Multiple changes pushed

2014-12-08 Thread Geert Janssens
John, How do you explain this push ? It's a push to master yet with several commits from maint. I don't see a merge happen from maint to master though ? Did you cherry-pick them ? Geert On Monday 08 December 2014 00:55:58 John Ralls wrote: > Updatedvia https://github.com/Gnucash/gnuc

Re: gnucash master: Multiple changes pushed

2014-08-23 Thread Geert Janssens
On Friday 22 August 2014 19:45:07 John Ralls wrote: > Updatedvia https://github.com/Gnucash/gnucash/commit/dd10aab5 > (commit) via https://github.com/Gnucash/gnucash/commit/3f8718ea > (commit) via https://github.com/Gnucash/gnucash/commit/bad092a4 > (commit) from https://github.com/Gnuc

Re: gnucash master: Multiple changes pushed

2014-08-08 Thread Aaron Laws
Jralls, Thanks, these will be very helpful! I'm sure I wouldn't have come up with that perl replacement for grep. In Christ, Aaron Laws On Fri, Aug 8, 2014 at 6:15 PM, John Ralls wrote: > Updated via https://github.com/Gnucash/gnucash/commit/e25c2a34 (commit) > via https://github

Re: gnucash master: Multiple changes pushed

2014-07-09 Thread John Ralls
On Jul 9, 2014, at 3:05 AM, Tim Janssen wrote: > Hello gnucash-devel, > > I've been following this thread and trying to compile GnuCash myself and have > been getting the same error about unrecognised command line option but have > gotten different results through experimenting. > > First of

Re: gnucash master: Multiple changes pushed

2014-07-08 Thread Tim Janssen
Hello gnucash-devel, I've been following this thread and trying to compile GnuCash myself and have been getting the same error about unrecognised command line option but have gotten different results through experimenting. First of all, I'm running Arch Linux 64bit. And gcc/g++ version 4.9.0. I'm

Re: gnucash master: Multiple changes pushed

2014-07-08 Thread John Ralls
On Jul 8, 2014, at 4:43 PM, Sumit Bhardwaj wrote: > On Mon, Jul 7, 2014 at 11:38 AM, John Ralls wrote: > > On Jul 7, 2014, at 4:03 PM, Sumit Bhardwaj wrote: >> Hi John, >> >> Sumit, >> >> I don't understand how you concluded that the AM_CXXFLAGS are being included >> when make builds gfec.

Re: gnucash master: Multiple changes pushed

2014-07-08 Thread Sumit Bhardwaj
> > On Mon, Jul 7, 2014 at 11:38 AM, John Ralls wrote: > > On Jul 7, 2014, at 4:03 PM, Sumit Bhardwaj wrote: > > Hi John, > > Sumit, >> >> I don't understand how you concluded that the AM_CXXFLAGS are being >> included when make builds gfec.c, nor do I understand why you think that >> it's using

Re: gnucash master: Multiple changes pushed

2014-07-07 Thread John Ralls
On Jul 7, 2014, at 4:03 PM, Sumit Bhardwaj wrote: > Hi John, > > Sumit, > > I don't understand how you concluded that the AM_CXXFLAGS are being included > when make builds gfec.c, nor do I understand why you think that it's using > g++. The command make emitted when it failed was: >>> gcc -

Re: gnucash master: Multiple changes pushed

2014-07-07 Thread John Ralls
On Jul 7, 2014, at 4:16 PM, Geert Janssens wrote: > On Sunday 06 July 2014 19:29:11 John Ralls wrote: > > On Jul 6, 2014, at 7:15 PM, Geert Janssens > > wrote: > > > John, > > > > > > I will be away on holidays soon. If you think my commit should be > > > reverted, feel free to do so. I doubt

Re: gnucash master: Multiple changes pushed

2014-07-07 Thread Geert Janssens
On Sunday 06 July 2014 19:29:11 John Ralls wrote: > On Jul 6, 2014, at 7:15 PM, Geert Janssens wrote: > > John, > > > > I will be away on holidays soon. If you think my commit should be > > reverted, feel free to do so. I doubt I will have much online time > > available while I'm gone. > Geert, >

Re: gnucash master: Multiple changes pushed

2014-07-07 Thread Sumit Bhardwaj
Hi John, Sumit, > > I don't understand how you concluded that the AM_CXXFLAGS are being > included when make builds gfec.c, nor do I understand why you think that > it's using g++. The command make emitted when it failed was: > > gcc -DHAVE_CONFIG_H -I. -I../.. -Wno-error=deprecated-declarations

Re: gnucash master: Multiple changes pushed

2014-07-06 Thread John Ralls
On Jul 7, 2014, at 2:07 AM, Sumit Bhardwaj wrote: > Just a quick update so everyone is on the same page: problem is not with > macro (autogen.sh) or configure. It seems the call for gfec.c mixes CFLAGS > and CXXFLAGS and then cc1plus or cc1 throws error. Diagnosis below. > > I did have to ma

Re: gnucash master: Multiple changes pushed

2014-07-06 Thread Sumit Bhardwaj
Just a quick update so everyone is on the same page: problem is not with macro (autogen.sh) or configure. It seems the call for gfec.c mixes CFLAGS and CXXFLAGS and then cc1plus or cc1 throws error. Diagnosis below. I did have to make changes in macros/m4_ax_check_compile_flag.m4. I pushed those c

Re: gnucash master: Multiple changes pushed

2014-07-06 Thread John Ralls
On Jul 6, 2014, at 7:15 PM, Geert Janssens wrote: > John, > > I will be away on holidays soon. If you think my commit should be reverted, > feel free to do so. I doubt I will have much online time available while I'm > gone. Geert, Yeah, you're not likely to have good connectivity. No worr

Re: gnucash master: Multiple changes pushed

2014-07-06 Thread Geert Janssens
John, I will be away on holidays soon. If you think my commit should be reverted, feel free to do so. I doubt I will have much online time available while I'm gone. Geert On Sunday 06 July 2014 10:05:27 John Ralls wrote: > On Jul 5, 2014, at 11:34 PM, Sumit Bhardwaj wrote: > > Sure, John. Her

Re: gnucash master: Multiple changes pushed

2014-07-06 Thread John Ralls
On Jul 6, 2014, at 6:38 PM, Sumit Bhardwaj wrote: > Hi John, > > That works - to an extent. gcc fails and the current configuration is: > -Werror -Wdeclaration-after-statement -Wno-pointer-sign -D_FORTIFY_SOURCE=2 > > Configure doesn't fail, but that the flags are far fewer than earlier. Is

Re: gnucash master: Multiple changes pushed

2014-07-06 Thread Sumit Bhardwaj
Hi John, That works - to an extent. gcc fails and the current configuration is: -Werror -Wdeclaration-after-statement -Wno-pointer-sign -D_FORTIFY_SOURCE=2 Configure doesn't fail, but that the flags are far fewer than earlier. Is this, what we want to go ahead with? If anyone wants to look at t

Re: gnucash master: Multiple changes pushed

2014-07-06 Thread John Ralls
On Jul 5, 2014, at 11:34 PM, Sumit Bhardwaj wrote: > Sure, John. Here you go. Interestingly, I didn't find conftest.c in the > directory tree. > > 'tree | grep conftest.c' gave no output. > > Thanks, > Sumit > > configure:25408: checking whether C++ compiler accepts > -Wno-deprecated-regist

Re: gnucash master: Multiple changes pushed

2014-07-05 Thread Sumit Bhardwaj
Sure, John. Here you go. Interestingly, I didn't find conftest.c in the directory tree. 'tree | grep conftest.c' gave no output. Thanks, Sumit configure:25408: checking whether C++ compiler accepts -Wno-deprecated-register configure:25427: g++ -c -g -O2 -std=gnu++11 -Werror -Wno-deprecated-regis

Re: gnucash master: Multiple changes pushed

2014-07-05 Thread jra...@ceridwen.us
> On July 5, 2014 at 11:35 AM Sumit Bhardwaj wrote: > > Hi John, > > It fails in first C compilation. I do have to do a "make disclean" to get the > error. Rebuilding with just uncommenting in configure doesn't throw error > which is why I didn't see it earlier. I have pasted the error stack

Re: gnucash master: Multiple changes pushed

2014-07-05 Thread Sumit Bhardwaj
Hi John, It fails in first C compilation. I do have to do a "make disclean" to get the error. Rebuilding with just uncommenting in configure doesn't throw error which is why I didn't see it earlier. I have pasted the error stack below. Do let me know if you want me to do any more experiments. For

Re: gnucash master: Multiple changes pushed

2014-07-05 Thread jra...@ceridwen.us
> On July 5, 2014 at 2:43 AM Sumit Bhardwaj wrote: > > Just a quick note on my problems with compiling master today with > Wno-non-literal-null-conversion. > > Compile kept on failing with the error message "gcc error: unrecognized > command line option" referring to the Wno-non-literal-null

Re: gnucash master: Multiple changes pushed

2014-07-04 Thread Sumit Bhardwaj
Just a quick note on my problems with compiling master today with Wno-non-literal-null-conversion. Compile kept on failing with the error message "gcc error: unrecognized command line option" referring to the Wno-non-literal-null-conversion flag. My gcc version is 4.8.3 20140624 (Red Hat 4.8.3-1)

Re: gnucash master: Multiple changes pushed

2014-07-04 Thread Geert Janssens
On Friday 04 July 2014 03:03:27 jra...@ceridwen.us wrote: > > On July 3, 2014 at 5:22 PM Geert Janssens wrote: > > On Thursday 03 July 2014 20:07:46 John Ralls wrote: > > > On Jul 3, 2014, at 7:25 PM, Geert Janssens > > > > > > > > wrote: > > > > Same issue but this time it may need some mo

Re: gnucash master: Multiple changes pushed

2014-07-04 Thread jra...@ceridwen.us
> On July 3, 2014 at 5:22 PM Geert Janssens wrote: > > On Thursday 03 July 2014 20:07:46 John Ralls wrote: > > On Jul 3, 2014, at 7:25 PM, Geert Janssens > > wrote: > > > Same issue but this time it may need some more careful testing. > > > TXN_TYPE_NONE may be used in other locations whe

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread Geert Janssens
On Thursday 03 July 2014 20:07:46 John Ralls wrote: > On Jul 3, 2014, at 7:25 PM, Geert Janssens wrote: > > Same issue but this time it may need some more careful testing. > > TXN_TYPE_NONE may be used in other locations where '\0' is assumed > > instead of NULL (guile comes to mind). I don't have

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread John Ralls
On Jul 3, 2014, at 7:25 PM, Geert Janssens wrote: > > I have fixed these as they were fairly trivial. clang next chokes in > gnc-tree-view-split-reg.c: > > /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/gnome-utils/gnc-tree-view-split-reg.c:5309:33: > error: expression whic

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread John Ralls
On Jul 3, 2014, at 6:04 PM, Geert Janssens wrote: > On Thursday 03 July 2014 17:51:42 John Ralls wrote: > > On Jul 3, 2014, at 4:16 PM, Geert Janssens > > wrote: > > > On Thursday 03 July 2014 16:09:28 John Ralls wrote: > > > > On Jul 3, 2014, at 3:58 PM, Geert Janssens > > > > wrote: > > >

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread Geert Janssens
On Thursday 03 July 2014 18:04:25 Geert Janssens wrote: > On Thursday 03 July 2014 17:51:42 John Ralls wrote: > > On Jul 3, 2014, at 4:16 PM, Geert Janssens > > wrote: > > > On Thursday 03 July 2014 16:09:28 John Ralls wrote: > > > > On Jul 3, 2014, at 3:58 PM, Geert Janssens > > > > wrote: > >

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread Geert Janssens
On Thursday 03 July 2014 17:51:42 John Ralls wrote: > On Jul 3, 2014, at 4:16 PM, Geert Janssens wrote: > > On Thursday 03 July 2014 16:09:28 John Ralls wrote: > > > On Jul 3, 2014, at 3:58 PM, Geert Janssens > > > wrote: > > > > Hmm, my previous mail got truncated by the list server > > > > for

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread John Ralls
On Jul 3, 2014, at 4:16 PM, Geert Janssens wrote: > On Thursday 03 July 2014 16:09:28 John Ralls wrote: > > On Jul 3, 2014, at 3:58 PM, Geert Janssens > > wrote: > > > Hmm, my previous mail got truncated by the list server > > > for some reason. Anyway the errors continue for a while > > > wit

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread Geert Janssens
On Thursday 03 July 2014 16:09:28 John Ralls wrote: > On Jul 3, 2014, at 3:58 PM, Geert Janssens wrote: > > Hmm, my previous mail got truncated by the list server > > for some reason. Anyway the errors continue for a while > > with yet more undefined references to std::xyz functions. > > > > This

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread John Ralls
On Jul 3, 2014, at 3:58 PM, Geert Janssens wrote: > Hmm, my previous mail got truncated by the list server > for some reason. Anyway the errors continue for a while > with yet more undefined references to std::xyz functions. > > This was with a clean autogen/configure/make sequence > in an e

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread Geert Janssens
Hmm, my previous mail got truncated by the list server for some reason. Anyway the errors continue for a while with yet more undefined references to std::xyz functions. This was with a clean autogen/configure/make sequence in an empty build directory. If I do the same with gcc it works fine.

Re: gnucash master: Multiple changes pushed

2014-07-03 Thread Geert Janssens
On Wednesday 02 July 2014 17:01:10 John Ralls wrote: > Updatedvia https://github.com/Gnucash/gnucash/commit/29923b1f > (commit) via https://github.com/Gnucash/gnucash/commit/773326b7 > (commit) from https://github.com/Gnucash/gnucash/commit/d3389828 > (commit) > > > > commit 29923b1fd

Re: gnucash master: Multiple changes pushed

2014-07-02 Thread Mike Alexander
--On July 2, 2014 at 5:01:10 PM -0400 John Ralls wrote: Updated via https://github.com/Gnucash/gnucash/commit/29923b1f (commit) via https://github.com/Gnucash/gnucash/commit/773326b7 (commit)from https://github.com/Gnucash/gnucash/commit/d3389828 (commit) commit 29923b1f

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-06-12 Thread Aaron Laws
I just updated guid.cpp to use boost, and I was very pleased at the lack of explosions :-) I issued a pull request to jralls, but for general perusal, you can see it here: https://github.com/limitedAtonement/gnucash/commit/3dc5159cb57f25dc606416263bee8b23da3e6ffe In Christ, Aaron Laws On Mon, A

Re: gnucash master: Multiple changes pushed

2014-04-29 Thread Geert Janssens
I noticed this as well with John's c++ related commits. It appears that the mail script will only print diffs for commits that are pushed directly to a branch and not for commits that get merged in. I seem to remember this was explained in the beginning of these mails before John reduced the

Re: gnucash master: Multiple changes pushed

2014-04-29 Thread Derek Atkins
Any reason why the email script didn't print out a 'diff' for this changeset? -derek Geert Janssens writes: > Updatedvia https://github.com/Gnucash/gnucash/commit/8784b944 > (commit) >via https://github.com/Gnucash/gnucash/commit/c4bbd145 (commit) > from https://github

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-28 Thread John Ralls
On Apr 28, 2014, at 10:55 AM, Mike Alexander wrote: > --On April 28, 2014 9:04:06 AM -0700 John Ralls wrote: > >> >> On Apr 28, 2014, at 8:51 AM, Mike Alexander wrote: >> >>> --On April 28, 2014 7:47:07 AM -0700 John Ralls >>> wrote: >>> I'll make gnucash-bin.cpp after that. >>> >>>

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-28 Thread Mike Alexander
--On April 28, 2014 9:04:06 AM -0700 John Ralls wrote: On Apr 28, 2014, at 8:51 AM, Mike Alexander wrote: --On April 28, 2014 7:47:07 AM -0700 John Ralls wrote: I'll make gnucash-bin.cpp after that. Why not do it first? It needs to be done sooner or later and that might avoid some of

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-28 Thread John Ralls
On Apr 28, 2014, at 8:51 AM, Mike Alexander wrote: > --On April 28, 2014 7:47:07 AM -0700 John Ralls wrote: > >> I'll make gnucash-bin.cpp after that. > > Why not do it first? It needs to be done sooner or later and that might > avoid some of the explosions. I *want* the explosions. Think

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-28 Thread Mike Alexander
--On April 28, 2014 7:47:07 AM -0700 John Ralls wrote: I'll make gnucash-bin.cpp after that. Why not do it first? It needs to be done sooner or later and that might avoid some of the explosions. Mike ___ gnucash-devel mailing list

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-28 Thread John Ralls
On Apr 27, 2014, at 7:58 PM, Mike Alexander wrote: > On Apr 27, 2014, at 5:15 PM, John Ralls wrote: >> >> However, I don’t think changing files one by one is wise: It will result in >> libraries with objects compiled with different compilers, and I worry that >> that will introduce difficult

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-27 Thread Mike Alexander
On Apr 27, 2014, at 5:15 PM, John Ralls wrote: > > However, I don’t think changing files one by one is wise: It will result in > libraries with objects compiled with different compilers, and I worry that > that will introduce difficult to understand bugs. That’s not a matter for > immediate co

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-27 Thread John Ralls
On Apr 27, 2014, at 2:15 PM, John Ralls wrote: > > On Apr 27, 2014, at 2:01 PM, Mike Alexander wrote: > >> --On April 27, 2014 10:06:24 PM +0200 Christian Stimming >> wrote: >> >>> Can we please trigger the switch from C to C++ by renaming the files, >>> one by one? This makes it clear wh

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-27 Thread John Ralls
On Apr 27, 2014, at 2:01 PM, Mike Alexander wrote: > --On April 27, 2014 10:06:24 PM +0200 Christian Stimming > wrote: > >> Can we please trigger the switch from C to C++ by renaming the files, >> one by one? This makes it clear which files have to adhere to C++ >> rules and which ones don'

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-27 Thread Mike Alexander
--On April 27, 2014 10:06:24 PM +0200 Christian Stimming wrote: Can we please trigger the switch from C to C++ by renaming the files, one by one? This makes it clear which files have to adhere to C++ rules and which ones don't have to. Thanks! I agree with this. Compiling C files as C++ c

Re: switching to C++ compiling by -xc++ (was: gnucash master: Multiple changes pushed)

2014-04-27 Thread Christian Stimming
Hi John, in bedf00a160669a86942a1b52f47c65b8c45c9552 you said you changed "LibQOF to be compiled as C++", which you did by adding "-xc++" to the CFLAGS, but leaving the file suffixes as ".c". This isn't nice. The convention throughout all projects that I know so far is that if the file ends i

Re: gnucash master: Multiple changes pushed

2014-03-31 Thread John Ralls
On Mar 31, 2014, at 1:51 PM, Christian Stimming wrote: > Hi John, > > in the commit message you wrote "gwenhywfar-4.10.0 breaks the build", but > have you actually checked 4.10.0? I only have a mingw cross-compiler here > which runs fine with 4.10.0 but IIRC also did 4.11.0 correctly, so I'

Re: gnucash master: Multiple changes pushed

2014-03-31 Thread Christian Stimming
Hi John, in the commit message you wrote "gwenhywfar-4.10.0 breaks the build", but have you actually checked 4.10.0? I only have a mingw cross-compiler here which runs fine with 4.10.0 but IIRC also did 4.11.0 correctly, so I'm not sure whether you've observed something that I didn't. Surely