Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-27 Thread Christian Stimming
Chris Shoemaker schrieb: Oh, I just remembered why distcheck failed for me the last time. It tried to configure/compile with strict defaults, and since I need the -Wno-pointer-sign, it won't compile. FTR: IIRC -Wno-pointer-sign was newly introduced in gcc4, so we cannot add that as a general

Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-27 Thread David Hampton
On Fri, 2006-01-27 at 10:36 +0100, Christian Stimming wrote: FTR: IIRC -Wno-pointer-sign was newly introduced in gcc4, so we cannot add that as a general flag as gcc3.x would refuse to work. If we decide to include this by default, we would need to add this only for gcc = 4.0.0.

Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-26 Thread David Hampton
Chris, This patch broke the tree for everyone compiling with --enable-error-on-warning (which is the default setting). Please compile your tree with this flag enabled before committing. David On Thu, 2006-01-26 at 21:12 -0500, Chris Shoemaker wrote: Author: chris Date: 2006-01-26 21:12:41

Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-26 Thread Chris Shoemaker
On Fri, Jan 27, 2006 at 12:04:13AM -0500, David Hampton wrote: Chris, This patch broke the tree for everyone compiling with --enable-error-on-warning (which is the default setting). Please compile your tree with this flag enabled before committing. I'm configuring with: ./configure -C

Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-26 Thread Chris Shoemaker
On Fri, Jan 27, 2006 at 12:04:13AM -0500, David Hampton wrote: Chris, This patch broke the tree for everyone compiling with --enable-error-on-warning (which is the default setting). Please compile your tree with this flag enabled before committing. Well, it can't be _everyone_. I just

Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-26 Thread David Hampton
On Fri, 2006-01-27 at 00:19 -0500, Chris Shoemaker wrote: I'm configuring with: ./configure -C CFLAGS=-O0 -Wno-pointer-sign --enable-maintainer-mode --enable-etags --prefix=/opt/gnucash-g2 --enable-opt-style-install --enable-debug Should I explicitly add --enable-error-on-warning? I'm

Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-26 Thread Chris Shoemaker
On Fri, Jan 27, 2006 at 12:38:12AM -0500, David Hampton wrote: On Fri, 2006-01-27 at 00:19 -0500, Chris Shoemaker wrote: I'm configuring with: ./configure -C CFLAGS=-O0 -Wno-pointer-sign --enable-maintainer-mode --enable-etags --prefix=/opt/gnucash-g2 --enable-opt-style-install

Re: r12984 - gnucash/trunk/src - Move the global report hash-table from guile to C.

2006-01-26 Thread David Hampton
On Fri, 2006-01-27 at 00:36 -0500, Chris Shoemaker wrote: On Fri, Jan 27, 2006 at 12:04:13AM -0500, David Hampton wrote: Chris, This patch broke the tree for everyone compiling with --enable-error-on-warning (which is the default setting). Please compile your tree with this flag