[GNUnet-developers] Coding style clang-format

Hi, FYI I added a clang-format at "contrib/conf/editors/clang-format". Clang-format is usable with most editors (vim, emacs, vscode) with respective plugins. This way, we can have a unified coding style. Clang-format has a nice documentation and allows fine-grained setting which are also human r

Re: [GNUnet-developers] Coding style clang-format

Am 15.04.19 um 10:02 schrieb Schanzenbach, Martin: > FYI I added a clang-format at "contrib/conf/editors/clang-format". I'm curious about this, since the development guide says: "We follow the GNU Coding Standards (see The GNU Coding Standards

Re: [GNUnet-developers] Coding style clang-format

Hi Hartmut, It's a bit disheartening to see an honest attempt to improve things being shot down like this. The clang-format style that Martin created tries to mirror what style the existing codebase already has or is supposed to have. If you want to make any tweaks on top of that, please contrib

Re: [GNUnet-developers] Coding style clang-format

> On 15. Apr 2019, at 10:53, Hartmut Goebel > wrote: > > Am 15.04.19 um 10:02 schrieb Schanzenbach, Martin: >> FYI I added a clang-format at "contrib/conf/editors/clang-format". > > I'm curious about this, since the development guide says: "We follow the > GNU Coding Standards (see The GNU Co

Re: [GNUnet-developers] Coding style clang-format

Dear all, First of all, I like Martin's initiative as any attempt at trying to improve the situation is very welcome. Hartmut is of course right that it should be discussed, but I think committing the files first so we have a good basis for discussion was also the right move. It's not like Martin

Re: [GNUnet-developers] Coding style clang-format

> On 15. Apr 2019, at 12:24, Christian Grothoff wrote: > > Signed PGP part > Dear all, > > First of all, I like Martin's initiative as any attempt at trying to > improve the situation is very welcome. Hartmut is of course right that > it should be discussed, but I think committing the files fi

Re: [GNUnet-developers] Coding style clang-format

Schanzenbach, Martin transcribed 6.4K bytes: > > > > On 15. Apr 2019, at 12:24, Christian Grothoff wrote: > > > > Signed PGP part > > Dear all, > > > > First of all, I like Martin's initiative as any attempt at trying to > > improve the situation is very welcome. Hartmut is of course right tha

Re: [GNUnet-developers] Coding style clang-format

Hi Martin. > It has nothing to do with the clang (you probably mean llvm) coding style. It > is a code formatting tool. Thanks for the clarification. So I simply misunderstood the intention of your work and completely withdraw my objection. -- Regards Hartmut Goebel | Hartmut Goebel

Re: [GNUnet-developers] Coding style clang-format

> On 15. Apr 2019, at 12:24, Christian Grothoff wrote: > > Signed PGP part > Dear all, > > First of all, I like Martin's initiative as any attempt at trying to > improve the situation is very welcome. Hartmut is of course right that > it should be discussed, but I think committing the files fi

Re: [GNUnet-developers] Coding style clang-format

On 4/16/19 10:48 AM, Schanzenbach, Martin wrote: > I added your changes with two notes: > > 1. SpaceAfterLogicalNot: true => This option does not seems to exist > (anymore?) That's a pity. I think this is a nice way to emphasize the not. > 2. AllowAllParametersOfDeclarationOnNextLine: false # C

Re: [GNUnet-developers] Coding style clang-format

> On 16. Apr 2019, at 10:54, Christian Grothoff wrote: > > Signed PGP part > On 4/16/19 10:48 AM, Schanzenbach, Martin wrote: >> I added your changes with two notes: >> >> 1. SpaceAfterLogicalNot: true => This option does not seems to exist >> (anymore?) > > That's a pity. I think this is a

Re: [GNUnet-developers] Coding style clang-format

Updated the format file with all your propsals. Now needs a clang-format which at least includes this commit: https://github.com/llvm-mirror/clang/commit/c4515d09740be87226d185f7728893d26c5af652 i.e. > clang 8.0.0; let's hope they release soon (tm) > On 16. Apr 2019, at 11:17, Schanzenbach, Mar