Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-22 Thread Alessio Vanni
Hello, I wrote a small service which is meant to be part of a bigger project. While I was checking stdout to see if everything worked correctly, I was notified that there was no handle for a message of type 6 and size 4 (and subsequently that the handle in the service didn't call `GNUNET_SERVICE_c

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-22 Thread Christian Grothoff
Hi Alessio, I'm pretty sure that we don't actually ever send the REQUEST_AGPL messages to services. So if you got one, that suggests that either your transmission was somehow wrong (i.e. wrong length, maybe big-endian/little-endian issue?) or you have some memory corruption in your service. At lea

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-22 Thread Alessio Vanni
Christian Grothoff writes: > Hi Alessio, > > I'm pretty sure that we don't actually ever send the REQUEST_AGPL > messages to services. So if you got one, that suggests that either your > transmission was somehow wrong (i.e. wrong length, maybe > big-endian/little-endian issue?) or you have some m

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-23 Thread Schanzenbach, Martin
Hi, if your service is not actually a service (that serves clients) maybe you should try making it a program instead? Look at src/rest/gnunet-rest-server.c OTOH if you do have clients then you _must_ to call client_continue which will send messages of type 6 as this is part of the GNUnet client/s

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-23 Thread Christian Grothoff
On 5/23/20 12:48 AM, Alessio Vanni wrote: > Thank you. It's better than nothing I suppose; at least I'm not left > here scratching my head, as I can look into those places you suggested. > Anyway, if possible I'd still like to know why `GNUNET_SERVICE_start' > adds a handler for that type of messa

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-23 Thread Alessio Vanni
Christian Grothoff writes: > Actually, no. Type 6 implements our *Affero* GPL mechanism to provide > anyone who accesses *any* GNUnet service with the means to download the > source code. GNUnet is released under the AGPL, which specifically > states that such a mechanism to obtain the source mus

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-23 Thread Christian Grothoff
On 5/23/20 2:38 PM, Alessio Vanni wrote: > Christian Grothoff writes: > >> Actually, no. Type 6 implements our *Affero* GPL mechanism to provide >> anyone who accesses *any* GNUnet service with the means to download the >> source code. GNUnet is released under the AGPL, which specifically >> stat

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-25 Thread Alessio Vanni
Christian Grothoff writes: > If you are linking against GNUnet libraries, you fall under the AGPL. > It does not matter whether you are in our repository. That was the missing link. From what I gathered the license is like the normal GPL so my application will have to be licensed as AGPL too.

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-25 Thread Christian Grothoff
On 5/25/20 2:58 PM, Alessio Vanni wrote: > Christian Grothoff writes: > >> If you are linking against GNUnet libraries, you fall under the AGPL. >> It does not matter whether you are in our repository. > > That was the missing link. From what I gathered the license is like the > normal GPL so m

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-27 Thread Alessio Vanni
Christian Grothoff writes: > Yes, we should modify the code along the lines of your proposal. > > -Christian Then does the attached patch sound reasonable? As the commit message says, it adds the 'agpl_url' field and automatically adds a handler when that field is not NULL. There is also a pat

Re: Is there a reason why GNUnet forcefully sends a message of type 6?

2020-05-27 Thread Christian Grothoff
On 5/27/20 6:04 PM, Alessio Vanni wrote: > Then does the attached patch sound reasonable? Yes, perfect, applied as is. -Christian signature.asc Description: OpenPGP digital signature