Re: problems compiling NSAnimation.m

2007-05-10 Thread Graham J Lee
On 9 May 2007, at 17:53, Xavier Glattard wrote: Riccardo multix at ngi.it writes: #define _NSANIMATION_LOCK \ BOOL __gs_isLocked = NO; \ if (_isThreaded) \ { \ __gs_isLocked = YES;\

Re: problems compiling NSAnimation.m

2007-05-10 Thread Nicola Pero
On May 8, 2007, at 11:14 PM, Riccardo wrote: Hi, trying to compile NSAnimation on older compilers is a nightmare (like gcc 2.95). I fixed some trivial stuff, but then stopped: the main problem is the _NSANIMATION_LOCK macro. Since this macro defines a variable in it, #define

Re: problems compiling NSAnimation.m

2007-05-10 Thread Graham J Lee
On 10 May 2007, at 12:35, Nicola Pero wrote: Is there a flag we can pass to ask GCC to refuse c99-isms ? There must be one. -std=c89 or -std=gnu89 depending on whether we want to permit GNU C extensions. Cheers, Graham. ___ Gnustep-dev

Re: problems compiling NSAnimation.m

2007-05-10 Thread Richard Frith-Macdonald
On 10 May 2007, at 12:35, Nicola Pero wrote: On May 8, 2007, at 11:14 PM, Riccardo wrote: Hi, trying to compile NSAnimation on older compilers is a nightmare (like gcc 2.95). I fixed some trivial stuff, but then stopped: the main problem is the _NSANIMATION_LOCK macro. Since this macro

Re: problems compiling NSAnimation.m

2007-05-10 Thread Richard Frith-Macdonald
On 10 May 2007, at 12:41, Graham J Lee wrote: On 10 May 2007, at 12:35, Nicola Pero wrote: Is there a flag we can pass to ask GCC to refuse c99-isms ? There must be one. -std=c89 or -std=gnu89 depending on whether we want to permit GNU C extensions. I don't believe those work for

Fwd: problems compiling NSAnimation.m

2007-05-10 Thread Nicola Pero
Sorry, forgot to put the mailing list in Cc: Thanks Is there a flag we can pass to ask GCC to refuse c99-isms ? There must be one. -std=c89 or -std=gnu89 depending on whether we want to permit GNU C extensions. Nicola answered: Actually, they seem to work -- the problem is that

Re: problems compiling NSAnimation.m

2007-05-10 Thread Graham J Lee
On 10 May 2007, at 13:44, Nicola Pero wrote: Sorry, forgot to put the mailing list in Cc: Thanks Is there a flag we can pass to ask GCC to refuse c99-isms ? There must be one. -std=c89 or -std=gnu89 depending on whether we want to permit GNU C extensions. Nicola answered: Actually,

Re: problems compiling NSAnimation.m

2007-05-10 Thread Richard Frith-Macdonald
On 10 May 2007, at 14:57, Xavier Glattard wrote: Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: On 10 May 2007, at 12:35, Nicola Pero wrote: (...) This looks pretty bad, not only because it doesn't compile with GCC 2.95, but also because that variable defined in the

Re: problems compiling NSAnimation.m

2007-05-10 Thread Xavier Glattard
Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: On 10 May 2007, at 14:57, Xavier Glattard wrote: Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: (...) This macro is used as a macro : to repeat again and again the same piece of code. It only has to be

Re: problems compiling NSAnimation.m

2007-05-10 Thread Graham J Lee
On 10 May 2007, at 15:28, Xavier Glattard wrote: Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: On 10 May 2007, at 14:57, Xavier Glattard wrote: Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: I fixed this to make __gs_isLocked an ivar rather than

Re: problems compiling NSAnimation.m

2007-05-10 Thread Richard Frith-Macdonald
On 10 May 2007, at 15:37, Graham J Lee wrote: On 10 May 2007, at 15:28, Xavier Glattard wrote: Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: On 10 May 2007, at 14:57, Xavier Glattard wrote: Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: I fixed this

Re: problems compiling NSAnimation.m

2007-05-10 Thread Richard Frith-Macdonald
On 10 May 2007, at 15:28, Xavier Glattard wrote: I fixed this to make __gs_isLocked an ivar rather than declaring it locally (which was pretty suboptimal). I also fixed a bug in the unlock macro (it was setting the lag to the wrong value), and added assertions to check that the macro is not

Re: problems compiling NSAnimation.m

2007-05-10 Thread Xavier Glattard
Richard Frith-Macdonald richard at tiptree.demon.co.uk writes: (...) Making it an ivar *fixes* the code to work with an older compiler Making it an ivar breaks the class in thread mode. ;-) (...) Actually that's not correct ... the lock is an ivar and is *not* local to the method, so as

Re: problems compiling NSAnimation.m

2007-05-10 Thread Nicola Pero
This looks pretty bad, not only because it doesn't compile with GCC 2.95, but also because that variable defined in the middle of nowhere is very ugly ... unclear scope (what happens if you have two _NSANIMATION_LOCK in sequence ? is the same variable being used or different variables ?) ...

Re: problems compiling NSAnimation.m

2007-05-10 Thread Xavier Glattard
Nicola Pero nicola.pero at meta-innovation.com writes: (...) very confusing, because when the second declaration of c is reached, you need to be a C standard lawyer to know what happens Yes, but only a C-riminal would do such a thing ;-) (...) What about adding a macro

gui linking problem

2007-05-10 Thread Riccardo
Hi, after the fixes of NSAnimation and some other small stuff I fixed myself, gui compilation on my older box fails with: Compiling file set_show_service.m ... Linking tool set_show_service ... /usr/bin/ld: warning: type and size of dynamic symbol `__objc_class_name_NSProcessInfo' are not