Getting reviews and submitting patches

2009-06-14 Thread Dave MacLachlan
Sorry for the newbie question, but I want to make sure I get it right ;-) I've got a couple of patches that I'd like to submit to gnustep-base. Google has signed off on having them submitted to the project, so the legal steps are taken care of already. a) Is there a coding standard for

Bad Undefines in NSKeyedArchiver and NSKeyedArchiver?

2009-06-13 Thread Dave MacLachlan
Excuse me if this is a silly question, but I just ran into problems compiling these two headers (Foundation/NSKeyedArchiver.h and Foundation/NSArchiver.h) and the fix looks obvious, but it's also obvious that these files have been this way for years. In both cases they have code that looks

Re: Bad Undefines in NSKeyedArchiver and NSKeyedArchiver?

2009-06-13 Thread Dave MacLachlan
On Jun 13, 2009, at 01:19 , Richard Frith-Macdonald wrote: On 13 Jun 2009, at 07:26, Dave MacLachlan wrote: Excuse me if this is a silly question, but I just ran into problems compiling these two headers (Foundation/NSKeyedArchiver.h and Foundation/NSArchiver.h) and the fix looks obvious

NSCalendar and NSLocale support

2009-06-13 Thread Dave MacLachlan
Hey there... I'm looking to add NSCalendar and NSLocale to Foundation. I'm happy to implement them, but I was hoping to do it on top of ICU (http://site.icu-project.org/ ). Are we willing to add a dependency on ICU to gnustep? The ICU license is GNU GPL compatible...