Re: [Gnustep-cvs] r22843 - in /libs/gui/trunk: ChangeLog Source/NSMenu.m

2006-05-01 Thread Fred Kiefer
Hi Richard, I just checked this change and found that you have hard coded the value of NSCommandKeyMask as the modifier. If I see correctly, the modifier could be changed on the menu item, so it looks better to use [item keyEquivalentModifierMask]. Most likely this error was already in the old cod

Re: [Gnustep-cvs] r22843 - in /libs/gui/trunk: ChangeLog Source/NSMenu.m

2006-05-01 Thread Alex Perez
Fred Kiefer wrote: Hi Richard, I just checked this change and found that you have hard coded the value of NSCommandKeyMask as the modifier. If I see correctly, the modifier could be changed on the menu item, so it looks better to use [item keyEquivalentModifierMask]. Most likely this error was a

Re: [Gnustep-cvs] r22843 - in /libs/gui/trunk: ChangeLog Source/NSMenu.m

2006-05-04 Thread Richard Frith-Macdonald
On 1 May 2006, at 16:02, Fred Kiefer wrote: Hi Richard, I just checked this change and found that you have hard coded the value of NSCommandKeyMask as the modifier. If I see correctly, the modifier could be changed on the menu item, so it looks better to use [item keyEquivalentModifierMask]