Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread A. Arias
El mié, 27-02-2013 a las 19:15 +0100, Jean-Charles BERTIN escribió: > I already posted a pull request on github for all that stuff but since > I've got no echo, so I decided to post the patches on the list. > Contributions are welcome. But be sure to read first: http://wiki.gnustep.org/index.php

Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Riccardo Mottola
Jean-Charles BERTIN wrote: Sorry i thought it will be easier for you to review patches one by one instead of a big fat patch. well, I prefer actually a set of small patches than a big patch.. one should not attach megabytes to a Mailing list. Much easier to review and comment singularly. It i

Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Ivan Vučica
Jean-Charles, Erlang is a backup, readonly replica of the SVN repository and (almost) noone is actively monitoring it, especially not the pull requests. Perhaps you'll want to create a pull request on the GitHub repositories, just as you did, and then just inform the list so someone reviews the

Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Jean-Charles BERTIN
I already posted a pull request on github for all that stuff but since I've got no echo, so I decided to post the patches on the list. On Wed, 2013-02-27 at 17:42 +, David Chisnall wrote: > On 27 Feb 2013, at 17:33, Ivan Vučica wrote: > > > The spamminess is the primary complaint I had, beca

Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread David Chisnall
On 27 Feb 2013, at 17:33, Ivan Vučica wrote: > The spamminess is the primary complaint I had, because contributions are > certainly welcome. Perhaps you could just provide a single email with e.g. > ten patch file attachments in the future? Ideally, please also don't post large attachments to

Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Ivan Vučica
It's certainly easier for whoever will be reviewing it; but it's a lot of spam on a normally very quiet list :-) The spamminess is the primary complaint I had, because contributions are certainly welcome. Perhaps you could just provide a single email with e.g. ten patch file attachments in the

Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Jean-Charles BERTIN
Sorry i thought it will be easier for you to review patches one by one instead of a big fat patch. I will re-post them. Regards. On Wed, 2013-02-27 at 17:56 +0100, Ivan Vučica wrote: > Jean-Charles, > > Can I please kindly ask you to (at the very least) combine patches into one > mail, and poss

Re: [PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Ivan Vučica
Jean-Charles, Can I please kindly ask you to (at the very least) combine patches into one mail, and possibly combine them into one file? Getting thirty or so mails at once is not fun, especially since I, for one, will not be reviewing the patches -- I follow the mailing list for different reas

[PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Jean-Charles BERTIN
--- SQLClient.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SQLClient.m b/SQLClient.m index 08284c6..4160153 100644 --- a/SQLClient.m +++ b/SQLClient.m @@ -1622,7 +1622,7 @@ static unsigned int maxConnections = 8; - (NSString*) quoteBigInteger: (int64_t)i { - return [N

[PATCH 2/2] Fixed warnings in printf-like formats.

2013-02-27 Thread Jean-Charles BERTIN
--- GSFIFO.m | 12 GSLinkedList.m | 2 +- GSSkipMutableArray.m | 25 + GSThreadPool.m | 9 ++--- GSThroughput.m | 4 ++-- 5 files changed, 30 insertions(+), 22 deletions(-) diff --git a/GSFIFO.m b/GSFIFO.m index 6379d61..e0