Diff to make core compile with gcc-4.1 prerelease

2005-10-06 Thread Gregory John Casamento
Please find the attached patch. Basically, it just coerces all of the problem places to id prior to coercing it to GSIMapVal/GSIMapKey/etc. This fixes the problem, but I'm not sure it's the cleanest solution. I ran a test recently on gcc 3.4.3, using the attached simple test.c program. I got t

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread David Ayers
Gregory John Casamento schrieb: > Please find the attached patch. > > Basically, it just coerces all of the problem places to id prior to coercing > it > to GSIMapVal/GSIMapKey/etc. This fixes the problem, but I'm not sure it's the > cleanest solution. > > I ran a test recently on gcc 3.4.3, us

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread Richard Frith-Macdonald
On 2005-10-07 08:20:56 + David Ayers <[EMAIL PROTECTED]> wrote: but this is not what we are doing, as long and int are distinct types. As you noticed this would have been an error in previous versions of GCC. In our case there are the special ObjC semantics that any objects could be matched

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread David Ayers
Richard Frith-Macdonald schrieb: > However, while this cast to union feature is non-standard anyway its > behavior is therefore hard to classify as a definite bug, I do think the > new behavior is non-intuitive, and it would be better if it handled > assignment of any pointer to a void* member and

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread Gregory John Casamento
David, --- David Ayers <[EMAIL PROTECTED]> wrote: > Gregory John Casamento schrieb: > > Please find the attached patch. > > > > Basically, it just coerces all of the problem places to id prior to > coercing it > > to GSIMapVal/GSIMapKey/etc. This fixes the problem, but I'm not sure it's > the >

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread Gregory John Casamento
David, --- David Ayers <[EMAIL PROTECTED]> wrote: > Richard Frith-Macdonald schrieb: > > > However, while this cast to union feature is non-standard anyway its > > behavior is therefore hard to classify as a definite bug, I do think the > > new behavior is non-intuitive, and it would be better i

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread Richard Frith-Macdonald
On 2005-10-07 13:49:55 + Gregory John Casamento <[EMAIL PROTECTED]> wrote: So, should I commit my changes? Should we submit a bug to the gcc maintainers? Um ... I committed them ... on the assumption that there won't be a quick fix to gcc. However, I think it would be good if the gc

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread Gregory John Casamento
Richard, --- Richard Frith-Macdonald <[EMAIL PROTECTED]> wrote: > On 2005-10-07 13:49:55 + Gregory John Casamento > <[EMAIL PROTECTED]> wrote: > > > So, should I commit my changes? Should we submit a bug to the gcc > > maintainers? > > Um ... I committed them ... on the assumption that

Re: Diff to make core compile with gcc-4.1 prerelease

2005-10-07 Thread Gregory John Casamento
Got it, nevermind. :) --- Gregory John Casamento <[EMAIL PROTECTED]> wrote: > Richard, > > --- Richard Frith-Macdonald <[EMAIL PROTECTED]> wrote: > > > On 2005-10-07 13:49:55 + Gregory John Casamento > > <[EMAIL PROTECTED]> wrote: > > > > > So, should I commit my changes? Should we subm