Re: Submitting patches

2010-06-22 Thread Gregory Casamento
Hey Thomas, On Tue, Jun 22, 2010 at 11:31 AM, Thomas Davie wrote: > Hi again, > > First off, many thanks to David and Richard for your help getting me up and > running. > > Secondly, I have a couple of patches that I'm not certain if they're bugs in > GNUstep, but they're certainly points at wh

Re: Submitting patches

2010-06-22 Thread David Chisnall
On 22 Jun 2010, at 16:35, David Chisnall wrote: >> c) attach a patch > > svn diff, and post to the list. And one thing I forgot to mention: If you plan on contributing nontrivial things, the GNU project requires that you sign a copyright assignment form. Poke Gregory to get one of these sent

Re: Submitting patches

2010-06-22 Thread David Chisnall
On 22 Jun 2010, at 16:31, Thomas Davie wrote: > Hi again, > > First off, many thanks to David and Richard for your help getting me up and > running. > > Secondly, I have a couple of patches that I'm not certain if they're bugs in > GNUstep, but they're certainly points at which GNUstep disagr

Submitting patches

2010-06-22 Thread Thomas Davie
Hi again, First off, many thanks to David and Richard for your help getting me up and running. Secondly, I have a couple of patches that I'm not certain if they're bugs in GNUstep, but they're certainly points at which GNUstep disagrees with apple's implementation. What's the best way for me

Re: Getting reviews and submitting patches

2009-06-15 Thread Yavor Doganov
В Sun, 14 Jun 2009 18:56:40 +0100, Richard Frith-Macdonald написа: > On 14 Jun 2009, at 17:20, Dave MacLachlan wrote: >> Google has signed off on having them submitted to the project, so the >> legal steps are taken care of already. > > Including copyright assignment to the FSF? That's a requirem

Re: Getting reviews and submitting patches

2009-06-14 Thread Riccardo Mottola
l maintainer. c) Anything else I should know before diving into the world of submitting patches? for small stuff usually it is fine. Before adding dependencies, ask. A last note, we still are gcc 2.95 compatible so please, avoid c-99isms and some of the known limitations of that compiler. I wil

Re: Getting reviews and submitting patches

2009-06-14 Thread Richard Frith-Macdonald
discussion mailing list is good if nobody has commented within a few days. c) Anything else I should know before diving into the world of submitting patches? General principles ... try to keep patches small so that they can be reviewed easily/quickly, and so that changes can be done

Re: Getting reviews and submitting patches

2009-06-14 Thread David Chisnall
review system (yet...). c) Anything else I should know before diving into the world of submitting patches? Nothing springs to mind. The first step is doing the copyright assignment. David ___ Gnustep-dev mailing list Gnustep-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnustep-dev

Getting reviews and submitting patches

2009-06-14 Thread Dave MacLachlan
andard for gnustep somewhere that I missed? Right now I'm guessing no. b) How do people normally handle reviews? c) Anything else I should know before diving into the world of submitting patches? Cheers (and thanks), Dave ___ Gnustep-dev maili