[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Nicolas Mailhot
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @jcajka I agree from a theoretical POW. I was just pointing out that from a practical POW, asking all the Go parts we package to adhere strictly to the specs, means dealing with a l

[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Jakub Čajka
jcajka commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @nim TBH I don't think that we should be creating our own dialect of Go(even from tooling perspective). What you are suggesting is basically it. We should respect upstream specs

[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Nicolas Mailhot
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @obudai a lot of Go projects use internal in the package path to mean the same thing as the internal keyword. Welcome to the wonderful land of underspecified Go behaviour. Therefor

[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Ondřej Budai
obudai commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` But if I undrestand things correctly this is not connected with internal keyword in any way. It wouldn't list all packages even if they're not internal. `` To reply, visit the li

[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Nicolas Mailhot
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` That would wreck havoc on all package BRs since internal is a magic keyword that forbids exposing the result to other Go packages. Returning anything internal in `golist` must be is

[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Ondřej Budai
obudai commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` Running ``` golist --provided --tests --package-path github.com/osbuild/osbuild-composer ``` Without fix: ``` github.com/osbuild/osbuild-composer/internal/crypt github.com/osbuil

[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Elliott Sales de Andrade
qulogic commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` Do you have an example? `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ gol

[golist] PR #27: Fix not listing packages with external tests only

2019-11-29 Thread Ondřej Budai
obudai opened a new pull-request against the project: `golist` that you are following: `` Fix not listing packages with external tests only `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golan