linkdupont reported a new issue against the project: `go-rpm-macros` that you
are following:
``
In #34 and #35, it was brought up to rename the `BUILDTAGS` variable to
`GOBUILDTAGS` in order to be more explicit about the intended use of the
variables and to avoid any potential namespace collisi
linkdupont commented on the pull-request: `fix(macros): use gobuildflags macro
in %gobuild` that you are following:
``
> Sure, Let's figure that out and make it happen soon though. Frankly, I want
> these macros to make more sense...
For the record, at the current time, the following spec files
linkdupont commented on the pull-request: `fix(macros): use gobuildflags macro
in %gobuild` that you are following:
``
I think this helps to normalize the macros by removing redundancy. I'd like to
figure out the LDFLAGS use too though. It looks like the macro is assuming
LDFLAGS to mean Go com
ngompa merged a pull-request against the project: `go-rpm-macros` that you are
following.
Merged pull-request:
``
fix(macros): use gobuildflags macro in %gobuild
``
https://pagure.io/go-rpm-macros/pull-request/35
___
golang mailing list -- golang@lis
ngompa commented on the pull-request: `fix(macros): use gobuildflags macro in
%gobuild` that you are following:
``
:thumbsup:
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/35
___
golang mail
ngompa commented on the pull-request: `fix(macros): use gobuildflags macro in
%gobuild` that you are following:
``
Sure, Let's figure that out and make it happen soon though. Frankly, I want
these macros to make more sense...
``
To reply, visit the link below or just reply to this email
https:/
linkdupont commented on the pull-request: `fix(macros): use gobuildflags macro
in %gobuild` that you are following:
``
I'm dodging that issue and just cleaning up the DRY violation part.
:stuck_out_tongue_closed_eyes: But seriously, I'm not sure where I stand on
that. If we were to change it to
ngompa commented on the pull-request: `fix(macros): use gobuildflags macro in
%gobuild` that you are following:
``
Can you please change this to `GOBUILDTAGS`?
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/35
__
linkdupont opened a new pull-request against the project: `go-rpm-macros` that
you are following:
``
fix(macros): use gobuildflags macro in %gobuild
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/35
_
linkdupont commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that
you are following:
``
Would a value in the environment variable `LDFLAGS` get pulled in by the
`-extldflags '%__global_ldflags %{?__golang_extldflags}'` part? Does
%__global_ldflags or %__global_extldflags resolve t
jcajka commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that you
are following:
``
@linkdupont looking at the macros. ```LDFLAGS``` should have been passed in to
the ```-ldflags='-extldflags "$LDFLAGS"'```. I belive this is a bug in macros
as generic "C" ldflags shouldn't really
I also brought up this topic in #alpine-devel on OFTC; I've attached the
relevant logs, which brought up some interesting points. Perhaps we
should reach out to Ian or Russel from the Go team to weigh in.
--
/Seirdy
2021-10-05 18:03:41 Seirdy Hey, I noticed a certain Fedora issue I had was
12 matches
Mail list logo
