qulogic commented on the pull-request: `Don't skip testdata` that you are
following:
``
Sorry, I've had to revert this change. After applying it, it causes several
bugs:
1. `testdata` that includes invalid Go code can cause `golist` to panic, as it
does so when importing a directory fails.
2.
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Deduplicate CollectProjectDeps
``
https://pagure.io/golist/pull-request/29
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubs
qulogic commented on the pull-request: `Add BUILDTAGS to %gobuildflags` that
you are following:
``
I'm actually confused why `%gobuildflags` exists, because `%gobuild` below
that doesn't use it. In fact, `%gobuild` uses an exact copy of `gobuildflags`
with `BUILDTAGS` _already_ there.
I guess
qulogic added a new comment to an issue you are following:
``
The parts related to Go macros were fixed by #33.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/32
___
golang mailing list -- golang@list
The status of the issue: `Issues with gitea` of project: `go-rpm-macros` has
been updated to: Closed by qulogic.
https://pagure.io/go-rpm-macros/issue/32
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-l
qulogic merged a pull-request against the project: `go-rpm-macros` that you are
following.
Merged pull-request:
``
Use --with-tests when running checks also.
``
https://pagure.io/go-rpm-macros/pull-request/20
___
golang mailing list -- golang@lists.f
On Wed, 28 Jul 2021 at 12:56, Link Dupont wrote:
>
> I noticed that a package I recently submitted (golang-sr-spc-log) has some
> odd Provides: values. I can't figure out how they're getting generated this
> way, or why. From the build log[1]:
>
> Provides: golang(git.sr.ht/~spc/go-log/go-log-0.
On Thu, 24 Jun 2021 at 23:40, Link Dupont wrote:
>
> I'm using go2rpm to generate some RPMs. I noticed that when it detects a
> package that has multiple subcommands, it inserts the following snippet into
> the %build step:
>
> for cmd in cmd/* ; do
> %gobuild -o %{gobuilddir}/bin/$(basename $
qulogic opened a new pull-request against the project: `go-rpm-macros` that you
are following:
``
Fix removal of `.git` suffix.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/33
___
golang mai
qulogic added a new comment to an issue you are following:
``
OK, that apparently only happens for GitHub archive URLs, because @nim decided
this is some kind of 'bug' in GitHub and added `v` for it and Google Code only.
The same process was not added for gitea, presumably because whoever added
qulogic added a new comment to an issue you are following:
``
The `v` prefix depends on if upstream decided to add it, but it's not
necessarily a thing that must happen. @nim decided to default to adding it, but
that can be overridden by setting `tag`. Are you setting `%global tag 0.7.0`?
``
To
qulogic commented on the pull-request: `Remove tildes from goname` that you are
following:
``
The split on line 60 should coalesce repeated separators.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/26
__
qulogic commented on the pull-request: `Remove tildes from goname` that you are
following:
``
Do they trigger the special versioning (even though they're not in the version)?
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/26
___
On Tue, 7 Jul 2020 at 13:05, Fabio Valentini wrote:
>
> Hi everybody,
>
> I have to finally admit that I'll never again be able to play catch-up
> with the ever-changing sprawling go library dependency tree of
> syncthing.
>
> I have switched to using bundled dependencies for syncthing ~years ago
qulogic commented on the pull-request: `Use --with-tests when running checks
also.` that you are following:
``
I'd like to build new `golist` and check that nothing broke soon, so I'd like
to incorporate this in the check as well. If no-one has any objections in the
next week or so, I'm just go
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Fix not listing packages with external tests only
``
https://pagure.io/golist/pull-request/27
___
golang mailing list -- golang@lists.fedorapr
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
Oh, and of course, that's what the recently merged PR#26 does, so there's no
need to modify this PR to do it too (unless you want to rebase.)
``
To reply, visit the link below o
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
This breaks a few things, e.g., [ golang-github-pquerna-otp
](https://copr.fedorainfracloud.org/coprs/qulogic/golist-pr27/build/1217039/),
[ golang-github-opencontainers
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
This would affect approximately 200 packages. Since this determines which test
files to run, it could have some possible consequences for the build, but
probably not the final p
qulogic commented on the pull-request: `Handle tests outside packages
correctly.` that you are following:
``
Everything that was affected was rebuilt in [this
copr](https://copr.fedorainfracloud.org/coprs/qulogic/golist-pr26/), and while
there were several failures, none of them are new (or not
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Handle tests outside packages correctly.
``
https://pagure.io/golist/pull-request/26
___
golang mailing list -- golang@lists.fedoraproject.org
qulogic commented on the pull-request: `Handle tests outside packages
correctly.` that you are following:
``
I actually had a quite outdated list of packages to check and there are many
more that are affected (though still 90% self-references). I set up a copr to
do a test rebuild with this cha
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
Coming back to what this PR is actually about, there may be one more case of
`TestGoFiles` that you haven't changed to add `XTestGoFiles` in
`BuildArtifact`, though I'm not sure
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
> @obudai a lot of Go projects use internal in the package path to mean the
> same thing as the internal keyword. Welcome to the wonderful land of
> underspecified Go behaviour.
qulogic commented on the pull-request: `Handle tests outside packages
correctly.` that you are following:
``
This will add additional _test_ dependencies for:
* bazil.org/fuse
* github.com/Masterminds/semver
* github.com/boltdb/bolt
* github.com/cosmos72/gomacro
* github.com/denisenkom/go-mssqldb
qulogic commented on the pull-request: `Fix not listing packages with external
tests only` that you are following:
``
Do you have an example?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/27
___
gol
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Handle tests outside packages correctly.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/26
___
golang mailin
qulogic opened a new pull-request against the project: `go-rpm-macros` that you
are following:
``
Use --with-tests when running checks also.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/20
_
qulogic added a new comment to an issue you are following:
``
Please fix; this causes indecipherable errors without a space.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/issue/19
___
golang mailing list -
The issue: `LDFlags Macro Typos` of project: `go-rpm-macros` has been assigned
to `nim` by qulogic.
https://pagure.io/go-rpm-macros/issue/19
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fe
Hi,
I'm going over the Go executable packages and have found a few
duplicates. Package maintainers, please discuss the situation and pick
one to move forward with, so we don't have extra work to do between
us.
Maintainers by package:
godotenv athoscr
golang-github-jamesclonk-vultr ecl
Hi,
I'm going through the remaining executables to update to the latest Go
macros, and I see that the dep package contains Obsoletes:godep.
Firstly, there's no version, which is against recommendations.
Secondly, godep is not retired. So what's going on here?
--
Elliott
_
qulogic added a new comment to an issue you are following:
``
OK, this seems like it works:
```
%global gotestflags %{gotestflags} -timeout 30m
```
I guess something like this needs to be mentioned in the templates at least.
``
To reply, visit the link below or just reply to this email
https://p
qulogic reported a new issue against the project: `go-rpm-macros` that you are
following:
``
While `gocheckflags` exists, it gets passed to `go-rpm-integration`, but
ignored after that. For example, if I add:
```
%global gocheckflags -timeout 30m
```
then it appears when `go-rpm-integration` is
qulogic added a new comment to an issue you are following:
``
I've pushed a new `golist` and rebuilt all of the packages here except
`golang-github-klauspost-crc32`, because that one doesn't seem to parse
properly.
``
To reply, visit the link below or just reply to this email
https://pagure.io/
The status of the issue: `Go does not install SFiles not required by the arch`
of project: `go-rpm-macros` has been updated to: Closed by qulogic.
https://pagure.io/go-rpm-macros/issue/17
___
golang mailing list -- golang@lists.fedoraproject.org
To uns
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Always install SFiles whatever the arch
``
https://pagure.io/golist/pull-request/25
___
golang mailing list -- golang@lists.fedoraproject.org
qulogic commented on the pull-request: `Always install SFiles whatever the
arch` that you are following:
``
LGTM.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/25
___
golang mailing list -- golang@l
Hi,
I just tagged golist 0.10.0 a little while back [1]. It fixes various
bugs and RFEs that were needed to finish implementing the Go macros.
I've also opened a Review Request for golang-pagure-golist [2], though
it will need some coordination with the original
/usr/bin/golist-providing package
qulogic added a new comment to an issue you are following:
``
Fixed by #17.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an e
The status of the issue: `runtime panic, nil dereference when running
%gochecks` of project: `golist` has been updated to: Closed as Fixed by qulogic.
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubsc
qulogic commented on the pull-request: `Initialize load.Mod* variables in
ListPackage...` that you are following:
``
Closing since the PR removing usage of all these internals has been merged.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/19
qulogic closed without merging a pull-request against the project: `golist`
that you
are following.
Closed pull-request:
``
Initialize load.Mod* variables in ListPackage...
``
https://pagure.io/golist/pull-request/19
___
golang mailing list -- golang
The status of the issue: `golist needs a switch to process a codebase and its
tests in a single pass` of project: `golist` has been updated to: Closed as
Fixed by qulogic.
https://pagure.io/golist/issue/3
___
golang mailing list -- golang@lists.fedora
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Add option for querying main and test simultaneously.
``
https://pagure.io/golist/pull-request/24
___
golang mailing list -- golang@lists.fedo
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Add option for querying main and test simultaneously.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/24
___
qulogic added a new comment to an issue you are following:
``
Do you have any example packages that trigger this problem?
It is not too difficult to implement, but so far, I haven't been able to find a
package that outputs itself in the `--tests --skip-self` results
``
To reply, visit the link
The status of the issue: `golist processing is arch and tag-specific` of
project: `golist` has been updated to: Closed by qulogic.
https://pagure.io/golist/issue/2
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email t
qulogic added a new comment to an issue you are following:
``
Should have been fixed by #20.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/2
___
golang mailing list -- golang@lists.fedoraproject.org
To unsu
qulogic added a new comment to an issue you are following:
``
Fixed by #22.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an e
The status of the issue: `golist needs to be able to process multiple import
paths in one pass` of project: `golist` has been updated to: Closed by qulogic.
https://pagure.io/golist/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To u
qulogic added a new comment to an issue you are following:
``
I'm going to say this is done well enough for now by #23.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lis
The status of the issue: `golist should permit specifying its output format` of
project: `golist` has been updated to: Closed by qulogic.
https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an
qulogic added a new comment to an issue you are following:
``
> This results in golist panics.
Do you have an example package of this panic?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/14
___
golang mail
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
WIP: Add output templating
``
https://pagure.io/golist/pull-request/23
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscrib
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Allow specifying multiple package paths at a time.
``
https://pagure.io/golist/pull-request/22
___
golang mailing list -- golang@lists.fedorap
qulogic commented on the pull-request: `WIP: Add output templating` that you
are following:
``
On some further thought, there's not really any other information we have
available for dependencies. So I'll just merge this as is, and we can
investigate any additional replacements later.
``
To re
qulogic commented on the pull-request: `WIP: Add output templating` that you
are following:
``
@nim ?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/23
___
golang mailing list -- golang@lists.fedorap
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Add ignored Go files install list
``
https://pagure.io/golist/pull-request/20
___
golang mailing list -- golang@lists.fedoraproject.org
To uns
The issue: `golist needs a switch to process a codebase and its tests in a
single pass` of project: `golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/3
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubs
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
WIP: Add output templating
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/23
___
golang mailing list -- gola
qulogic added a new comment to an issue you are following:
``
True, `cobra` uses quite a bit; `pflag` has no dependencies though, which would
be even better than `urfave/cli`.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/21
qulogic commented on the pull-request: `Add ignored Go files install list` that
you are following:
``
It's a super-ugly hack of a test, but I tried this out on
`golang-github-kr-pty` with a scratch build on koji:
* First add `BuildArch: noarch` to existing package, which
[fails](https://koji.f
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Allow specifying multiple package paths at a time.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/22
___
gol
qulogic added a new comment to an issue you are following:
``
Do you need format string for file lists (or just the provided/installed)?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/13
___
golang mailing l
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Add ignored Go files install list
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/20
___
golang mailing list
qulogic added a new comment to an issue you are following:
``
Is this not all handled when in `BUILD`? Or is something changing as to when
`golist` is called?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/12
_
The issue: `golist processing is arch and tag-specific` of project: `golist`
has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/2
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le
qulogic reported a new issue against the project: `golist` that you are
following:
``
I don't really like the way the command-line arguments are specified right now.
Everything is an optional flag which requires writing out a redundant argument
name. This would be even worse with #4. Also, urfa
The issue: `golist should permit specifying its output format` of project:
`golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to g
qulogic commented on the pull-request: ` Add ignored Go files install list`
that you are following:
``
There are 43 specs without noarch:
```
$ rg --files-without-match 'BuildArch: *noarch' golang* | sort
golang-bazil-fuse.spec
golang-github-aead-chacha20.spec
golang-github-aead-poly1305.spec
gol
The status of the issue: `Crash when processing github.com/kr/pretty 0.1.0` of
project: `golist` has been updated to: Closed by qulogic.
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an e
qulogic commented on the pull-request: ` Add ignored Go files install list`
that you are following:
``
Here's what we get with the new version compared to currently packaged:
```
--- before 2019-04-16 22:43:37.852194764 -0400
+++ after 2019-04-16 22:43:39.333180958 -0400
@@ -99,6 +99,8
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Replace Go internals with go/build
``
https://pagure.io/golist/pull-request/17
___
golang mailing list -- golang@lists.fedoraproject.org
To un
qulogic added a new comment to an issue you are following:
``
Closing as a duplicate of #7.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsub
The status of the issue: `golist should be ported to a current release of
gopkg.in/urfave/cli.v1` of project: `golist` has been updated to: Closed by
qulogic.
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
T
qulogic added a new comment to an issue you are following:
``
Fixed by #16.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an e
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
I'm going to merge this, as those two packages are failing due to the way they
use Go modules, and getting testing working everywhere is more important. They
can just be patched to work right
qulogic merged a pull-request against the project: `golist` that you are
following.
Merged pull-request:
``
Fix compile against latest urfave/cli.
``
https://pagure.io/golist/pull-request/16
___
golang mailing list -- golang@lists.fedoraproject.org
T
qulogic added a new comment to an issue you are following:
``
Might be possible with
[tools/go/packages](https://godoc.org/golang.org/x/tools/go/packages), but I've
read that it's much much slower since it tries to do a full module download.
This might be mitigated by setting up a GOPROXY.
``
qulogic reported a new issue against the project: `go-rpm-macros` that you are
following:
``
In the old version of
[golang-github-pkg-errors](https://src.fedoraproject.org/rpms/golang-github-pkg-errors/blob/f28/f/golang-github-pkg-errors.spec),
there was a typo, and `glide.yaml` was listed twic
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
So for tests, I searched the specs for all that define`goipath` and cloned all
of them (note this is _not_ all Go packages.) Then ran `golist` as packaged and
`golist` from this PR and compare
The issue: `golist needs to be able to process multiple import paths in one
pass` of project: `golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/4
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe
qulogic added a new comment to an issue you are following:
``
I think most of the code is already written to handle this; it just needs to
fix the CLI flags to work correctly.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/4
_
qulogic commented on the pull-request: `Replace Go internals with go/build`
that you are following:
``
As a note, the original code ran a resolve on the test imports, but not the
regular imports. I tried adding a resolve on the regular imports as well, but
it doesn't help. I also tried setting
qulogic added a new comment to an issue you are following:
``
Aren't Go tests in files that end with `_test.go`? Since
`terminal_check_notappengine.go` is not one of those, it shouldn't be output
with `--tests`. It _is_ output in the normal (no `--tests`) results.
``
To reply, visit the link be
The issue: `runtime panic, nil dereference when running %gochecks` of project:
`golist` has been assigned to `qulogic` by qulogic.
https://pagure.io/golist/issue/7
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email t
qulogic added a new comment to an issue you are following:
``
This looks the same as #7, no?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/8
___
golang mailing list -- golang@lists.fedoraproject.org
To unsu
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Replace Go internals with go/build
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/17
___
golang mailing list
qulogic added a new comment to an issue you are following:
``
What I'm saying is that golist does _not_ think it's a test file, and I'm
confused why you think it should be.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/9
qulogic added a new comment to an issue you are following:
``
The backtraces point to line 1888 here:
```go
1886 func ImportPaths(args []string) []*search.Match {
1887 if ModInit(); cfg.ModulesEnabled {
1888>return ModImportPaths(args)
1889 }
1890 return sea
qulogic added a new comment to an issue you are following:
``
Well, the null pointer is here:
```
/builddir/build/BUILD/symbols-extractor-9f4330a0f4437ca61ba92f9f30e34424c6742ad6/_build/src/github.com/gofed/symbols-extractor/pkg/util/internal/load/pkg.go:1888
+0x5f fp=0xc000123038 sp=0xc0001
qulogic added a new comment to an issue you are following:
``
Is this still a problem?
```
$ golist --imported --package-path cloud.google.com/go --skip-self | rg go-cmp
github.com/google/go-cmp/cmp
$ golist --imported --package-path cloud.google.com/go --skip-self --tests | rg
go-cmp
github.com
qulogic added a new comment to an issue you are following:
``
This package also fails `go build` with the same message, so I'm not sure we
can really blame `golist`. It seems to be an outdated and broken-on-latest-Go
package.
``
To reply, visit the link below or just reply to this email
https:/
The issue: `golist should be ported to a current release of
gopkg.in/urfave/cli.v1` of project: `golist` has been assigned to `qulogic` by
qulogic.
https://pagure.io/golist/issue/1
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscri
qulogic added a new comment to an issue you are following:
``
Based on [further debugging](https://pagure.io/golist/issue/7#comment-551104),
this appears related to Go modules. As such, an alternate workaround is to set
`GO111MODULES=off` before calling `golist`. Of course, you need to be sure y
qulogic opened a new pull-request against the project: `golist` that you are
following:
``
Fix compile against latest urfave/cli.
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/16
___
golang mailing
qulogic added a new comment to an issue you are following:
``
Should I push a fix directly (I think I can at least) or open a PR?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/1
___
golang mailing list -- g
qulogic added a new comment to an issue you are following:
``
A workaround I've found that appears to work is:
```rpm
%check
builddir="$PWD/_build"
cd ..
%gochecks -b "$builddir"
```
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
___
qulogic added a new comment to an issue you are following:
``
So is this or is this not a problem? Are tests actually being run or are they
being ignored just like this panic?
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/7
_
1 - 100 of 104 matches
Mail list logo
