Re: [go-nuts] comment.Printer.DocLinkURL isn't being called

2023-07-09 Thread will....@gmail.com
The documentation for comment.Parser.LookupSym is unclear. When would you ever not return true? Looking at Parser more, it isn't clear how you'd implement comment.Parser.LookupPackage in a general way. Has that been done somewhere? I don't see a way to disable links to declarations entirely, so

Re: [go-nuts] comment.Printer.DocLinkURL isn't being called

2023-07-09 Thread will....@gmail.com
Thanks, that was it! On Sunday, July 9, 2023 at 5:10:08 PM UTC-7 Sean Liao wrote: > your parsing setup is missing the lookup to identify which things are > actually linkable symbols > > https://go.dev/play/p/sDtGA_JJZdz > > - sean > > On Sun, Jul 9, 2023, 23:45 will@gmail.com wrote: > >> I'

Re: [go-nuts] comment.Printer.DocLinkURL isn't being called

2023-07-09 Thread 'Sean Liao' via golang-nuts
your parsing setup is missing the lookup to identify which things are actually linkable symbols https://go.dev/play/p/sDtGA_JJZdz - sean On Sun, Jul 9, 2023, 23:45 will@gmail.com wrote: > I'm trying to print the Markdown for package documentation using the new > go/doc/comment package. It

[go-nuts] comment.Printer.DocLinkURL isn't being called

2023-07-09 Thread will....@gmail.com
I'm trying to print the Markdown for package documentation using the new go/doc/comment package. It seems like I have everything set up correctly to customize the doc link URLs, but the comment.Printer.DocLinkURL callback isn't being called: https://go.dev/play/p/7irKc6dTRRw The comment.Printe

Re: [go-nuts] [RFC] Yet another proposal for Go2 error handling

2023-07-09 Thread Shulhan
Hi Mike, On Thu, 29 Jun 2023 22:04:01 -0700 (PDT) Mike Schinkel wrote: > There are many aspects of this proposal that I really like, and a few > that I think need to be reconsidered. > > In general I like that it: > >1. Does not try to handle errors *above *where the errors > occurred, whi