[go-nuts] Re: gofmt: one line if statement

2018-01-07 Thread Jeff Goldberg
Yes, but ... First the "yes" part. I find myself writing one line if statements, and then finding myself annoyed at gofmt. When I write a one line if statement, there is a presentational reason for it. But But such formatting would have to be an all or nothing thing if we wanted consistency

[go-nuts] Re: Surprise About How Method Receivers Work

2017-12-17 Thread Jeff Goldberg
On Sunday, December 17, 2017 at 2:32:24 PM UTC-6, jlfo...@berkeley.edu wrote: > > Here's something that someone new to Go might run up against. I know I did. > > Me, too! The trivial program below, derived from "The Go Programming Language" > book, shows two methods that differ only in the way

Re: [go-nuts] base32 DecodeLen() miscalculation when no padding

2017-12-13 Thread Jeff Goldberg
On Wednesday, December 13, 2017 at 5:06:01 AM UTC-6, Caleb Spare wrote: > > And in fact, Tv has already done that. You want > https://github.com/tv42/zbase32. > Yep. That solves my immediate needs. (For what it is worth, I'm playing with different ways of displaying public key fingerprints in th

Re: [go-nuts] base32 DecodeLen() miscalculation when no padding

2017-12-13 Thread Jeff Goldberg
On Wednesday, December 13, 2017 at 5:02:40 AM UTC-6, rog wrote: > > > Looking at > http://philzimmermann.com/docs/human-oriented-base-32-encoding.txt, > it seems that zbase32 allows the encoder and decoder to agree on the > number of bits transmitted, so if you're encoding 5 bits or less, you >

Re: [go-nuts] base32 DecodeLen() miscalculation when no padding

2017-12-12 Thread Jeff Goldberg
non-standard base32 works as an encoder should. Anyway, now that I've done more testing and have had this conversation, I'm confident enough that this is a bug that I will file a bug for it. Cheers, -j On Tuesday, December 12, 2017 at 5:13:41 PM UTC-6, Jeff Goldberg wrote: > > > &

[go-nuts] base32 DecodeLen() miscalculation when no padding

2017-12-12 Thread Jeff Goldberg
In encoding/base32 there is, I believe, an off by one error in the calculation of the size of the buffer needed for DecodeLen() when padding is turned off. // DecodedLen returns the maximum length in bytes of the decoded data // corresponding to n bytes of base32-encoded data. func (enc *Enco