Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-05 Thread tchan
Well, as a workaround, I've resorted to using this when I need to do a forward: protected static ServletRequest getUnderlyingRequest ( HttpServletRequest request ) { ServletRequest innerRequest = request; while ( innerRequest instanceof HttpServletRequestWrapper ) {

Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-05 Thread Alen Vrecko
> Hey, thanks for the reply. Hi. You to. I'll learn from this. > I am just using the snapshot build. I don't think there is any difference with regards to servlets. > From my understanding, if I am using the dispatcher from > ServletRequest, forwards and includes will be relative to the servle

Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-04 Thread tchan
Hey, thanks for the reply. > I gave it a quick go (trunk build) and it to works with jsp out of the > box but it is not perfect(calling include works but calling forward > crashes). I am just using the snapshot build. > You're doing req.getRequestDispatcher( "/WEB-INF/jsp/test.jsp"). I > could

Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-04 Thread Alen Vrecko
I gave it a quick go (trunk build) and it to works with jsp out of the box but it is not perfect(calling include works but calling forward crashes). IIRC There are 2 different ways of getting the RequestDispatcher o) From ServletContext in that case you specify the whole path context.getRequestD

Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-03 Thread Dhanji R. Prasanna
Yea you're right that that is basically the problem. I'll look into this when I have some time later in the month. Any other volunteers? Dhanji. On Mon, May 4, 2009 at 2:45 AM, tchan wrote: > > All right, I took a stab at it and managed to find the problem but I > don't understand it well enough

Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-03 Thread tchan
All right, I took a stab at it and managed to find the problem but I don't understand it well enough to fix it. In Tomcat, the forward to the referenced jsp will eventually be serviced by the Jasper jsp servlet. When the target jsp is defined in web.xml, it can just grab its path from that servl

Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-03 Thread tchan
I don`t mind taking a stab at ii if you can point me in the right direction. I tried debugging through Tomcat`s pipeline but that was too much for me (and I really couldn`t see a difference between the web.xml and GuiceFilter scenarios). On May 3, 12:25 am, "Dhanji R. Prasanna" wrote: > yea thi

Re: Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-02 Thread Dhanji R. Prasanna
yea this is a known problem, I just have not had any time to address it =( If you would like to contribute a patch we would be thrilled! Otherwise I hope to get to this problem soon. Dhanji. On Sun, May 3, 2009 at 1:56 PM, tchan wrote: > > Hi; > > I'm playing around with the guice-20090205 snap

Guice 2 SNAPSHOT: migrating from web.xml to ServletModule/GuiceFilter

2009-05-02 Thread tchan
Hi; I'm playing around with the guice-20090205 snapshot build and am having problems getting jsps to work when using the GuiceFilter approach to map servlet requests. I have a servlet that forwards to a jsp like this: req.getRequestDispatcher( "/WEB-INF/jsp/test.jsp" ).forward( req, res ); If