Reviewers: jat,
Description:
Include the property name in the error message when a single-valued
property does not have exactly one value
Please review this at http://gwt-code-reviews.appspot.com/1348801/show
Affected files:
M
ping
http://gwt-code-reviews.appspot.com/1329803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
webAppCreator generates a pom.xml? When did that start happening?
On Tue, Feb 8, 2011 at 9:28 AM, David Chandler drfibona...@google.comwrote:
Just this in the POM. These are required to use RequestFactory, but not
required otherwise, so we should probably note that in the POM, too.
LGTM
http://gwt-code-reviews.appspot.com/1329803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/02/08 18:36:31, rjrjr wrote:
webAppCreator generates a pom.xml? When did that start happening?
Somewhere before GWT 2.1 for Google I/O 2010. Added at revision r8234:
http://code.google.com/p/google-web-toolkit/source/detail?spec=svn9690r=8234
Neato.
Don't you need to make the same changes to samples/expenses/pom.xml?
On Tue, Feb 8, 2011 at 10:55 AM, rchan...@google.com wrote:
On 2011/02/08 18:36:31, rjrjr wrote:
webAppCreator generates a pom.xml? When did that start happening?
Somewhere before GWT 2.1 for Google I/O 2010.
Reviewers: jlabanca,
Description:
Relaxing the requirement that users specify a loading indicator image
resource. If the image resource is null, the table will not create a
default loading indicator.
Please review this at http://gwt-code-reviews.appspot.com/1349801/show
Affected files:
M
El 8 de febrero de 2011 14:01, Ray Ryan rj...@google.com escribió:
Don't you need to make the same changes to samples/expenses/pom.xml?
Yes. The pom.xml currently generated by webAppCreator is rather broken.
therefore I will try removing the spam from samples/expenses first and then
try to fix
committed as r9689
http://gwt-code-reviews.appspot.com/1340803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9691
Author: rj...@google.com
Date: Tue Feb 8 11:03:03 2011
Log: Bump samples/expenses/pom.xml version number
Review at http://gwt-code-reviews.appspot.com/1329803
Review by: drfibona...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9691
Modified:
Revision: 9692
Author: gwt.mirror...@gmail.com
Date: Tue Feb 8 11:17:30 2011
Log: Relaxing the requirement that users specify a loading indicator image
resource. If the image resource is null, the table will not create a
default loading indicator.
Review at
Revision: 9695
Author: mrruss...@google.com
Date: Tue Feb 8 12:19:46 2011
Log: tag for the 2.2.0 GA Version
http://code.google.com/p/google-web-toolkit/source/detail?r=9695
Added:
/tags/2.2.0
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9696
Author: unn...@google.com
Date: Tue Feb 8 09:31:49 2011
Log: Get rid of document.write option since it can break in some edge cases
and isn't
actually necessary. I believe that I originally thought it was needed
because I
was appending to the body rather than the head and
lgtm
http://gwt-code-reviews.appspot.com/1338806/diff/1/2
File user/src/com/google/gwt/dom/client/Document.java (right):
http://gwt-code-reviews.appspot.com/1338806/diff/1/2#newcode51
user/src/com/google/gwt/dom/client/Document.java:51: private static
native Document nativeGet() /*-{
I this
http://gwt-code-reviews.appspot.com/1338806/diff/1/2
File user/src/com/google/gwt/dom/client/Document.java (right):
http://gwt-code-reviews.appspot.com/1338806/diff/1/2#newcode51
user/src/com/google/gwt/dom/client/Document.java:51: private static
native Document nativeGet() /*-{
On 2011/02/08
http://gwt-code-reviews.appspot.com/1338806/diff/1/2
File user/src/com/google/gwt/dom/client/Document.java (right):
http://gwt-code-reviews.appspot.com/1338806/diff/1/2#newcode51
user/src/com/google/gwt/dom/client/Document.java:51: private static
native Document nativeGet() /*-{
Oh right, it's
Reviewers: cromwellian, zundel,
Message:
With this change, JSNI methods parsed during CompilationState's build do
not share a jsProgram or common scope. This allows CompilationUnits to
be individually serialized.
Please review this at http://gwt-code-reviews.appspot.com/1350801/show
LGTM
http://gwt-code-reviews.appspot.com/1347801/diff/1/10
File user/src/com/google/gwt/autobean/shared/AutoBeanVisitor.java
(right):
http://gwt-code-reviews.appspot.com/1347801/diff/1/10#newcode66
user/src/com/google/gwt/autobean/shared/AutoBeanVisitor.java:66: *
information than a simple
Revision: 9698
Author: cromwell...@google.com
Date: Tue Feb 8 11:49:32 2011
Log: Fixes checkstyle error
http://code.google.com/p/google-web-toolkit/source/detail?r=9698
Modified:
/trunk/dev/core/src/com/google/gwt/dev/js/JsStringInterner.java
===
---
For some value of now.
One change requested, and one question to John Labanca.
http://gwt-code-reviews.appspot.com/1295806/diff/1/9
File user/src/com/google/gwt/user/client/ui/HTMLPanel.java (right):
http://gwt-code-reviews.appspot.com/1295806/diff/1/9#newcode189
It's not so much about missing features (although it will be nice to be
allowed to use and emulate features that were added to the language more
than four years ago). It's more about being in step with the rest of
Google's code base. Having to keep an eye out for 1.6'ism creeping in has
been a
Reviewers: scottb,
Description:
Recompute whether an interface is dual-implemented by JSO and Java types
after each compiler optimization pass. Modify CastNormalizer to use
whether or not something is effectively JSO (an interface which is
ONLY implemented by a JSO but has not been
Revision: 9699
Author: asku...@google.com
Date: Tue Feb 8 13:32:24 2011
Log: Missing 's' for '%s' specifier in log message.
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9699
Modified:
/trunk/user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
Reviewers: rchandia,
Description:
Fix TestUtil.PathImpl to correctly test for non matching
RegExp groups.
getGroup returns null or depending on the browser.
[JSR 303 TCK Result] 93 of 257 (36.19%) Pass with 33 Failures and 14
Errors.
Please review this at
Reviewers: zundel,
Description:
Follow on to svn r8671, which made the GWT code style allow whitespace
in front of dots, to allow builder-style formatting. Tweaks the
auto-formatter to put elements after the first one on their own line,
so that foo.bar().baz().bang(); becomes
foo.bar()
.baz()
Eric, this look good?
http://gwt-code-reviews.appspot.com/1346803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9700
Author: gwt.mirror...@gmail.com
Date: Tue Feb 8 17:02:32 2011
Log: Sorting the gwt-format.xml rules for easy diffing in subequent
changes. There is no actual change here.
http://code.google.com/p/google-web-toolkit/source/detail?r=9700
Modified:
http://gwt-code-reviews.appspot.com/1351801/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java (right):
http://gwt-code-reviews.appspot.com/1351801/diff/1/2#newcode585
dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java:585:
(getSingleJsoImpl(refType) != null
Revision: 9701
Author: fre...@google.com
Date: Tue Feb 8 16:15:58 2011
Log: Provide mechanism to suppress warning dialog when runtime and compile
time user.agent propert values disagree, i.e. via
set-property name=user.agent.runtimeWarning value=false/
Fixes issues: 5861
Review at
Revision: 9702
Author: fre...@google.com
Date: Tue Feb 8 16:59:56 2011
Log: Include the property name in the error message when a single-valued
property does not have exactly one value
Review at http://gwt-code-reviews.appspot.com/1348801
Review by: j...@google.com
101 - 130 of 130 matches
Mail list logo
