On 2012/09/18 02:40:01, skybrian wrote:
LGTM
I vaguely remember the exact same problem in xpcom a while ago
http://gwt-code-reviews.appspot.com/1835803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
http://gwt-code-reviews.appspot.com/1816803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: skybrian,
Description:
Firefox 14 DevMode Plugin
Please review this at http://gwt-code-reviews.appspot.com/1792803/
Affected files:
M plugins/xpcom/JavaObject.cpp
M plugins/xpcom/JavaObject.h
M plugins/xpcom/Makefile
A plugins/xpcom/VisualStudio/ff130-xpcom.vcproj
A
http://gwt-code-reviews.appspot.com/1792803/diff/1/plugins/xpcom/JavaObject.h
File plugins/xpcom/JavaObject.h (right):
http://gwt-code-reviews.appspot.com/1792803/diff/1/plugins/xpcom/JavaObject.h#newcode55
plugins/xpcom/JavaObject.h:55: static void finalize(JSFreeOp* fop,
JSObject* obj);
On
LGTM
http://gwt-code-reviews.appspot.com/1767803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: skybrian,
Description:
Fix unicode escaping in JSON Util.
Please review this at http://gwt-code-reviews.appspot.com/1754803/
Affected files:
M user/src/com/google/gwt/core/client/JsonUtils.java
Index: user/src/com/google/gwt/core/client/JsonUtils.java
http://gwt-code-reviews.appspot.com/1741804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Make RfValidator Java7 Compat.
Please review this at http://gwt-code-reviews.appspot.com/1743803/
Affected files:
M user/src/com/google/web/bindery/requestfactory/apt/RfValidator.java
M
Hey Thomas, Rajeev told me that you are understood lots of the request
factory code.
I am trying to fix the follow error in Java7:
junit.framework.AssertionFailedError: Did not see expected errors:
[warning: Supported source version 'RELEASE_6' from annotation processor
http://gwt-code-reviews.appspot.com/1731806/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
File dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
(right):
Reviewers: rdayal,
Description:
Missed file for -XfragmentCount
Please review this at http://gwt-code-reviews.appspot.com/1743804/
Affected files:
M dev/core/src/com/google/gwt/dev/PrecompileTaskArgProcessor.java
Index: dev/core/src/com/google/gwt/dev/PrecompileTaskArgProcessor.java
Reviewers: skybrian,
Description:
Make CoverageTest less dependent on execution order.
Please review this at http://gwt-code-reviews.appspot.com/1741804/
Affected files:
M user/test/com/google/gwt/dev/jjs/test/CoverageTest.java
Index:
Reviewers: skybrian,
Description:
Removes execution order dependency on EnumOrdinalizerTest
Please review this at http://gwt-code-reviews.appspot.com/1731806/
Affected files:
M dev/core/test/com/google/gwt/dev/jjs/impl/EnumOrdinalizerTest.java
--
Reviewers: cromwellian,
Description:
Introduce -XfragmentCount to replace -XfragmentMerge
Please review this at http://gwt-code-reviews.appspot.com/1739804/
Affected files:
M dev/core/src/com/google/gwt/dev/PrecompileTaskOptionsImpl.java
M
@@
// The _throwsUnsupportedOperationException version of this test will
// verify that the method is not supported.
if (isRemoveSupported) {
+
+ // TODO(acleung): Post JDK7, map.put(null) will actually throw a NPE.
+ // Lets disable this for now. Once we no longer test on JDK6, we can
+ // add this back
http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp
File plugins/xpcom/JSRunner.cpp (right):
http://gwt-code-reviews.appspot.com/1738803/diff/1/plugins/xpcom/JSRunner.cpp#newcode121
plugins/xpcom/JSRunner.cpp:121: Debug::log(Debug::Error) Get
JSPrincial at
Reviewers: rdayal,
Description:
Make CookieTest JDK7 compat by avoid execution order dependencies
between test methods.
Please review this at http://gwt-code-reviews.appspot.com/1728805/
Affected files:
M user/test/com/google/gwt/user/client/CookieTest.java
Index:
http://gwt-code-reviews.appspot.com/1726803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Description:
Firefox 13 DevMode Plugin
Please review this at http://gwt-code-reviews.appspot.com/1738803/
Affected files:
M plugins/xpcom/FFSessionHandler.cpp
M plugins/xpcom/JSRunner.cpp
M plugins/xpcom/JavaObject.cpp
M plugins/xpcom/JavaObject.h
M
.java
===
--- dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter2.java (revision
10971)
+++ dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter2.java (working
copy)
@@ -88,7 +88,6 @@
* TODO(acleung): Figure out how
Updated.
http://gwt-code-reviews.appspot.com/1711804/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
http://gwt-code-reviews.appspot.com/1711804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian,
Description:
Filter no longer referenced symbols from symbol table.
Please review this at http://gwt-code-reviews.appspot.com/1711804/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
A
Reviewers: conroy,
Description:
FF12 Plugin
Please review this at http://gwt-code-reviews.appspot.com/1701803/
Affected files:
M plugins/xpcom/Makefile
A plugins/xpcom/VisualStudio/ff120-xpcom.vcproj
M plugins/xpcom/install-template.rdf
M
LGTM
http://gwt-code-reviews.appspot.com/1647803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/04/05 21:33:43, acleung wrote:
On 2011/11/14 08:51:56, tbroyer wrote:
On 2011/07/28 21:11:18, unnurg wrote:
LGTM
It's been more than 3 months and still not committed :-(
bobv has left Google for other quests and adventures.
I'll pick up this change and submit it.
http://gwt
On 2011/11/14 08:51:56, tbroyer wrote:
On 2011/07/28 21:11:18, unnurg wrote:
LGTM
It's been more than 3 months and still not committed :-(
bobv has left Google for other quests and adventures.
I'll pick up this change and submit it.
http://gwt-code-reviews.appspot.com/1502806/
--
http://gwt-code-reviews.appspot.com/1679803/diff/1/user/src/com/google/gwt/resources/css/ast/CssFontFace.java
File user/src/com/google/gwt/resources/css/ast/CssFontFace.java (right):
On 2012/04/05 21:42:05, acleung wrote:
Copied from: http://gwt-code-reviews.appspot.com/1502806/
http://gwt-code-reviews.appspot.com/1679803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rdayal,
Description:
Add support for @font-face CSS declarations.
Please review this at http://gwt-code-reviews.appspot.com/1679803/
Affected files:
M user/src/com/google/gwt/resources/css/CssGenerationVisitor.java
M user/src/com/google/gwt/resources/css/GenerateCssAst.java
A
Reviewers: cromwellian,
Description:
Inflate and Deflate on writeObject
Please review this at http://gwt-code-reviews.appspot.com/1672803/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
M dev/core/src/com/google/gwt/dev/util/DiskCache.java
Index:
http://gwt-code-reviews.appspot.com/1667803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Description:
FF11 Devmode Plugin
Please review this at http://gwt-code-reviews.appspot.com/1667803/
Affected files:
M plugins/xpcom/Makefile
A plugins/xpcom/VisualStudio/ff110-xpcom.vcproj
M plugins/xpcom/install-template.rdf
M
LGTM
http://gwt-code-reviews.appspot.com/1599803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1652803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian,
Description:
Permutation Specific SymbolMap
Please review this at http://gwt-code-reviews.appspot.com/1652803/
Affected files:
M dev/core/src/com/google/gwt/core/linker/SymbolMapsLinker.java
Index: dev/core/src/com/google/gwt/core/linker/SymbolMapsLinker.java
On 2012/03/02 22:46:28, rdayal wrote:
On Fri Mar 02 13:09:00 GMT-500 2012, mailto:cromwell...@google.com
wrote:
On 2012/03/02 10:39:39, acleung wrote:
Are you missing the module files (.gwt.xml) that define this new
property?
http://gwt-code-reviews.appspot.com/1652803/%3Chttps
http://gwt-code-reviews.appspot.com/1645803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
updated.
http://gwt-code-reviews.appspot.com/1645803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Description:
Fix Firefox 3.6 devmode plugin infinite install loop.
Please review this at http://gwt-code-reviews.appspot.com/1642803/
Affected files:
M plugins/xpcom/install-template.rdf
Index: plugins/xpcom/install-template.rdf
On 2012/02/13 21:21:54, conroy wrote:
FYI
can you provide some more context on the problem and why this fixes
it?
Note taht FF has poor handling of switching down between incompatible
versions
in the same install location. So, if you point 3.6 at a user directory
that had
7 installed,
On 2012/02/13 22:41:01, conroy wrote:
On 2012/02/13 22:24:15, acleung wrote:
On 2012/02/13 21:21:54, conroy wrote:
FYI
can you provide some more context on the problem and why this
fixes it?
Note taht FF has poor handling of switching down between
incompatible
versions
Reviewers: johnlenz,
Description:
Fix Closure backend with JsNumericEntry
Please review this at http://gwt-code-reviews.appspot.com/1640803/
Affected files:
M dev/core/src/com/google/gwt/dev/js/ClosureJsAstTranslator.java
Index:
Reviewers: conroy,
Description:
Updates Missing Plugin Page
Please review this at http://gwt-code-reviews.appspot.com/1641803/
Affected files:
M plugins/MissingPlugin/war/MissingPlugin.html
Index: plugins/MissingPlugin/war/MissingPlugin.html
Reviewers: cromwellian,
Description:
Make splitpoint.xml CodeSplitter2 aware.
Please review this at http://gwt-code-reviews.appspot.com/1639803/
Affected files:
M dev/core/src/com/google/gwt/core/ext/soyc/impl/SplitPointRecorder.java
M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java
Reviewers: conroy,
Description:
Clean rebuild of the plugin.
(I noticed some of the binary has DebugLevel was still set to spam)
Please review this at http://gwt-code-reviews.appspot.com/1638803/
Affected files:
M plugins/xpcom/Makefile
Index: plugins/xpcom/Makefile
http://gwt-code-reviews.appspot.com/1631803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Description:
Firefox 10 DevMode Plugin
Please review this at http://gwt-code-reviews.appspot.com/1634803/
Affected files:
M plugins/xpcom/ExternalWrapper.cpp
M plugins/xpcom/Makefile
M plugins/xpcom/SessionData.h
A plugins/xpcom/VisualStudio/ff100-xpcom.vcproj
M
Sorry for the delay. I was on vacation the day after I sent this out.
http://gwt-code-reviews.appspot.com/1620803/diff/1/plugins/common/HostChannel.cpp
File plugins/common/HostChannel.cpp (right):
http://gwt-code-reviews.appspot.com/1620803/diff/1/plugins/common/HostChannel.cpp#newcode322
http://gwt-code-reviews.appspot.com/1620803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Description:
Firefox 9 DevMode Plugin
Please review this at http://gwt-code-reviews.appspot.com/1620803/
Affected files:
M plugins/common/HostChannel.cpp
M plugins/common/HostChannel.h
M plugins/common/InvokeMessage.cpp
M plugins/common/InvokeMessage.h
M
http://gwt-code-reviews.appspot.com/1589803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/12/02 21:26:45, acleung wrote:
PTAL.
Thanks.
-Alan
http://gwt-code-reviews.appspot.com/1589803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1593803/diff/1/dev/core/test/com/google/gwt/dev/js/JsStaticEvalTest.java
File dev/core/test/com/google/gwt/dev/js/JsStaticEvalTest.java (right):
Reviewers: conroy,
Description:
FF8 Devmode Plugin
Please review this at http://gwt-code-reviews.appspot.com/1589803/
Affected files:
M plugins/xpcom/ExternalWrapper.cpp
M plugins/xpcom/Makefile
A plugins/xpcom/VisualStudio/ff80-xpcom.vcproj
M plugins/xpcom/install-template.rdf
M
Reviewers: cromwellian,
Description:
Introduce a temp AST node intended to hold the fragment number
Please review this at http://gwt-code-reviews.appspot.com/1590803/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
M
Reviewers: cromwellian,
Description:
New Code Splitter
Please review this at http://gwt-code-reviews.appspot.com/1580803/
Affected files:
A dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter2.java
A dev/core/test/com/google/gwt/dev/jjs/impl/CodeSplitter2Test.java
--
http://gwt-code-reviews.appspot.com/1560803/diff/3001/plugins/xpcom/Makefile
File plugins/xpcom/Makefile (right):
http://gwt-code-reviews.appspot.com/1560803/diff/3001/plugins/xpcom/Makefile#newcode125
plugins/xpcom/Makefile:125: ifeq ($(BROWSER),ff70)
On 2011/10/04 23:11:19, conroy wrote:
so,
Reviewers: conroy,
Description:
Firefox 7 DevMode Plugin
Please review this at http://gwt-code-reviews.appspot.com/1560803/
Affected files:
M plugins/xpcom/Makefile
M plugins/xpcom/VisualStudio/FirefoxPlugins.sln
A plugins/xpcom/VisualStudio/ff70-xpcom.vcproj
M
http://gwt-code-reviews.appspot.com/1560803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Enable FF6 Plugin in MissingPlugin Page.
Please review this at http://gwt-code-reviews.appspot.com/1551803/
Affected files:
M plugins/MissingPlugin/war/MissingPlugin.html
Index: plugins/MissingPlugin/war/MissingPlugin.html
61 matches
Mail list logo
