[gwt-contrib] Re: Add ProxySerializer API to provide EntityProxy persistence primitives. (issue1148801)

2010-11-24 Thread cramsdale
LGTM http://gwt-code-reviews.appspot.com/1148801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Removing the Expenses sample from bikeshed now that it has been converted to a sample. I'm leav... (issue791801)

2010-08-23 Thread cramsdale
LGTM http://gwt-code-reviews.appspot.com/791801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

2010-08-19 Thread cramsdale
Reviewers: rice_google.comm, Description: Updated common.ant.xml to copy pom.xml (if found) to build/out Added .place-holder to ensure war dir existence Please review this at http://gwt-code-reviews.appspot.com/782801/show Affected files: M samples/build.xml M samples/common.ant.xml A

[gwt-contrib] Re: Updated common.ant.xml to copy pom.xml (if found) to build/out (issue782801)

2010-08-19 Thread cramsdale
http://gwt-code-reviews.appspot.com/782801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Tightened up datanucleus paths to include only **/domain/*.class (issue776802)

2010-08-19 Thread cramsdale
Reviewers: Ray Ryan, Description: Tightened up datanucleus paths to include only **/domain/*.class Merged over a few remaining changes from bikeshed Please review this at http://gwt-code-reviews.appspot.com/776802/show Affected files: M samples/expenses/pom.xml M

[gwt-contrib] Re: Adding missing package descriptions to javadoc

2010-03-11 Thread cramsdale
LGTM http://gwt-code-reviews.appspot.com/176801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RichTextArea.BasicFormatter deprecated comment in JavaDocs

2010-01-11 Thread cramsdale
LGTM http://gwt-code-reviews.appspot.com/130801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update IE plugin installer to install for the current user only (for real)

2009-11-19 Thread cramsdale
I assume that uninstallation is handled by the .msi that installed the components in the first place, and as such this patch does not need to account for uninstallation of the RC plugin. Correct? http://gwt-code-reviews.appspot.com/106804 --

[gwt-contrib] Re: Dynatable still refers to hosted mode instead of development mode

2009-11-18 Thread cramsdale
LGTM http://gwt-code-reviews.appspot.com/103809 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Update IE plugin installer to install for the current user only

2009-11-17 Thread cramsdale
Meta installer omits the build number. You'll need to update the patch number to be safe. http://gwt-code-reviews.appspot.com/104805 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors