Reviewers: cromwellian, Nick Chalko,
Description:
Updated Validation sample. Now uses the correct RPC mechanism. Also
removed unnessecary super source for the server constraint.
Please review this at http://gwt-code-reviews.appspot.com/1800807/
Affected files:
M
Reviewers: Nick Chalko, cromwellian,
Description:
Removed EXPERIMENTAL flag from GWT validation. Cleaned up all JavaDoc
comments to reflect this change.
Please review this at http://gwt-code-reviews.appspot.com/1811803/
Affected files:
M
Reviewers: Nick Chalko, cromwellian,
Description:
Prevent code for constraints which are not in the groups listed in the
@GwtValidation annotation from being generated. This greatly simplifies
the creation of server-side-only constraints which will not compile
using GWT - just put those
Reviewers: Nick Chalko, cromwellian,
Description:
Marked validation provider/validation provider resolver/xml
configuration tests as unsupported.
[JSR 303 TCK Result] 191 of 192 (99.48%) Pass with 0 Failures and 0
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1800804/
Reviewers: Nick Chalko,
Description:
Added support for Traversable Resolver.
[JSR 303 TCK Result] 193 of 204 (94.61%) Pass with 10 Failures and 0
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1795806/
Affected files:
M
Reviewers: Nick Chalko, cromwellian,
Description:
Changed package structure with the intention of keeping the client
package clean of all classes which the user should not see
(implementation-specific).
[JSR 303 TCK Result] 191 of 204 (93.63%) Pass with 12 Failures and 0
Errors.
Please review
Reviewers: Nick Chalko, cromwellian,
Description:
Implemented a subset of the bootstrap configuration which allows for
Validator customization.
[JSR 303 TCK Result] 191 of 204 (93.63%) Pass with 12 Failures and 0
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1807803/
Reviewers: Nick Chalko,
Description:
Implemented assertArrayEquals method for client side JUnit testing.
[JSR 303 TCK Result] 189 of 205 (92.20%) Pass with 13 Failures and 2
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1805803/
Affected files:
M
Reviewers: Nick Chalko,
Description:
Fixed Default group sequence redefinition. The JSR-303 does not specify
exactly how to handle cases where a bean does not redefine the Default
group but its parent class does, yet there are test cases for this
scenario.
[JSR 303 TCK Result] 188 of 205
http://gwt-code-reviews.appspot.com/1798803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/Group.java
File user/src/com/google/gwt/validation/client/Group.java (right):
http://gwt-code-reviews.appspot.com/1798803/diff/1/user/src/com/google/gwt/validation/client/Group.java#newcode26
http://gwt-code-reviews.appspot.com/1798803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Nick Chalko,
Description:
Added support for group sequences - including Default group overrides.
Code needs some refactoring- will do in next commit.
[JSR 303 TCK Result] 187 of 205 (91.22%) Pass with 15 Failures and 2
Errors.
Please review this at
http://gwt-code-reviews.appspot.com/1789803/diff/1/user/src/org/hibernate/validator/metadata/ConstraintOrigin.java
File user/src/org/hibernate/validator/metadata/ConstraintOrigin.java
(right):
http://gwt-code-reviews.appspot.com/1789803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Nick Chalko,
Description:
Added support for ConstraintFinder.
Requires passing the group inheritance map from the top-level validator
into the individual bean/property descriptors. Perhaps there could be
some way to pass this at construction time?
[JSR 303 TCK Result] 174 of 205
http://gwt-code-reviews.appspot.com/1777803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1777803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1777803/diff/1/user/src/com/google/gwt/validation/client/impl/AbstractGwtSpecificValidator.java
File
user/src/com/google/gwt/validation/client/impl/AbstractGwtSpecificValidator.java
(right):
Reviewers: Nick Chalko,
Description:
Explicitly added all the groups to @GwtValidation for TCK suite for
upcoming breaking change.
[JSR 303 TCK Result] 168 of 205 (81.95%) Pass with 29 Failures and 7
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1782803/
Affected files:
Reviewers: Nick Chalko,
Description:
Added support for validation group inheritance.
This now requires @GwtValidation annotations to specify which groups
will be used in validation rather than allowing the empty set to mean
ALL; the empty set now means ONLY DEFAULT. The TCK test suite factories
Reviewers: Nick Chalko,
Description:
Refactoring to set empty groups to include Default earlier.
[JSR 303 TCK Result] 168 of 205 (81.95%) Pass with 29 Failures and 7
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1761805/
Affected files:
M
http://gwt-code-reviews.appspot.com/1761805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Nick Chalko,
Description:
Allows creation of validators annotated by interfaces with abstract
methods. All methods in an interface are abstract anyway, but this
explicit denotation was throwing off the invocation via reflection.
Fixes issues: 6284
[JSR 303 TCK Result] 167 of 205
Reviewers: Nick Chalko,
Description:
Constraint Violations generated with custom paths now work correctly.
[JSR 303 TCK Result] 161 of 205 (78.54%) Pass with 36 Failures and 7
Errors.
Fixes issues: 6907
Please review this at http://gwt-code-reviews.appspot.com/1763803/
Affected files:
M
Reviewers: Nick Chalko,
Description:
Reorganized the GWT test suite structure for the nested constraint
composition tests to fix errors.
Previously the nested constraint composition tests would not work in a
production (compiled JS) environment when included in a GWT test suite
that also
http://gwt-code-reviews.appspot.com/1744804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1746803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Some generated code for the bean we have been looking at:
public class _BuildingValidatorImpl extends
com.google.gwt.validation.client.impl.AbstractGwtSpecificValidatororg.hibernate.jsr303.tck.tests.constraints.application.Building
implements _BuildingValidator {
private static final
Reviewers: Nick Chalko,
Description:
Added additional TCK tests to the appropriate GWT test suites. Tests
failing in certain conditions marked with @Failing.
[JSR 303 TCK Result] 160 of 205 (78.05%) Pass with 37 Failures and 7
Errors.
Review by: ncha...@google.com
Please review this at
Reviewers: Nick Chalko,
Description:
Added 5 missing tests to the TCK test suite coverage.
Please review this at http://gwt-code-reviews.appspot.com/1744804/
Affected files:
M
user/test/com/google/gwt/validation/tck/ConstraintCompositionGwtSuite.java
M
http://gwt-code-reviews.appspot.com/1746803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1746803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/06/21 00:00:43, David Idol wrote:
Patches 3 and 4 are identical. I was attempting to update the issue's
description and accidentally submitted the code again.
http://gwt-code-reviews.appspot.com/1746803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1746803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
This methodology calls setElementType based on the value of useField:
- it works (all tests pass)
- only because the .equals method checks to be sure it isn't pointing
to the same instance - so when it is added the first time with FIELD and
then later with METHOD it doesn't get added
Reviewers: Nick Chalko,
Description:
Added ElementType to ConstraintDescriptors and ConstraintViolations.
Used ElementType to handle edge cases of duplicate ConstraintViolations
being generated.
Fixes issues: 5798
Please review this at http://gwt-code-reviews.appspot.com/1746803/
Affected
Reviewers: Nick Chalko,
Description:
Changed comments within code generator to better mirror the actual
output code.
Review by: ncha...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1729804/
Affected files:
M
Reviewers: Nick Chalko,
Description:
Fixed testValidIsNotHonoredValidateProperty by allowing shallow property
validation (not honoring the @Valid annotation) in the bean-specific
validateProperty methods.
Fixes issues: 5804
Please review this at http://gwt-code-reviews.appspot.com/1727806/
39 matches
Mail list logo
