Re: Add Rich Text area callback after element has loaded and is editable

2009-09-15 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/64811 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Google Web Toolkit" group. To post to this group, send email to google-web-toolkit@googlegroups.com To unsubscribe from

Re: Add Rich Text area callback after element has loaded and is editable

2009-09-15 Thread jlabanca
Couple minor things. http://gwt-code-reviews.appspot.com/64811/diff/17/1010 File user/src/com/google/gwt/user/client/ui/RichTextArea.java (right): http://gwt-code-reviews.appspot.com/64811/diff/17/1010#newcode40 Line 40: * CSS Style Rules .gwt-RichTextArea { } Can you change this to a dl list

Re: Add Rich Text area callback after element has loaded and is editable

2009-09-15 Thread jlabanca
http://gwt-code-reviews.appspot.com/64811/diff/1004/11 File user/src/com/google/gwt/user/client/ui/impl/RichTextAreaImpl.java (right): http://gwt-code-reviews.appspot.com/64811/diff/1004/11#newcode92 Line 92: richTextWidget.fireEvent(new LoadEvent() { We usually don't synthesis native events unl

Re: Add Rich Text area callback after element has loaded and is editable

2009-09-11 Thread jlabanca
The impl changes look good, but I think we should use an event handler instead of onElementInitilized so users don't have to override RichTextArea. http://gwt-code-reviews.appspot.com/64811/diff/1/5 File user/src/com/google/gwt/user/client/ui/RichTextArea.java (right): http://gwt-code-reviews.a