[gwt-contrib] Re: SuggestBox causes native events to fire twice (3533) (issue1785803)

If you can finish it up that would be great. I haven't really had time to figure out the new system. With the old system I could generate patch files from any of the many computers that I work on, email it to myself and submit the patch from anywhere. I can't really do that anymore... On

[gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)

On 2012/09/16 02:36:41, Patrick Tucker wrote: Anybody? http://gwt-code-reviews.appspot.com/1832803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups Google Web Toolkit Contributors group. To

[gwt-contrib] Re: Issue 7890 : ListBox: allow CSS class for options (issue1897803)

On 2013/03/19 15:40:06, tbroyer wrote: I agree, returning the OptionElement seems like a better idea. http://gwt-code-reviews.appspot.com/1897803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups

[gwt-contrib] Re: ValueListBox should implement Focusable, Issue 6483 (issue1884803)

On 2013/01/17 21:35:09, goktug wrote: It won't be hard to make one. If someone will push it through I don't mind creating the patch. Can someone get this committed? http://gwt-code-reviews.appspot.com/1884803/ -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You

[gwt-contrib] ValueListBox should implement Focusable, Issue 6483 (issue1884803)

Reviewers: , Description: http://code.google.com/p/google-web-toolkit/issues/detail?id=6483 Please review this at http://gwt-code-reviews.appspot.com/1884803/ Affected files: user/src/com/google/gwt/user/client/ui/ValueListBox.java Index:

[gwt-contrib] SplitLayoutPanel needs to set the associated Splitter to hidden when a child is set to hidden (issue1880804)

Reviewers: kurka.daniel, Description: http://code.google.com/p/google-web-toolkit/issues/detail?id=7715 Please review this at http://gwt-code-reviews.appspot.com/1880804/ Affected files: user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java Index:

[gwt-contrib] Re: Fixes for issues 4366, 4447. (issue132806)

Just a java doc issue. http://gwt-code-reviews.appspot.com/132806/diff/1/user/src/com/google/gwt/dom/client/Style.java File user/src/com/google/gwt/dom/client/Style.java (right): http://gwt-code-reviews.appspot.com/132806/diff/1/user/src/com/google/gwt/dom/client/Style.java#newcode703

[gwt-contrib] Re: Extracted constant strings to the constructor, that allow translation to be provided from the ou... (issue1739803)

A little late, but I hasn't run across this problem until yesterday... http://gwt-code-reviews.appspot.com/1739803/diff/14001/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right):

[gwt-contrib] Re: The JavaDoc for Style.clearFloat() is wrong (issue1762803)

I didn't realize it wasn't cc'd to the group... http://gwt-code-reviews.appspot.com/1762803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] PushButton constructors that take ImageResource (4714) (issue1833803)

Reviewers: , Description: Add constructors that allow the user to skip wrapping an ImageResource in an Image. Sometimes it is more convenient to not have to worry about the Image. http://code.google.com/p/google-web-toolkit/issues/detail?id=4714 Please review this at

[gwt-contrib] ValueListBox should implement HasEnabled (6112) (issue1832803)

Reviewers: , Description: ValueListBox should implement HasEnabled, functionality can easily be delegated to the internal ListBox. http://code.google.com/p/google-web-toolkit/issues/detail?id=6112 Please review this at http://gwt-code-reviews.appspot.com/1832803/ Affected files:

[gwt-contrib] Re: SuggestBox causes native events to fire twice (issue1785803)

On 2012/07/19 20:48:12, tbroyer wrote: Can this patch be committed? https://gwt-code-reviews.appspot.com/1785803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)

On 2012/08/08 22:25:10, skybrian wrote: Any reason clear() can't be moved into SelectionModel and not make SingleSelectionModel implement SetSelectionModel? It seems misleading to make SingleSelectionModel extend SetSelectionModel when it only deals with one element.

[gwt-contrib] Re: Fix incorrect SuggestBox documentation related to adding selection handlers. Fixes issue 4575. (issue1801803)

On 2012/07/31 18:48:57, skybrian wrote: LGTM http://gwt-code-reviews.appspot.com/1801803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: fixes ISSUE 7479 (typo in javadoc) (issue1770803)

On 2012/07/30 19:10:14, rdayal wrote: Since this is just a doc fix can you also fix 4575? http://code.google.com/p/google-web-toolkit/issues/detail?id=4575 http://gwt-code-reviews.appspot.com/1770803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] SuggestBox causes native events to fire twice (issue1785803)

Reviewers: , Description: Issue 3533 Please review this at http://gwt-code-reviews.appspot.com/1785803/ Affected files: user/src/com/google/gwt/user/client/ui/SuggestBox.java Index: user/src/com/google/gwt/user/client/ui/SuggestBox.java

[gwt-contrib] Re: SuggestBox causes native events to fire twice (issue1785803)

On 2012/07/19 20:27:56, Patrick Tucker wrote: http://code.google.com/p/google-web-toolkit/issues/detail?id=3533 http://gwt-code-reviews.appspot.com/1785803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] The comment for Style.clearFloat() is wrong (issue1762803)

Reviewers: , Description: Issue 7457 Please review this at http://gwt-code-reviews.appspot.com/1762803/ Affected files: user/src/com/google/gwt/dom/client/Style.java Index: user/src/com/google/gwt/dom/client/Style.java === ---

[gwt-contrib] Re: Extracted constant strings to the constructor, that allow translation to be provided from the ou... (issue1739803)

http://gwt-code-reviews.appspot.com/1739803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java File user/src/com/google/gwt/user/cellview/client/CellTreeNodeView.java (right):

[gwt-contrib] Add max-height and max-width support to Style (issue1736804)

Reviewers: , Description: Style does not currently support the max-height and max-width CSS 2 properties. Please review this at http://gwt-code-reviews.appspot.com/1736804/ Affected files: user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java

[gwt-contrib] Reposting (Issue 1723803: Complete text-* support for Style) (issue1736803)

Reviewers: rchandia, Please review this at http://gwt-code-reviews.appspot.com/1736803/ Affected files: user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java user/src/com/google/gwt/dom/builder/shared/HtmlStylesBuilder.java

[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1698803)

On 2012/06/05 17:58:08, rchandia wrote: On 2012/06/05 01:09:12, Patrick Tucker wrote: Is this acceptable, or should I modify the patch? I think the change in this patch is good. What is needed is for this patch to also modify tools/api-checker/config/gwt24_25userApi.conf to allow the API

[gwt-contrib] Re: MeniItem should use ScheduledCommand instead of Command (issue1698803)

Correct, this is a breaking change but should not cause much commotion. Currently, Command is an extension of ScheduledCommand, that should eventually be deprecated and removed from the API. It was changed to this in order to ease the transition from DeferredCommand to Scheduler. The interface

[gwt-contrib] Re: Complete text-* support for Style (issue1723803)

I just realized that 'text-overflow' is a CSS3 property. How do you guys feel about adding CSS3 properties to Style? If its ok, I will add 'text-justify' and 'text-shadow' which are the only other widely supported text properties. http://gwt-code-reviews.appspot.com/1723803/ --

[gwt-contrib] VerticalSplitPanel should not use DeferredCommand (issue1725803)

Reviewers: , Description: VerticalSplitPanel is using DeferredCommand which is deprecated. Resubmitting 1693803 Please review this at http://gwt-code-reviews.appspot.com/1725803/ Affected files: user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java Index:

[gwt-contrib] Complete text-* support for Style (issue1723803)

Reviewers: , Description: Added text-overflow, text-indent, and text-transform Also added a convenience function to GwtSafeStylesUtilsTest: assertEquals(String, SafeStyles) Please review this at http://gwt-code-reviews.appspot.com/1723803/ Affected files:

[gwt-contrib] Add HasEnabled to FileUpload. (issue1614808)

LGTM http://gwt-code-reviews.appspot.com/1614808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add clear support to Style (issue1720803)

Reviewers: , Description: Style does not have a getter, setter or clear function for the 'clear' CSS property. Please review this at http://gwt-code-reviews.appspot.com/1720803/ Affected files: user/src/com/google/gwt/dom/client/Style.java

[gwt-contrib] Add white-space support to Style (issue1714803)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1714803/ Affected files: user/src/com/google/gwt/dom/client/Style.java user/src/com/google/gwt/user/client/ui/Anchor.java user/src/com/google/gwt/user/client/ui/CheckBox.java --

[gwt-contrib] Re: Add white-space support to Style (issue1714803)

http://gwt-code-reviews.appspot.com/1714803/diff/1/user/src/com/google/gwt/user/client/ui/Anchor.java File user/src/com/google/gwt/user/client/ui/Anchor.java (right): http://gwt-code-reviews.appspot.com/1714803/diff/1/user/src/com/google/gwt/user/client/ui/Anchor.java#newcode87

[gwt-contrib] Re: Resubmission for internal commit. Thanks tbroyer! (issue1711803)

http://gwt-code-reviews.appspot.com/1711803/diff/9001/dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java File dev/core/src/com/google/gwt/dev/jjs/impl/DeadCodeElimination.java (right):

[gwt-contrib] Allow enablement and titles to be set from DatePicker (issue1702804)

Reviewers: google-web-toolkit-contributors_googlegroups.com, Description: http://code.google.com/p/google-web-toolkit/issues/detail?id=7367 http://code.google.com/p/google-web-toolkit/issues/detail?id=7360 Please review this at http://gwt-code-reviews.appspot.com/1702804/ Affected files:

[gwt-contrib] SimplePager modificaitons (issue1692803)

Reviewers: , Description: DEFAULT_FAST_FORWARD_ROWS should be final Add constructor SimplePager(TextLocation, boolean, boolean) Please review this at http://gwt-code-reviews.appspot.com/1692803/ Affected files: user/src/com/google/gwt/user/cellview/client/SimplePager.java Index:

[gwt-contrib] VerticalSplitPanel should use ScheduledCommand instead of Command (issue1693803)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1693803/ Affected files: user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java Index: user/src/com/google/gwt/user/client/ui/VerticalSplitPanel.java

[gwt-contrib] HorizontalSplitPanel should use ScheduledCommand instead of Command (issue1694803)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1694803/ Affected files: user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java Index: user/src/com/google/gwt/user/client/ui/HorizontalSplitPanel.java

[gwt-contrib] SplitLayoutPanel should use ScheduledCommand instead of Command (issue1695803)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1695803/ Affected files: user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java Index: user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java

[gwt-contrib] DateBox should use ScheduledCommand instead of Command (issue1695804)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1695804/ Affected files: user/src/com/google/gwt/user/datepicker/client/DateBox.java Index: user/src/com/google/gwt/user/datepicker/client/DateBox.java

[gwt-contrib] JsonpRequest should use ScheduledCommand instead of Command (issue1694804)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1694804/ Affected files: user/src/com/google/gwt/jsonp/client/JsonpRequest.java Index: user/src/com/google/gwt/jsonp/client/JsonpRequest.java === ---

[gwt-contrib] PopupImplMozilla should use ScheduledCommand instead of Command (issue1696803)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1696803/ Affected files: user/src/com/google/gwt/user/client/ui/impl/PopupImplMozilla.java Index: user/src/com/google/gwt/user/client/ui/impl/PopupImplMozilla.java

[gwt-contrib] RenderablePanel should use ScheduledCommand instead of Command (issue1693804)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1693804/ Affected files: user/src/com/google/gwt/user/client/ui/RenderablePanel.java Index: user/src/com/google/gwt/user/client/ui/RenderablePanel.java

[gwt-contrib] MeniItem should use ScheduledCommand instead of Command (issue1698803)

Reviewers: , Description: Changes in MenuItem require changes in MenuBar and SuggestBox. Please review this at http://gwt-code-reviews.appspot.com/1698803/ Affected files: user/src/com/google/gwt/user/client/ui/MenuBar.java user/src/com/google/gwt/user/client/ui/MenuItem.java

[gwt-contrib] CaptionPanel should use ScheduledCommand instead of Command (issue1690803)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1690803/ Affected files: user/src/com/google/gwt/user/client/ui/CaptionPanel.java Index: user/src/com/google/gwt/user/client/ui/CaptionPanel.java === ---

[gwt-contrib] FormPanel should use ScheduledCommand instead of Command (issue1691803)

Reviewers: , Please review this at http://gwt-code-reviews.appspot.com/1691803/ Affected files: user/src/com/google/gwt/user/client/ui/FormPanel.java Index: user/src/com/google/gwt/user/client/ui/FormPanel.java === ---

[gwt-contrib] Add text-align support to Style (issue1686803)

Reviewers: , Description: http://code.google.com/p/google-web-toolkit/issues/detail?id=6493 Please review this at http://gwt-code-reviews.appspot.com/1686803/ Affected files: user/src/com/google/gwt/dom/client/Style.java Index: user/src/com/google/gwt/dom/client/Style.java

[gwt-contrib] DockLayoutPanel.getWidgetSize(Widget) (issue1687803)

Reviewers: , Description: http://code.google.com/p/google-web-toolkit/issues/detail?id=4613 Please review this at http://gwt-code-reviews.appspot.com/1687803/ Affected files: user/src/com/google/gwt/user/client/ui/DockLayoutPanel.java Index:

[gwt-contrib] Incorrect doc for Style.Position (issue1688803)

Reviewers: , Description: The java doc for the Position enum in Style states that the enum is for the display CSS property when it is actually for the position CSS property. Please review this at http://gwt-code-reviews.appspot.com/1688803/ Affected files:

[gwt-contrib] SplitLayoutPanel should use ScheduledCommand instead of Command (issue1689803)

Reviewers: , Description: The class uses ScheduledCommand in all but 1 place, the import can be removed all together if we construct a ScheduledCommand instead of a Command. Please review this at http://gwt-code-reviews.appspot.com/1689803/ Affected files:

[gwt-contrib] Re: Fixed issue 1394 : Need a new getSplitter() method in SplitPanel (issue1398801)

Do you guys have any objections to setting hidden child widget's size to 0 instead of actually changing their display value? Changing the display value causes Firefox, Chrome and what not to destroy child flash objects... and setting its size to 0 seems to have caused 0 problems for me.

[gwt-contrib] Re: Fixed issue 1394 : Need a new getSplitter() method in SplitPanel (issue1398801)

That would be great! It looks like this fix is also going to take care of issue 5264 via the addition of setWidgetHidden(Widget, boolean). Thanks! http://gwt-code-reviews.appspot.com/1398801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors