Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-02-08 Thread Thomas Broyer
On Tuesday, February 8, 2011 2:51:23 AM UTC+1, Y2i wrote: Thomas (and GWT team) If a view is a singleton (as recommended by MVP), are there potential memory leaks with this approach? Yes, but not related to the Editor framework (only to the fact that a singleton will still exist until

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-02-08 Thread Thomas Broyer
On Tuesday, February 8, 2011 3:18:46 AM UTC+1, Colin Alworth wrote: The only concerns I had were for events that might have already been wired up, say from something implementing HasEditorDelegate, but it should be the implementing class's responsibility to clear out old registrations...

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-02-08 Thread Y2i
Thomas, thanks for the detailed response! I was actually re-using drivers for several edits (similar to Colin I guess), will be switching to your (and Expenses') approach. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-02-07 Thread Y2i
Thomas (and GWT team) If a view is a singleton (as recommended by MVP), are there potential memory leaks with this approach? When a second driver is created and initialized, does the first driver become completely detached from the view/editor? Thanks for the advice. -- You received this

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-02-07 Thread Colin Alworth
For my part, I've not been creating a 'createEditorDriver()' method, but instead 'getEditorDriver()'. This way, there is no concern about binding and traversing the tree more than once. Am I in error with this approach? Each time my presenters get a ref to the driver and have finished loading

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-01-27 Thread Patrice De Saint Steban
Thanks Thomas, I haven't think to this solution, and it's a good solution. On Thu, Jan 27, 2011 at 00:11, Thomas Broyer t.bro...@gmail.com wrote: FWIW, we simply copied what they did in the Expenses sample, and we're happy with it: add a createEditorDriver in your view (that the presenter

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-01-27 Thread nacho
Great -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to google-web-toolkit+unsubscr...@googlegroups.com. For more

BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-01-20 Thread Patrice De Saint Steban
Hello, I want to have the best practice to know how to use the Editor Framework with MVP. Where place all the code. For exemple if I want to do a build an Activity with edit an object, I will create first an Activity EditObjectActivity and a EditObjectView interface with the

Re: BestPractice : Use of the Editor Framework with MVP (Place, Activity) and RequestFactory

2011-01-20 Thread Bálint Kriván
Hi! I was facing the same issue. I've found out this, but I'm open to any suggestion: I've put Driver in the Activity, because View should be responsible only for display (but using editor.flush() method is responsible for Model changes -- it should go to the Presenter layer (Activity in this