Re: JsArray methods deficiency

2009-04-27 Thread Thomas Broyer
On 26 avr, 23:53, Vitali Lovich wrote: > Unfortunately, I have already implemented my own version.  This means that > regardless of which is better (or even if they are identical) I must > criticize & reject yours out of hand. > > On a serious note, why do some of your methods have a GWT.isScri

Re: JsArray methods deficiency

2009-04-26 Thread Thomas Broyer
On 26 avr, 20:23, Vitali Lovich wrote: > Just as an aside, I have a set of patches to implement all the missing > native methods from JsArray (splice, etc).  I'll be opening a defect soon. I already did so 8 months ago: http://code.google.com/p/google-web-toolkit/issues/detail?id=2793 ...but

Re: JsArray methods deficiency

2009-04-26 Thread Vitali Lovich
Unfortunately, I have already implemented my own version. This means that regardless of which is better (or even if they are identical) I must criticize & reject yours out of hand. On a serious note, why do some of your methods have a GWT.isScript check? On Sun, Apr 26, 2009 at 5:43 PM, Thomas B

Re: JsArray methods deficiency

2009-04-26 Thread Thomas Broyer
On 26 avr, 04:53, Blessed Geek wrote: > I am wondering why GWT team has overlooked the need for > - get (String key) method This is a JS Object method, not directly related to arrays (and it's bad practice to store key/value pairs in an Array, you should use an Object instead; though, eventual

Re: JsArray methods deficiency

2009-04-26 Thread Vitali Lovich
Just as an aside, I have a set of patches to implement all the missing native methods from JsArray (splice, etc). I'll be opening a defect soon. On Sun, Apr 26, 2009 at 2:33 AM, Adam T wrote: > > Best thing to do is either: > > a) raise a defect and then this gets tracked, and if indeed the wor

Re: JsArray methods deficiency

2009-04-25 Thread Adam T
Best thing to do is either: a) raise a defect and then this gets tracked, and if indeed the world is suffering due to this, then they can star it to get higher visibility. b) submit a patch through the contributor list (afterall, GWT is open source) - are you 100% sure this is cross-browser compa

JsArray methods deficiency

2009-04-25 Thread Blessed Geek
I am wondering why GWT team has overlooked the need for - get (String key) method - toArray() method Therefore, I had to extend JsArray public class JsObjectArray extends JsArray { protected JsObjectArray(){} final public native String get(String key) /*-{return this[key]; }-*/;