LGTM
http://gwt-code-reviews.appspot.com/1356802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
ping
On 2011/02/09 15:22:04, rchandia wrote:
Removed the hibernate validation implementation as it is not
necessary.
I guess we need to decide between adding stuff to gwt-user.jar with
this
approach or to add the respective jars to each gwtc invocation as in:
ping
On 2011/02/09 15:23:23, rchandia wrote:
On 2011/02/08 19:02:29, rjrjr wrote:
Don't you need to make the same changes to samples/expenses/pom.xml?
Done.
http://gwt-code-reviews.appspot.com/1342803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1342803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm
http://gwt-code-reviews.appspot.com/1342803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1359801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
updated patch
http://gwt-code-reviews.appspot.com/1359801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java
(right):
http://gwt-code-reviews.appspot.com/1359801/diff/1/3#newcode48
dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java:48: if
(declaringClass
I'm confused by your last comment, I guess we need to decide..., which
points back to this issue. Who are you asking to choose between what?
On Fri, Feb 11, 2011 at 8:38 AM, rchan...@google.com wrote:
ping
On 2011/02/09 15:22:04, rchandia wrote:
Removed the hibernate validation
Oh, sorry. I guess I pasted confusingly similar links. So far there are two
approaches to fix Issue 5950:
http://gwt-code-reviews.appspot.com/1323803/show (This one)
http://gwt-code-reviews.appspot.com/1342803/show (The other one)
El 11 de febrero de 2011 12:48, Ray Ryan rj...@google.com
On Fri, Feb 11, 2011 at 10:11 AM, Rodrigo Chandia rchan...@google.comwrote:
Oh, sorry. I guess I pasted confusingly similar links. So far there are two
approaches to fix Issue 5950:
http://gwt-code-reviews.appspot.com/1323803/show (This one)
http://gwt-code-reviews.appspot.com/1342803/show
Reviewers: zundel,
Description:
Eclipse autoformatter update: allow assignments to wrap.
Please review this at http://gwt-code-reviews.appspot.com/1354803/show
Affected files:
M eclipse/settings/code-style/gwt-format.xml
Index: eclipse/settings/code-style/gwt-format.xml
It's like eating potato chips, once you start...
http://gwt-code-reviews.appspot.com/1354803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
El 11 de febrero de 2011 13:19, Nick Chalko ncha...@google.com escribió:
On Fri, Feb 11, 2011 at 10:11 AM, Rodrigo Chandia rchan...@google.comwrote:
Oh, sorry. I guess I pasted confusingly similar links. So far there are
two approaches to fix Issue 5950:
Revision: 9728
Author: gwt.mirror...@gmail.com
Date: Fri Feb 11 07:11:32 2011
Log: Updated speed tracer logging for JDTCompiler, CompilationStateBuilder
Review at http://gwt-code-reviews.appspot.com/1356802
Review by: zun...@google.com
Well, I personally like the way it looks:
this.myPackage = StringInterner.get().intern(
(myPackage.length() == 0) ? : (myPackage + '.'));
becomes:
this.myPackage =
StringInterner.get().intern(
(myPackage.length() == 0) ? : (myPackage + '.'));
This is going to cause a
On 2011/02/11 18:51:18, zundel wrote:
Well, I personally like the way it looks:
this.myPackage = StringInterner.get().intern(
(myPackage.length() == 0) ? : (myPackage + '.'));
becomes:
this.myPackage =
StringInterner.get().intern(
(myPackage.length() == 0) ?
On Fri, Feb 11, 2011 at 1:51 PM, zun...@google.com wrote:
Well, I personally like the way it looks:
this.myPackage = StringInterner.get().intern(
(myPackage.length() == 0) ? : (myPackage + '.'));
becomes:
this.myPackage =
StringInterner.get().intern(
LGTM + nits
http://gwt-code-reviews.appspot.com/1359801/diff/6002/7
File dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java
(right):
http://gwt-code-reviews.appspot.com/1359801/diff/6002/7#newcode39
dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java:39: *
visible in
http://gwt-code-reviews.appspot.com/1359801/diff/6002/7
File dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java
(right):
http://gwt-code-reviews.appspot.com/1359801/diff/6002/7#newcode39
dev/core/src/com/google/gwt/dev/javac/MethodParamCollector.java:39: *
visible in the
I can't find a way to weight the line breaks, to make it resort to
assignments last. I'll drop this one.
On Fri, Feb 11, 2011 at 10:57 AM, John Tamplin j...@google.com wrote:
On Fri, Feb 11, 2011 at 1:51 PM, zun...@google.com wrote:
Well, I personally like the way it looks:
this.myPackage
Revision: 9729
Author: gwt.mirror...@gmail.com
Date: Fri Feb 11 11:37:16 2011
Log: Added antcount jars
http://code.google.com/p/google-web-toolkit/source/detail?r=9729
Added:
/tools/antlib/COPYING.antcount
/tools/antlib/antcount-1.2-src.jar
/tools/antlib/antcount-1.2.jar
If Dave has already LGTM'd one of the approaches as maven friendly, is there
any reason not to go with that? What are the trade offs?
On Fri, Feb 11, 2011 at 10:39 AM, Rodrigo Chandia rchan...@google.comwrote:
El 11 de febrero de 2011 13:19, Nick Chalko ncha...@google.com escribió:
On Fri,
LGTM
http://gwt-code-reviews.appspot.com/1359801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
El 11 de febrero de 2011 14:48, Ray Ryan rj...@google.com escribió:
If Dave has already LGTM'd one of the approaches as maven friendly, is
there any reason not to go with that? What are the trade offs?
No LGTM from David Chandler yet.
But aside from that, from what David and I have
LGTM
http://gwt-code-reviews.appspot.com/1342803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I was *convinced* those two numbers were the same. Dueling 803's!
I agree, the de-bundled one smells a lot better. LGTM'd it.
On Fri, Feb 11, 2011 at 12:11 PM, Rodrigo Chandia rchan...@google.comwrote:
El 11 de febrero de 2011 14:48, Ray Ryan rj...@google.com escribió:
If Dave has already
Revision: 9730
Author: zun...@google.com
Date: Fri Feb 11 10:29:39 2011
Log: Proactively gathers more method names for MethodArgNamesLookup.
Before this
logic was only interested in abstract methods. Now it collects any non
local methods
with at least one argument.
Review at
Revision: 9731
Author: rchan...@google.com
Date: Fri Feb 11 11:12:39 2011
Log: Added validation jars to all calls to GWTC to provide classes rquired
by
client-side validation. Fixes Issue 5950.
Review at http://gwt-code-reviews.appspot.com/1342803
101 - 128 of 128 matches
Mail list logo
