-- Forwarded message --
Date: Thu, Sep 11, 2008 at 12:52 PM
Subject: Re: [gwt-contrib] Re: one-word review for trivial patch in
About.java
To: Google-Web-Toolkit-Contributors@googlegroups.com
Cc: Rajeev Dayal <[EMAIL PROTECTED]>
Ah, so no longer copying ${project.build} in its ent
w00t! Committed as r3652 after some pair prog/cleanup.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Once you are happy with them, I think they'd fit very well into the
incubator, thanks for volunteering! Feel free to send them to me as the
reviewer once you are happy.
FYI: the array class would probably land in the following
package:com.google.gen2.collection.client, as we already have a JsStrin
Thanks Bob, committed as r3651.
Your suggestion could work for dimensioned arrays, but wouldn't work for
array literals. An array literal's constructor function is implicitly
determined to be "Array" and we cannot change its constructor. Modifying
that prototype would mess up all arrays.
It's al
Author: [EMAIL PROTECTED]
Date: Mon Sep 15 15:12:59 2008
New Revision: 3651
Modified:
trunk/dev/core/super/com/google/gwt/dev/jjs/intrinsic/com/google/gwt/lang/Array.java
Log:
Two tweaks to improve Array instantiation performance.
1) For reference-type arrays, we no longer need to initial
Review ping?
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Actually, incubator might be a great place for them (as well as the
submission for issue #1727).
On Mon, Sep 15, 2008 at 5:23 PM, Folke Behrens <[EMAIL PROTECTED]> wrote:
> Hi
>
> With all the conversions to JSOs/overlay types going on I was
> wondering if it makes sense to provide implementions
Hello Miguel,
This resolves issue 171 - which was apparently due to a core GWT issue. It
also adds a few more tests to the DirectionsTest, and updates the Marker
class to properly extract Markers from a list.
M maps/maps/test/com/google/gwt/maps/client/geocode/DirectionsTest.java
M map
Just a ping for you to look at the code/design...
On Thu, Sep 11, 2008 at 11:13 AM, Emily Crutcher <[EMAIL PROTECTED]> wrote:
>
>
>> Anyway, my main point is that someone just looking at the Wiki isn't going
>> to know what it means so there should be additional text describing what
>> those char
Committed as r789.
On Mon, Sep 15, 2008 at 1:07 PM, Miguel Méndez <[EMAIL PROTECTED]> wrote:
> LGTM
>
>
> On Fri, Sep 12, 2008 at 4:56 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
>
>> Hello Miguel,
>>
>> I was perusing the Marker documentation at
>> http://code.google.com/apis/maps and noticed ther
LGTM
On Fri, Sep 12, 2008 at 5:12 PM, Eric Ayers <[EMAIL PROTECTED]> wrote:
> Hello Miguel,
>
> This change addresses issue 46 (add the closeInfoWindow() method to the
> MapWidget class), and also addresses a long standing issue, which is to make
> a 1:1 relationship between the InfoWindow object
It will probably fail to render properly, because my understanding is that
it doesn't support data: urls. If we want to officially support S60, we're
going to have to eventually create a separate user-agent value for it,
because it's a really ancient version of WebKit. Or we could wait for them
to
On Mon, Sep 15, 2008 at 11:19 AM, Joel Webber <[EMAIL PROTECTED]> wrote:
> It will probably fail to render properly, because my understanding is that
> it doesn't support data: urls. If we want to officially support S60, we're
> going to have to eventually create a separate user-agent value for it
On Mon, Sep 15, 2008 at 10:35 AM, Joel Webber <[EMAIL PROTECTED]> wrote:
> This code is also all covered by the tests in ImageTest, which test clipped
> images pretty thoroughly. I also verified them visually on affected
> browsers.
>
Did you test this change on the Nokia S60 browser?
--
John A
On Mon, Sep 15, 2008 at 10:35 AM, Joel Webber <[EMAIL PROTECTED]> wrote:
> The compiler does a fine job inlining the whole mess of strings together
> (the compiled code looks something like (str0 + arg0 + str1)).
>
Cool!
>
> This code is also all covered by the tests in ImageTest, which test cl
The compiler does a fine job inlining the whole mess of strings together
(the compiled code looks something like (str0 + arg0 + str1)).
This code is also all covered by the tests in ImageTest, which test clipped
images pretty thoroughly. I also verified them visually on affected
browsers.
On Mon,
Is the compiler able to factor the entire " wrote:
> Emily,
> I'd like you to have a look at this patch for issue 2884. It gets rid of an
> extra HTTP request in the default clipped-image implementation using a data:
> url (see the issue for details).
>
> Issue: 2884
> Patch by: jgw
> Review by: e
Emily,
I'd like you to have a look at this patch for issue 2884. It gets rid of an
extra HTTP request in the default clipped-image implementation using a data:
url (see the issue for details).
Issue: 2884
Patch by: jgw
Review by: ecc
Affected Files:
M user/src/com/google/gwt/user/ClippedImage
18 matches
Mail list logo
