[gwt-contrib] [google-web-toolkit commit] r3768 - trunk/user/src/com/google/gwt/xml/client/impl

Author: [EMAIL PROTECTED] Date: Wed Oct 15 16:20:02 2008 New Revision: 3768 Modified: trunk/user/src/com/google/gwt/xml/client/impl/XMLParserImplSafari.java Log: Improve robustness of XML parsing error detection on Safari. Patch by: bobv Review by: rdayal Modified: trunk/user/src/com/go

[gwt-contrib] Re: RR : Change Safari XML parse error detection

LGTM. If your document legitimately has a tag contained by a tag, you're really having a bad day. On Wed, Oct 15, 2008 at 6:49 PM, Bob Vawter <[EMAIL PROTECTED]> wrote: > Here's a version that should allow a tag named "parseerror", as long > as it's not contained by a body tag. > > -- > Bob Vawt

[gwt-contrib] [google-web-toolkit commit] r3767 - in releases/1.5/user: src/com/google/gwt/user/client/rpc/impl src/com/google/gwt/user/ser...

Author: [EMAIL PROTECTED] Date: Wed Oct 15 15:21:36 2008 New Revision: 3767 Modified: releases/1.5/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java releases/1.5/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java rel

[gwt-contrib] Re: RR : Change Safari XML parse error detection

It might be worth noting in the XMLParser javadoc that XML documents containing the '' element will not parse correctly. On Wed, Oct 15, 2008 at 5:45 PM, BobV <[EMAIL PROTECTED]> wrote: > This patch simplifies the XML parse error detection to not look for a > specific style applied to the error d

[gwt-contrib] [google-web-toolkit commit] r3766 - releases/1.5/user/test/com/google/gwt/xml/client

Author: [EMAIL PROTECTED] Date: Wed Oct 15 14:42:33 2008 New Revision: 3766 Modified: releases/1.5/user/test/com/google/gwt/xml/client/XMLTest.java Log: Disabling XMLTest.testParse() in the 1.5 branch. It fails on Safari in web mode in the 1.5 branch, but it passes on all other configs.

[gwt-contrib] RR: API change for 1.6, improve default behavior of SuggestBox

This addresses http://code.google.com/p/google-web-toolkit/issues/detail?id=2330 The SuggestBox will no longer select its first item by default. In case there are existing apps that prefer this behavior, a boolean property (selectsFirstItem) is added to turn it back on. rjrjr --~--~-~--~-

[gwt-contrib] [google-web-toolkit commit] r3765 - in releases/1.6/user: src/com/google/gwt/user/client/rpc/core/java/util super/com/google/...

Author: [EMAIL PROTECTED] Date: Wed Oct 15 14:29:44 2008 New Revision: 3765 Added: releases/1.6/user/src/com/google/gwt/user/client/rpc/core/java/util/TreeMap_CustomFieldSerializer.java Modified: releases/1.6/user/super/com/google/gwt/emul/java/util/TreeMap.java releases/1.6/user/

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

Should I incorporate Emily's and Scott's changes and commit this to 1.6? Regards, Amit On Wed, Oct 15, 2008 at 12:24 PM, Bruce Johnson <[EMAIL PROTECTED]> wrote: > Let's not do this in 1.5.3. > > > On Wed, Oct 15, 2008 at 12:11 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > >> If we rename it F

[gwt-contrib] RR : Change Safari XML parse error detection

This patch simplifies the XML parse error detection to not look for a specific style applied to the error document. Diffstat: XMLParserImplSafari.java |61 + 5 - 0 ! 1 file changed, 1 insertion(+), 5 deletions(-) -- Bob Vawter Google Web Toolkit Team --~--~-~--~

[gwt-contrib] Re: Code Review Request - disabled XMLTest.testParse() in the 1.5 branch

committed as r3776 Thanks, John LaBanca [EMAIL PROTECTED] On Wed, Oct 15, 2008 at 5:33 PM, Joel Webber <[EMAIL PROTECTED]> wrote: > LGTM. Commit away. > > > On Wed, Oct 15, 2008 at 4:34 PM, John LaBanca <[EMAIL PROTECTED]> wrote: > >> John - >> >> Please do a code review on this patch that disa

[gwt-contrib] Re: Code Review Request - disabled XMLTest.testParse() in the 1.5 branch

LGTM. Commit away. On Wed, Oct 15, 2008 at 4:34 PM, John LaBanca <[EMAIL PROTECTED]> wrote: > John - > > Please do a code review on this patch that disables XMLTest.testParse(). > It fails on Safari in web mode in the 1.5 branch, but it passes on all other > configs. The files in the xml package

[gwt-contrib] Re: Patch for TreeMap serialization

Commited as r3765 to 1.6 On Wed, Oct 15, 2008 at 2:14 PM, Bruce Johnson <[EMAIL PROTECTED]> wrote: > @All: For context, we're shooting for a 1.5.3 this week, which is focused > on fixing some problems with GWT RPC on Android. It will have a couple of > other previously-agreed-upon bug fixes, too,

[gwt-contrib] Re: data binding framework for GWT

Hi Ray, On Wed, Oct 8, 2008 at 6:24 PM, Ray Cromwell <[EMAIL PROTECTED]> wrote: > Something struck me about the way you are approaching things, that > is, letting the BoundField's return widgets. With the new HasData > stuff being proposed, why not let the programmer create the widget, > and bin

[gwt-contrib] [google-web-toolkit commit] r3764 - in changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs: . ast impl

Author: [EMAIL PROTECTED] Date: Wed Oct 15 13:42:08 2008 New Revision: 3764 Added: changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java (contents, props changed) changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java

[gwt-contrib] Code Review Request - disabled XMLTest.testParse() in the 1.5 branch

John - Please do a code review on this patch that disables XMLTest.testParse(). It fails on Safari in web mode in the 1.5 branch, but it passes on all other configs. The files in the xml package in the 1.5 branch are identical to the files in the trunk. Thanks, John LaBanca [EMAIL PROTECTED] -

[gwt-contrib] Re: [gwt-team] Release Notes for review

Added Scott's changes. Any more nitpicks or is it ready to commit? Can you Thanks, John LaBanca [EMAIL PROTECTED] On Tue, Oct 14, 2008 at 4:37 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Just formatting nitpicks.1) All code needs to use the HTML for code. > 2) Any code that refers to a metho

[gwt-contrib] [google-web-toolkit commit] r3763 - in branches/oophm/user: src/com/google/gwt/user/client/rpc/impl src/com/google/gwt/user/s...

Author: [EMAIL PROTECTED] Date: Wed Oct 15 13:13:48 2008 New Revision: 3763 Modified: branches/oophm/user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java branches/oophm/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java bra

[gwt-contrib] [google-web-toolkit commit] r3762 - releases/1.5/user/test/com/google/gwt/user/client

Author: [EMAIL PROTECTED] Date: Wed Oct 15 13:00:44 2008 New Revision: 3762 Modified: releases/1.5/user/test/com/google/gwt/user/client/WindowTest.java Log: Merging r3682 from trunk. Modified: releases/1.5/user/test/com/google/gwt/user/client/WindowTest.java ===

[gwt-contrib] Re: RR 1.6: Snip a couple of redundant HasText declarations

LGTM! (although your formatting seems to have taken out a bunch of spaces inside comments, probably don't need to commit those...) On Wed, Oct 15, 2008 at 3:42 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > Hey, Alex. > This patch cleans up a couple of spots where we were unnecessarily declaring > ex

[gwt-contrib] RR 1.6: Snip a couple of redundant HasText declarations

Hey, Alex. This patch cleans up a couple of spots where we were unnecessarily declaring extends HasHTML, HasText (silly, since HasHTML itself extends HasText). It's intended for the 1.6 branch. M src/com/google/gwt/user/client/ui/DialogBox.java M src/com/google/gwt/user/client/ui/Anchor.

[gwt-contrib] [google-web-toolkit commit] r3761 - branches/oophm/user/src/com/google/gwt/dom/client

Author: [EMAIL PROTECTED] Date: Wed Oct 15 11:31:32 2008 New Revision: 3761 Modified: branches/oophm/user/src/com/google/gwt/dom/client/Element.java Log: Merge in fix for failing tests from 1.5/trunk. Modified: branches/oophm/user/src/com/google/gwt/dom/client/Element.java ===

[gwt-contrib] Re: Patch for TreeMap serialization

@All: For context, we're shooting for a 1.5.3 this week, which is focused on fixing some problems with GWT RPC on Android. It will have a couple of other previously-agreed-upon bug fixes, too, but this TreeMap patch wasn't one of them. @Amit: Thank you for getting it done quickly, but in the spiri

[gwt-contrib] Re: Patch for TreeMap serialization

> There is just one drawback to this code going in 1_5_3. To get Stob to > generate serializers for the key and value types, based on Lex's suggestion, > I created two private variables that are not being used anywhere. Since my > tests run correctly, either the compiler does not optimize away thes

[gwt-contrib] Re: RR: SOYC Correlation work

On Wed, Oct 15, 2008 at 1:39 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > Cool! LGTU. Committed at r3760. I'm going to follow up to this with a patch to pass in the caller of makeChild() and makeSynthetic() since findCaller() was removed. -- Bob Vawter Google Web Toolkit Team --~--~-~-

[gwt-contrib] Re: releases/1.6 merge from trunk

I think it should go in. It would be fairly annoying to have the build be prevented from completing just because a command-line SVN client is not available. On Wed, Oct 15, 2008 at 11:26 AM, Scott Blum <[EMAIL PROTECTED]> wrote: > Well I'll be. Thanks for pointing that out. c3717 wasn't terribl

[gwt-contrib] Re: RR: SOYC Correlation work

Cool! LGTU. -Lex --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Patch for TreeMap serialization

Thanks Scott. Bruce, should I commit it to 1.5.3 or not? On Wed, Oct 15, 2008 at 12:58 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Amit, this patch looks great. I saw a tiny bit of whitespace cheese in 1 > or 2 files, but it's fine. > > On Wed, Oct 15, 2008 at 12:23 PM, Bruce Johnson <[EMAIL PR

[gwt-contrib] 1.5.3 smoke party in the offing

Hi all, here's a heads up. We're in the process of locking down 1.5.3, affectionately known as the WDYMRPCIBOA[1] release. We hope to quietly put up a jar on the download page tonight or tomorrow morning and ask you all to smoke test it with us. If that goes well, we'll announce it on the front pag

[gwt-contrib] Re: Patch for TreeMap serialization

Amit, this patch looks great. I saw a tiny bit of whitespace cheese in 1 or 2 files, but it's fine. On Wed, Oct 15, 2008 at 12:23 PM, Bruce Johnson <[EMAIL PROTECTED]> wrote: > Let's just make this patch available on the issue and not include this in > 1.5.3. > I dunno, Bruce, I'm in favor of g

[gwt-contrib] RR : Proposed Linker API and XML format for SOYC data

The attached Java file shows a rough sketch of what the CompilationAnalysis API might look like. The basic idea is to map J(s)Nodes, SourceInfos, and Correlations onto a simplified API suitable for building reports from. The inner interfaces would likely be top-level types in a separate package

[gwt-contrib] [google-web-toolkit commit] r3759 - releases/1.5/user/src/com/google/gwt/user/client/rpc/impl

Author: [EMAIL PROTECTED] Date: Wed Oct 15 09:35:51 2008 New Revision: 3759 Modified: releases/1.5/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java Log: Fixes breaking RPCs on Safari 2 (which apparently doesn't support directly calling regex's). Patch by:

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

Let's not do this in 1.5.3. On Wed, Oct 15, 2008 at 12:11 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > If we rename it FastStringMapImpl at the same time that would work. The > rename is useful because people using class-lookup to find gwt utility > classes cannot fail to realize it is an imp

[gwt-contrib] Re: Patch for TreeMap serialization

Let's just make this patch available on the issue and not include this in 1.5.3. On Tue, Oct 14, 2008 at 8:06 PM, Amit Manjhi <[EMAIL PROTECTED]> wrote: > Hi all, > > I have attached a patch for TreeMap Serialization. The patch has been > reviewed by John Tamplin. Most of the code is similar to t

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

If we rename it FastStringMapImpl at the same time that would work. The rename is useful because people using class-lookup to find gwt utility classes cannot fail to realize it is an impl class. Of course, what I really want is a public JsStringMap api, and so consider the fact that we are having

[gwt-contrib] Re: GWT branches\oophm fails with IndexOutOfBoundsException when reloading application

On Wed, Oct 15, 2008 at 6:08 AM, gslender <[EMAIL PROTECTED]> wrote: > I get the following stack dump when I reload an application. When > using FF3, the first load works fine, but when I refresh I get the > following stack dump (ModuleSpace.scrubStackTrace was commented out to > get the extended

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

What if we move FastStringMap into http://code.google.com/p/google-web-toolkit/source/browse/#svn/trunk/user/src/com/google/gwt/user/client/impl ? On Wed, Oct 15, 2008 at 11:00 AM, Emily Crutcher <[EMAIL PROTECTED]> wrote: > I do not think we want to make FastStringMap public where it is, though >

[gwt-contrib] Re: releases/1.6 merge from trunk

Well I'll be. Thanks for pointing that out. c3717 wasn't terribly important, so methinks I'll just remove it from the log message. Anyone have a serious problem with c3717not going into 1.6? On Wed, Oct 15, 2008 at 3:05 AM, Sam G

[gwt-contrib] Re: RR: patch for ConstantMap to use FastStringMap instead of HashMap

I do not think we want to make FastStringMap public where it is, though this might be another good reason to accelerate creating a jscollection package in GWT. On Wed, Oct 15, 2008 at 10:07 AM, Amit Manjhi <[EMAIL PROTECTED]> wrote: > Hi John, > > Please review the attached patch which fixes >

[gwt-contrib] Re: RR: SOYC Correlation work

On Wed, Oct 15, 2008 at 2:47 AM, Katharina Probst <[EMAIL PROTECTED]>wrote: > I would say yes to the equals and compareTo, but I wouldn't consider the > hashCode a blocking issue (although it's the simplest fix...). > > The equals and compareTo have the potential to create information loss (for >

[gwt-contrib] RR: patch for ConstantMap to use FastStringMap instead of HashMap

Hi John, Please review the attached patch which fixes http://code.google.com/p/google-web-toolkit/issues/detail?id=2862 As per Scott's suggestion in the comments, I changed the implementation to use FastStringMap. Since FastStringMap is in a different package, I had to make the class public and ma

[gwt-contrib] Re: RR:JS collections

The place we can run into trouble using the FastStringMap techniques is with IE6 when there are a lot of other JS objects, because of its less-then-optimal garbage collection algorithms. However, IE has the nice property it doesn't lie to you about the value of isOwnProperty(), so we can use an alt

[gwt-contrib] Re: Code Review: gwt-google-apis gears Add support for message types other than String()

On Tue, Oct 14, 2008 at 5:43 PM, Alex Rudnick <[EMAIL PROTECTED]> wrote: > Hey Eric :) I'll take this one. > > LGTM, save the (formatting) comments below and a question about documentation. > > gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java: > 388: Should probably take out t

[gwt-contrib] GWT branches\oophm fails with IndexOutOfBoundsException when reloading application

Hi, I get the following stack dump when I reload an application. When using FF3, the first load works fine, but when I refresh I get the following stack dump (ModuleSpace.scrubStackTrace was commented out to get the extended hosted mode dump). The following is the native code of XElement.setStyl

[gwt-contrib] Re: FF3 winxp on OOPHM rev 3747 branch fails with No GWT plugin found

I'm going to start another thread - that way the title stays on topic. Cheers, Grant --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---