I'd like to propose one addition and one change to the GWT style guide.
One addition: Long parameterized type names are forbidden
There's a lot of code in the incubator that Looks, as opposed to
Looking
Having names longer than one capital letter for a parameterized type is very
unconventional, a
On Thu, Oct 23, 2008 at 6:57 PM, John Tamplin <[EMAIL PROTECTED]> wrote:
> In the current code, is the context callback even needed? It looks like
> ExternalWrapper's destructor gets called before the the context is
> destroyed, and therefore FFSessionHandler::disconnect does its real work
> from
Comment by [EMAIL PROTECTED]:
Hello... has the issues brought up by ganesh.bansal been resolved - memory
leaks in IE6/7 with GWT ???
For more information:
http://code.google.com/p/google-web-toolkit/wiki/DomEventsAndMemoryLeaks
--~--~-~--~~~---~--~~
http://gro
I have shared code that calls GWT.isClient() in order to do the right
thing in different environments (e.g. use JDK SimpleDateFormat vs GWT
DateTimeFormat behind a factory). This works fine as a servlet, but
fails in Android, because the Dalvik verifier chokes on the
GWT.isClient() method being un
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 16:32:00 2008
New Revision: 3861
Modified:
branches/1_6_events/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
Log:
fix name of MouseWheelEvent.getVelocityY
Modified:
branches/1_6_events/user/src/com/google/gwt/event/dom/client/Mo
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 16:14:12 2008
New Revision: 3860
Added:
branches/1_6_events/user/test/com/google/gwt/event/
branches/1_6_events/user/test/com/google/gwt/event/EventSuite.java
branches/1_6_events/user/test/com/google/gwt/event/dom/
branches/1_6_events/use
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 16:00:50 2008
New Revision: 3859
Added:
branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForWindowEvents.java
(contents, props changed)
Log:
Visual tests for Window event handlers.
Added:
bra
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 14:32:11 2008
New Revision: 3858
Modified:
branches/1_6_events/user/src/com/google/gwt/user/client/ui/Composite.java
Log:
Copying sink events code from widget to composite and removing sinkEvents
delegation.
Modified:
branches/1_6_events/user/s
The attached patch, relative to trunk r3808 (but destined for releases/1.6)
adds the ability for class-based annotations to be inherited for i18n. For
example, this would allow you to specify a project-wide set of defaults for
these annotations and have each message interface get those defaults by
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 13:33:54 2008
New Revision: 3856
Modified:
branches/1_6_events/user/javadoc/com/google/gwt/examples/FormPanelExample.java
Log:
Updated FormPanelExample to use handlers instead of listeners.
Patch by: jlabanca
Modified:
branches/1_6_events/us
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 13:28:26 2008
New Revision: 3855
Added:
releases/1.6/user/test/com/google/gwt/i18n/client/TestAnnotatedMessages$Nested_b_C.properties
(contents, props changed)
releases/1.6/user/test/com/google/gwt/i18n/client/TestAnnotatedMessages_Neste
Thanks John for the (desk) review. Commited as r3853.
On Fri, Oct 24, 2008 at 10:57 AM, Amit Manjhi <[EMAIL PROTECTED]> wrote:
> Hi John,
>
> Please review the attached patch that fixes issue 2906.
>
> Thanks,
> Amit
>
--~--~-~--~~~---~--~~
http://groups.google.co
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 13:13:16 2008
New Revision: 3854
Modified:
branches/1_6_events/user/src/com/google/gwt/user/client/impl/HistoryImplSafari.java
Log:
Make sure we can compile History on Safari.
Modified:
branches/1_6_events/user/src/com/google/gwt/user/client/i
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 13:07:52 2008
New Revision: 3853
Added:
releases/1.6/user/src/com/google/gwt/user/client/rpc/core/java/util/TreeSet_CustomFieldSerializer.java
Modified:
releases/1.6/user/super/com/google/gwt/emul/java/util/TreeSet.java
releases/1.6/user/
LGTM, sorry for the delay!
On Wed, Oct 22, 2008 at 5:28 PM, John Tamplin <[EMAIL PROTECTED]> wrote:
> On Tue, Oct 21, 2008 at 8:28 PM, Ian Petersen <[EMAIL PROTECTED]> wrote:
>>
>> Why not allow the file to be called A.B_locale.properties? I think it
>> solves the problem of build tools not liki
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 12:43:40 2008
New Revision: 3852
Modified:
branches/1_6_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java
branches/1_6_events/user/src/com/google/gwt/user/client/ui/FiresFormEvents.java
branches/1_6_events/us
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 10:47:46 2008
New Revision: 3851
Added:
changes/bobv/soyc-reports-r3772/dev/core/src/com/google/gwt/core/ext/soyc/HasAliases.java
Modified:
changes/bobv/soyc-reports-r3772/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardCompilationAn
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 10:18:35 2008
New Revision: 3850
Modified:
branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/SingleIssue.gwt.xml
branches/1_6_events/user/src/com/google/gwt/event/shared/AbstractEvent.java
Log:
Modified:
branches/1_6_ev
Hi
I want to integrate google ads in my GWT Application.
I explored Google Adsense and was able to get a
java script .I have put that script in HTML host page. But I hope
there should be some better solution for the same as that solution
don't give me all the flexibility which I have while work
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 09:40:46 2008
New Revision: 3849
Modified:
branches/1_6_events/user/javadoc/com/google/gwt/examples/HistoryExample.java
branches/1_6_events/user/javadoc/com/google/gwt/examples/TabBarExample.java
Log:
Converted listeners to handlers in Histo
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 09:24:07 2008
New Revision: 3847
Removed:
changes/bobv/soyc-reports-r3772/dev/core/src/com/google/gwt/core/linker/soyc/AnnotatedSourceLinker.java
changes/bobv/soyc-reports-r3772/dev/core/src/com/google/gwt/core/linker/soyc/DependencyReportLin
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 09:30:13 2008
New Revision: 3848
Modified:
branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForPopupEvents.java
branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultm
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 09:23:54 2008
New Revision: 3846
Modified:
branches/1_6_events/user/src/com/google/gwt/user/client/ui/DisclosureEvent.java
branches/1_6_events/user/src/com/google/gwt/user/client/ui/DisclosureHandler.java
branches/1_6_events/user/src/co
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 08:41:35 2008
New Revision: 3845
Modified:
branches/1_6_events/user/src/com/google/gwt/user/client/ui/FiresSuggestionEvents.java
branches/1_6_events/user/src/com/google/gwt/user/client/ui/PopupListener.java
branches/1_6_events/user/src/
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 08:15:09 2008
New Revision: 3843
Removed:
branches/1_6_events/user/src/com/google/gwt/user/client/HistoryChangeEvent.java
branches/1_6_events/user/src/com/google/gwt/user/client/HistoryChangeHandler.java
Log:
Deleted HistoryChangeEvent/Handl
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 08:17:30 2008
New Revision: 3844
Modified:
branches/1_6_events/samples/showcase/src/com/google/gwt/sample/showcase/client/content/text/CwBasicText.java
Log:
Removed the last reference to the word "listen" in the Showcase sample.
Patch by: jlabanc
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 08:14:07 2008
New Revision: 3842
Modified:
branches/1_6_events/user/src/com/google/gwt/user/client/Window.java
Log:
Added boolean checks around Window events to improve compiler optimization
if events aren't used.
Patch by: jlabanca
Modified:
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 08:09:15 2008
New Revision: 3841
Modified:
branches/1_6_events/user/src/com/google/gwt/user/client/Window.java
Log:
Fixed a couple of checkstyle warnings in Window.
Patch by: jlabanca
Modified:
branches/1_6_events/user/src/com/google/gwt/user/
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 08:07:33 2008
New Revision: 3840
Modified:
branches/1_6_events/samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java
branches/1_6_events/user/src/com/google/gwt/user/client/History.java
branches/1_6_events/user/src/com/go
Hi John,
Please review the attached patch that fixes issue 2906.
Thanks,
Amit
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: user/test/com/google/gwt/user/server/rp
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 07:43:20 2008
New Revision: 3839
Modified:
branches/1_6_events/user/src/com/google/gwt/event/logical/shared/BeforeSelectionEvent.java
branches/1_6_events/user/src/com/google/gwt/user/client/ui/L.java
branches/1_6_events/user/src/com/google/
Author: [EMAIL PROTECTED]
Date: Fri Oct 24 07:31:15 2008
New Revision: 3838
Modified:
branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/TestFireEvents.java
branches/1_6_events/samples/showcase/src/com/google/gwt/sample/showcase/client/ContentWidg
Attached is a patch to update the DesignOOPHM wiki page to bring it in
line with the branches/oophm code (re messages and values)
--
Thomas Broyer
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~
33 matches
Mail list logo