[gwt-contrib] [google-web-toolkit commit] r4379 - in releases/1.6/user/src/com/google/gwt/user/client/ui: . impl

2009-01-06 Thread codesite-noreply
Author: jlaba...@google.com Date: Tue Jan 6 07:25:02 2009 New Revision: 4379 Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/PopupPanel.java releases/1.6/user/src/com/google/gwt/user/client/ui/impl/PopupImpl.java

[gwt-contrib] Why Google AdSense May Not Be Suitable For page content ?

2009-01-06 Thread gayathri
Hi, I have developed a web site using GWT1.4.62. I want to show Google Adsense on it. now ads displayed. but ads not related to page content. Why Google AdSense May Not Be Suitable For page content? pls Guide me. --~--~-~--~~~---~--~~

[gwt-contrib] Re: checkstyle review request: update checkstyle copyright notices

2009-01-06 Thread John Tamplin
On Tue, Jan 6, 2009 at 11:43 AM, Alex Rudnick a...@google.com wrote: You apparently did this last year. Would you review this patch to allow 2009 as a valid year for checkstyle? LGTM, thanks. (this should go into the 1.6 branch first, then into trunk at the next merge, yes?) Yes. --

[gwt-contrib] Re: checkstyle review request: update checkstyle copyright notices

2009-01-06 Thread Alex Rudnick
Thanks! :) Committed r4380. On Tue, Jan 6, 2009 at 1:32 PM, John Tamplin j...@google.com wrote: On Tue, Jan 6, 2009 at 11:43 AM, Alex Rudnick a...@google.com wrote: You apparently did this last year. Would you review this patch to allow 2009 as a valid year for checkstyle? LGTM, thanks.

[gwt-contrib] [google-web-toolkit commit] r4381 - releases/1.6/user/src/com/google/gwt/user/client/ui

2009-01-06 Thread codesite-noreply
Author: e...@google.com Date: Tue Jan 6 11:18:43 2009 New Revision: 4381 Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/Composite.java releases/1.6/user/src/com/google/gwt/user/client/ui/Hyperlink.java releases/1.6/user/src/com/google/gwt/user/client/ui/MenuBar.java

[gwt-contrib] code review requested for 1.6 - hosted mode speedups

2009-01-06 Thread John Tamplin
The attached patch, relative to releases/1.6 at r4381, improves hosted mode performance by caching frequently referenced data. The cost is a few hundred kilobytes of memory for a large GWT application and provides refresh speedups of approximately 14% (with similar time savings for hosted mode

[gwt-contrib] Re: Review of handler map speed test.

2009-01-06 Thread Joel Webber
I ran a quick test to determine how many handlers get added in actual applications. For Showcase, after opening all the samples, it looks something like this:- addHandler() is called 128 times - Widgets with: - 1 handler: 103 - 2 handlers: 6 - 3 handlers: 1 - 5 handlers: 2 I also ran

[gwt-contrib] Re: RR: use jarjar to rename GWT's internal dependencies

2009-01-06 Thread Freeland Abbott
1. Patch(es) not attached, so this is fairly high-level. ;-) 2. So long as your patch puts jarjar into tools, and you're just not including the binary file 'cause patch can't deal and it's big anyway, that SGTM. If you're proposing that folks can get jarjar themselves, that sounds

[gwt-contrib] Re: Review of handler map speed test.

2009-01-06 Thread Emily Crutcher
It was a proprietary one actually, so its name was deliberately omitted, however as it is a very large application, so should be pretty indicative of most well designed applications. +1 from me for Joel's conclusion. On Tue, Jan 6, 2009 at 4:17 PM, Ray Ryan rj...@google.com wrote: What was the

[gwt-contrib] Re: checkstyle review request: update checkstyle copyright notices

2009-01-06 Thread John LaBanca
Alex - Can you review this follow on that does the same thing for tests... Thanks, John LaBanca jlaba...@google.com On Tue, Jan 6, 2009 at 1:35 PM, Alex Rudnick a...@google.com wrote: Thanks! :) Committed r4380. On Tue, Jan 6, 2009 at 1:32 PM, John Tamplin j...@google.com wrote: On

[gwt-contrib] Re: code review requested for 1.6 - hosted mode speedups

2009-01-06 Thread Scott Blum
LGTM. On Tue, Jan 6, 2009 at 4:09 PM, John Tamplin j...@google.com wrote: The attached patch, relative to releases/1.6 at r4381, improves hosted mode performance by caching frequently referenced data. The cost is a few hundred kilobytes of memory for a large GWT application and provides

[gwt-contrib] Re: code review requested for 1.6 - hosted mode speedups

2009-01-06 Thread John Tamplin
On Tue, Jan 6, 2009 at 5:16 PM, Scott Blum sco...@google.com wrote: LGTM. Thanks, committed to 1.6 at r4382. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit commit] r4382 - in releases/1.6/dev/core/src/com/google/gwt: core/ext/typeinfo dev/resource/impl

2009-01-06 Thread codesite-noreply
Author: j...@google.com Date: Tue Jan 6 14:26:11 2009 New Revision: 4382 Modified: releases/1.6/dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java releases/1.6/dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java

[gwt-contrib] Re: checkstyle review request: update checkstyle copyright notices

2009-01-06 Thread John Tamplin
On Tue, Jan 6, 2009 at 5:15 PM, John LaBanca jlaba...@google.com wrote: Can you review this follow on that does the same thing for tests... LGTM -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~

[gwt-contrib] Getting Emma-enabled GWT jars

2009-01-06 Thread Jon Ruiz
Could someone tell me how to get the patched version of the GWT jars that loads and executes emma-instrumented classes? I can't tell if it's supposed to be in some subversion repository or you have to replace files manually and recompile or something else. Any help would be greatly appreciated.

[gwt-contrib] [google-web-toolkit commit] r4384 - releases/1.6/eclipse/settings/code-style

2009-01-06 Thread codesite-noreply
Author: jlaba...@google.com Date: Tue Jan 6 14:38:50 2009 New Revision: 4384 Modified: releases/1.6/eclipse/settings/code-style/gwt-checkstyle-tests.xml Log: Adds 2009 as a valid copyright year to gwt-checkstyle-tests. Patch by: jlabanca Review by: jat Modified:

[gwt-contrib] [google-web-toolkit commit] r4383 - releases/1.6/user/src/com/google/gwt/user/client/ui

2009-01-06 Thread codesite-noreply
Author: e...@google.com Date: Tue Jan 6 14:38:25 2009 New Revision: 4383 Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/ChangeListener.java releases/1.6/user/src/com/google/gwt/user/client/ui/ChangeListenerCollection.java

[gwt-contrib] [google-web-toolkit commit] r4387 - releases/1.6

2009-01-06 Thread codesite-noreply
Author: j...@google.com Date: Tue Jan 6 16:12:42 2009 New Revision: 4387 Modified: releases/1.6/branch-info.txt Log: Reflect 1.6-trunk merge. Modified: releases/1.6/branch-info.txt == ---

[gwt-contrib] [google-web-toolkit commit] r4388 - releases/1.6/user/src/com/google/gwt/user/rebind/rpc

2009-01-06 Thread codesite-noreply
Author: sco...@google.com Date: Tue Jan 6 18:19:29 2009 New Revision: 4388 Modified: releases/1.6/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java Log: Generate a serialization policy file with only line feeds, for consistent naming across platforms. Issue: 2257 Modified:

[gwt-contrib] [google-web-toolkit commit] r4389 - releases/1.6/dev/core/src/com/google/gwt/dev/js/ast

2009-01-06 Thread codesite-noreply
Author: sco...@google.com Date: Tue Jan 6 18:50:02 2009 New Revision: 4389 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java Log: Adds several window-level identifiers into the forbidden list. Issue: 2861 Modified:

[gwt-contrib] Re: Getting Emma-enabled GWT jars

2009-01-06 Thread Amit Manjhi
Hi Jon, There are two parts to get emma working with GWT. (i) Check out the latest gwt-1.6 or gwt-trunk svn branch and build the jars. (ii) Get an updated copy of emma.jar, as per the instructions in http://code.google.com/p/google-web-toolkit/source/browse/tools/redist/emma/README.txt