[gwt-contrib] [google-web-toolkit commit] r4893 - releases/1.6

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 18:46:51 2009 New Revision: 4893 Modified: releases/1.6/branch-info.txt Log: Updating branch-info.txt. Modified: releases/1.6/branch-info.txt == --- releases/1.6/branch-info

[gwt-contrib] [google-web-toolkit commit] r4892 - in releases/1.6/user: src/com/google/gwt/user/client/ui test/com/google/gwt/user/client/ui

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 18:45:04 2009 New Revision: 4892 Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/FlowPanel.java releases/1.6/user/test/com/google/gwt/user/client/ui/FlowPanelTest.java Log: Merging trunk c4889 into this branch. Modified: releases/1

[gwt-contrib] [google-web-toolkit commit] r4894 - trunk/dev/core/src/com/google/gwt/dev/jjs/impl

2009-02-26 Thread codesite-noreply
Author: b...@google.com Date: Thu Feb 26 18:54:09 2009 New Revision: 4894 Modified: trunk/dev/core/src/com/google/gwt/dev/jjs/impl/JavaScriptObjectNormalizer.java Log: Fix aliasing in AST nodes created by JavaScriptObjectNormalizer by calling CloneExpressionVisitor. Patch by: bobv Revie

[gwt-contrib] [google-web-toolkit commit] r4890 - in branches/snapshot-2009.02.26/user: src/com/google/gwt/user/client/ui test/com/google/g...

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 18:42:28 2009 New Revision: 4890 Modified: branches/snapshot-2009.02.26/user/src/com/google/gwt/user/client/ui/FlowPanel.java branches/snapshot-2009.02.26/user/test/com/google/gwt/user/client/ui/FlowPanelTest.java Log: Merging trunk c4889 into

[gwt-contrib] [google-web-toolkit commit] r4891 - branches/snapshot-2009.02.26

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 18:43:01 2009 New Revision: 4891 Modified: branches/snapshot-2009.02.26/branch-info.txt Log: Updating branch-info.txt. Modified: branches/snapshot-2009.02.26/branch-info.txt ===

[gwt-contrib] [google-web-toolkit commit] r4889 - in trunk/user: src/com/google/gwt/user/client/ui test/com/google/gwt/user/client/ui

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 18:36:02 2009 New Revision: 4889 Modified: trunk/user/src/com/google/gwt/user/client/ui/FlowPanel.java trunk/user/test/com/google/gwt/user/client/ui/FlowPanelTest.java Log: Fixes FlowPanel.clear() on IE (by making it not use innerHTML). Patch by:

[gwt-contrib] [google-web-toolkit commit] r4888 - in trunk/user/src/com/google/gwt/user: client/rpc/impl rebind/rpc

2009-02-26 Thread codesite-noreply
Author: b...@google.com Date: Thu Feb 26 17:27:47 2009 New Revision: 4888 Modified: trunk/user/src/com/google/gwt/user/client/rpc/impl/RemoteServiceProxy.java trunk/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java Log: Use a local variable to record the RPC request id number i

[gwt-contrib] [google-web-toolkit commit] r4887 - changes/jat/runtime-locales/user/src/com/google/gwt/i18n/rebind

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 17:21:29 2009 New Revision: 4887 Modified: changes/jat/runtime-locales/user/src/com/google/gwt/i18n/rebind/CurrencyListGenerator.java Log: Fix bug where use of compile-time locale would result in an infinite loop. Modified: changes/jat/runtime-l

[gwt-contrib] [google-web-toolkit commit] r4885 - in releases/1.6/user: src/com/google/gwt/user/client/ui test/com/google/gwt/user test/com...

2009-02-26 Thread codesite-noreply
Author: e...@google.com Date: Thu Feb 26 13:10:29 2009 New Revision: 4885 Added: releases/1.6/user/test/com/google/gwt/user/client/ui/WidgetTest.java Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/Widget.java releases/1.6/user/test/com/google/gwt/user/UISuite.java Log:

[gwt-contrib] [google-web-toolkit commit] r4886 - branches/snapshot-2009.02.26

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 13:12:46 2009 New Revision: 4886 Added: branches/snapshot-2009.02.26/branch-info.txt Log: Adding branch-info.txt. Added: branches/snapshot-2009.02.26/branch-info.txt == ---

[gwt-contrib] Re: Fixes Issue 3378, adding protected getHandlerCount() to widget.

2009-02-26 Thread Emily Crutcher
Committed at r4885 On Tue, Feb 24, 2009 at 6:16 PM, Ray Ryan wrote: > LGTM > Nah, just rename and submit. > > > On Tue, Feb 24, 2009 at 3:13 PM, Emily Crutcher wrote: > >> Hmm Any reasons I can think of dissolve under the argument of "that >> what I'd look for". Do you want a new patch wit

[gwt-contrib] Re: Associating Data Transfer Objects (DTOs) with Suggestion Objects

2009-02-26 Thread Isaac Truett
I opened issue #3409 for the Suggestion change and issue #3410 for the HasValue change. http://code.google.com/p/google-web-toolkit/issues/detail?id=3409 http://code.google.com/p/google-web-toolkit/issues/detail?id=3410 - Isaac On Wed, Feb 25, 2009 at 9:07 AM, Arthur Kalmenson wrote: > >> On

[gwt-contrib] [google-web-toolkit commit] r4884 - in changes/jat/runtime-locales: . dev/core/src/com/google/gwt/core/ext/linker dev/core/sr...

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 12:30:53 2009 New Revision: 4884 Added: changes/jat/runtime-locales/user/test/com/google/gwt/dev/jjs/test/jsoimpls/ - copied from r4882, /trunk/user/test/com/google/gwt/dev/jjs/test/jsoimpls/ changes/jat/runtime-locales/user/test/com/g

[gwt-contrib] [google-web-toolkit commit] r4883 - branches/snapshot-2009.02.26

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 12:22:27 2009 New Revision: 4883 Added: branches/snapshot-2009.02.26/ - copied from r4882, /trunk/ Log: 2009.02.26 Snapshot branch. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contri

[gwt-contrib] [google-web-toolkit commit] r4882 - changes/jat/runtime-locales/user/src/com/google/gwt/i18n/client/constants

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 11:39:46 2009 New Revision: 4882 Modified: changes/jat/runtime-locales/user/src/com/google/gwt/i18n/client/constants/NumberConstants.java Log: Improve comment directing how to change old code. Modified: changes/jat/runtime-locales/user/src/com/g

[gwt-contrib] [google-web-toolkit commit] r4881 - in changes/jat/runtime-locales/user: src/com/google/gwt/i18n/client/impl src/com/google/g...

2009-02-26 Thread codesite-noreply
Author: j...@google.com Date: Thu Feb 26 11:37:48 2009 New Revision: 4881 Modified: changes/jat/runtime-locales/user/src/com/google/gwt/i18n/client/impl/CurrencyList.java changes/jat/runtime-locales/user/src/com/google/gwt/i18n/rebind/CurrencyListGenerator.java changes/jat/runtim

[gwt-contrib] Re: ClippedState not sinking ONERROR event

2009-02-26 Thread Joel Webber
Does this look like an oversight to you guys? There *is* an addErrorHandler() method, so I assume it's meant to fire those events. Is there code somewhere that's supposed to sink the ONERROR event on-demand, perhaps? On Thu, Feb 26, 2009 at 1:20 PM, aris wrote: > > Hello > Using latest build #48

[gwt-contrib] ClippedState not sinking ONERROR event

2009-02-26 Thread aris
Hello Using latest build #4880 I can’t reproduce this in a small sample, but in a big project some ImageBundle images have a 3D border… this happenes only on IE, I think the problem is that the ImageBundle is setting an invalid URL and then setting the clear.gif image using the “onerror” event, bu

[gwt-contrib] [google-web-toolkit commit] r4880 - releases/1.6/user/src/com/google/gwt/user/client/ui

2009-02-26 Thread codesite-noreply
Author: rj...@google.com Date: Thu Feb 26 08:45:15 2009 New Revision: 4880 Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/MenuItem.java Log: Fix MenuItem class doc--it's not a widget Issue 434 Review by bruce Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/M

[gwt-contrib] [google-web-toolkit commit] r4878 - releases/1.6/dev/core/src/com/google/gwt/dev/js/ast

2009-02-26 Thread codesite-noreply
Author: amitman...@google.com Date: Thu Feb 26 07:54:28 2009 New Revision: 4878 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java Log: svn merge -r4872:4873 https://google-web-toolkit.googlecode.com/svn/trunk . This patch adds identifiers that cause loading of t

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread Scott Blum
On Thu, Feb 26, 2009 at 11:53 AM, nicolas de loof wrote: > The issue here with maven integration is that even the simpliest server > setup (only RPC RemoteServlet with no dependency on any other lib) requires > to put project classes and gwt-* libs in jetty WEB-INF, that is not the best > option f

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread nicolas de loof
I fully agree about the noserver option when some server-side setup is required. I myself consider the hosted-mode server only for UI testing with mock gwt-RPC servlets. The issue here with maven integration is that even the simpliest server setup (only RPC RemoteServlet with no dependency on any o

[gwt-contrib] Re: Error embedded 1.6 Compiler

2009-02-26 Thread Scott Blum
On Thu, Feb 26, 2009 at 1:10 AM, BobV wrote: > One does not. I can start one next week when I get back. > Cool. Another option might be to go straight to create user-facing doc for 1.6. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Con

[gwt-contrib] Re: Fix javadoc in MenuItem

2009-02-26 Thread rjrjr
Committed revision 4880. http://gwt-code-reviews.appspot.com/7803 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread John Tamplin
On Thu, Feb 26, 2009 at 5:59 AM, nicolas de loof wrote: > Another question about configuring jetty : it expects a web.xml to define > the RPC servlets. Many of us will use some more complex server side setup, > for example including Spring and Hibernate, DataSources configuration, ... > etc > > Ru

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread nicolas de loof
I finally found an acceptable solution by : - using a test webapp structure in src/test/webapp so that I can register simplified (mock) GWT-RPC servlet implementations and not require my full webapp to test in hosted mode (can still use noserver for that) - creating the exploded WAR st

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread nicolas de loof
You may be interested to see how jetty guys integrate with maven : http://www.mortbay.org/jetty/jetty-6/xref/org/mortbay/jetty/plugin/Jetty6MavenConfiguration.html They use a classPathFiles List created by the maven "jetty:run" goal to setup the jetty webappClassLoader. Maybe some comparable setup

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread nicolas de loof
I tested the "create exploded webapp structure in maven plugin before creating lauch configurations" strategy. I can launch the hosted browser but this has serious productivity cost : The /lib folder is not supposed to change often, so this is not an issue to poulate it from maven dependencies. The

[gwt-contrib] Re: Fix javadoc in MenuItem

2009-02-26 Thread Bruce Johnson
LGTM On Wed, Feb 25, 2009 at 7:36 PM, wrote: > Reviewers: bruce, > > Description: > GWT issue 434 > > Please review this at http://gwt-code-reviews.appspot.com/7803 > > Affected files: > user/src/com/google/gwt/user/client/ui/MenuItem.java > > > Index: user/src/com/google/gwt/user/client/ui/Men

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread nicolas de loof
To make things a little clearer, here is how I understand the way classloader are built by Hosted mode : bootClasspath |_ HostedMode |_ Hosted Browser | |_ Jetty Embedded |_ WebApplicationClassLoader How does Jetty access project (service-side cla

[gwt-contrib] Re: Classloader issue running Hosted mode from Eclipse with Maven managed dependencies

2009-02-26 Thread nicolas de loof
I've found an (ugly ?) workaround by adding xercesImpl in the bootstrap classpath and setting the javax.xml.parsers.SAXParserFactory system property. With this config the plugin can assume the SAX parser to be used in hosted mode - not very pleasant as the user can't configure it's own, but fixes t