It's not included in our distro, which is why we haven't HAD to fix it
since... um... r558. :-/ But it should still build if asked to.
(Amit, I picked you more or less at random, to be a value of !scottb.
Sorry... but it's tiny.)
--~--~-~--~~~---~--~~
On Wed, Apr 8, 2009 at 11:17 AM, John Tamplin j...@google.com wrote:
On Wed, Apr 8, 2009 at 11:00 AM, Lex Spoon sp...@google.com wrote:
Scott, when you get back, can you review this tiny patch, or propose a
different way to solve the problem?
The problem is that when precompiles are
Good catch. LGTM.
On Wed, Apr 8, 2009 at 11:02 PM, Freeland Abbott fabb...@google.com wrote:
It's not included in our distro, which is why we haven't HAD to fix it
since... um... r558. :-/ But it should still build if asked to.
(Amit, I picked you more or less at random, to be a value of
Oh, a concrete reason occurred to me this morning why we'd rather have the
logic in Precompile.run() that binds using OptionCompilationStateRetained
with OptionMaxPermsPerCompile:
You'd actually like to turn off OptionCompilationStateRetained on the final
pass, I mean, the last set of
FYI: I just committed the last of my outstanding memory work to trunk. Lex
kindly agreed to watch the build and do a roll-back for me if something
breaks.
On Tue, Apr 7, 2009 at 10:33 PM, Scott Blum sco...@google.com wrote:
On Tue, Apr 7, 2009 at 4:12 PM, Lex Spoon sp...@google.com wrote:
Author: sco...@google.com
Date: Thu Apr 9 08:42:18 2009
New Revision: 5203
Modified:
trunk/dev/core/src/com/google/gwt/core/ext/linker/CompilationResult.java
trunk/dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java
w00t! Vacation commits FTW! (Just kidding; @Scott: please rest)
On Thu, Apr 9, 2009 at 11:52 AM, Scott Blum sco...@google.com wrote:
FYI: I just committed the last of my outstanding memory work to trunk. Lex
kindly agreed to watch the build and do a roll-back for me if something
breaks.
Author: sp...@google.com
Date: Thu Apr 9 09:06:36 2009
New Revision: 5205
Modified:
trunk/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java
trunk/dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java
Log:
Changes MakeCallsStatic so that it does not devirtualize calls
Author: sco...@google.com
Date: Thu Apr 9 08:42:49 2009
New Revision: 5204
Modified:
trunk/dev/core/src/com/google/gwt/dev/jjs/impl/SourceGenerationVisitor.java
trunk/dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java
Don't worry, I'm getting plenty of naps in during the hour-long hyperbaric
sessions I do with Aaron. Which is, good, since we have to get up at 7 to
make the morning ones. :) But we're having some fun too. Aaron and I just
got back from hanging out at the pool and soaking up some sun. Aaron
On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum sco...@google.com wrote:
Oh, a concrete reason occurred to me this morning why we'd rather have the
logic in Precompile.run() that binds using OptionCompilationStateRetained
with OptionMaxPermsPerCompile:
You'd actually like to turn off
Author: sp...@google.com
Date: Thu Apr 9 11:25:44 2009
New Revision: 5206
Modified:
trunk/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
trunk/user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java
Log:
Rolls back r5075. It's
LGTM, except for misspelled variable name. :-)
On Thu, Apr 9, 2009 at 1:45 PM, Lex Spoon sp...@google.com wrote:
On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum sco...@google.com wrote:
Oh, a concrete reason occurred to me this morning why we'd rather have
the
logic in Precompile.run() that
Thanks! It's in at r5207. The variable name now has a full complement of e's.
-Lex
On Thu, Apr 9, 2009 at 5:01 PM, Scott Blum sco...@google.com wrote:
LGTM, except for misspelled variable name. :-)
On Thu, Apr 9, 2009 at 1:45 PM, Lex Spoon sp...@google.com wrote:
On Thu, Apr 9, 2009 at
Author: sp...@google.com
Date: Thu Apr 9 14:07:53 2009
New Revision: 5207
Modified:
trunk/dev/core/src/com/google/gwt/dev/Precompile.java
Log:
When sharded precompiles are on, force the option retain
compilation state to be on except for the last precompile
shard. Otherwise, state is
I hope Google takes out an extra insurance policy so that should an accident
occur, they can cryogenically freeze your brain and thaw you out in the
future in case there are any outstanding compiler issues no one has been
able to fix. :)
-Ray
On Thu, Apr 9, 2009 at 10:24 AM, Scott Blum
Thanks, Ray (and Bruce). I showed Anna this thread and she totally ROFLed.
Then she told me if I don't stop working you guys really will need an
insurance policy on me. ;)
On Thu, Apr 9, 2009 at 5:26 PM, Ray Cromwell cromwell...@gmail.com wrote:
I hope Google takes out an extra insurance
Isn't that achieved by the auxiliary warnings? Or do you mean you want them
all listed in the one error message, or am I misunderstandinging the
scenario you describe?
On Thu, Apr 9, 2009 at 3:26 PM, Lex Spoon sp...@google.com wrote:
Thanks!
The overall report layout is a big improvement.
On Mon, Apr 6, 2009 at 7:22 PM, John Tamplin j...@google.com wrote:
The attached patch for trunk adds JSONP support, for use with cross-site
data retrieval, such as GData APIs.
Committed to trunk at r5208.
--
John A. Tamplin
Software Engineer (GWT), Google
Author: j...@google.com
Date: Thu Apr 9 16:25:16 2009
New Revision: 5208
Added:
trunk/user/src/com/google/gwt/jsonp/
trunk/user/src/com/google/gwt/jsonp/Jsonp.gwt.xml
trunk/user/src/com/google/gwt/jsonp/client/
trunk/user/src/com/google/gwt/jsonp/client/JsonpRequest.java
I'd just like to confirm that ToT is indeed broken right now. Same thing
happens when I try to run in hosted mode.
Getting
[java] Loading module 'module name'
[java][ERROR] Unexpected error while processing XML
[java] java.lang.IncompatibleClassChangeError: Found interface
Try an 'ant clean'
On Thu, Apr 9, 2009 at 9:30 PM, Vitali Lovich vlov...@gmail.com wrote:
I'd just like to confirm that ToT is indeed broken right now. Same thing
happens when I try to run in hosted mode.
Getting
[java] Loading module 'module name'
[java][ERROR] Unexpected
Thanks, that fixed it.
Shouldn't you be on vacation :D?
On Thu, Apr 9, 2009 at 9:44 PM, Scott Blum sco...@google.com wrote:
Try an 'ant clean'
On Thu, Apr 9, 2009 at 9:30 PM, Vitali Lovich vlov...@gmail.com wrote:
I'd just like to confirm that ToT is indeed broken right now. Same thing
I am, I'm only doing fun stuff. :)
On Thu, Apr 9, 2009 at 10:03 PM, Vitali Lovich vlov...@gmail.com wrote:
Thanks, that fixed it.
Shouldn't you be on vacation :D?
On Thu, Apr 9, 2009 at 9:44 PM, Scott Blum sco...@google.com wrote:
Try an 'ant clean'
On Thu, Apr 9, 2009 at 9:30 PM,
Author: sco...@google.com
Date: Thu Apr 9 20:28:46 2009
New Revision: 5209
Modified:
trunk/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java
Log:
Added a hack to confirm that the flaky RPCSuite failure is what we think it
is.
Review by: bobv (TBR)
Modified:
On Thu, Apr 9, 2009 at 7:25 PM, John Tamplin j...@google.com wrote:
Committed to trunk at r5208.
Rolled back in r5210, since it was breaking the build on IE7.
@Daniel: any ideas?
--
Testsuite: com.google.gwt.jsonp.JsonpRequestSuite
Tests run: 13, Failures: 0, Errors: 11, Time elapsed: 47.638
Author: j...@google.com
Date: Thu Apr 9 22:35:06 2009
New Revision: 5210
Removed:
trunk/user/src/com/google/gwt/jsonp/
trunk/user/test/com/google/gwt/jsonp/
Log:
Rollback r5208, since it is failing on IE7.
--~--~-~--~~~---~--~~
27 matches
Mail list logo
