Author: j...@google.com
Date: Wed May 20 21:41:21 2009
New Revision: 5450
Modified:
trunk/user/src/com/google/gwt/i18n/client/NumberFormat.java
trunk/user/test/com/google/gwt/i18n/client/NumberFormat_ar_Test.java
Log:
Allow an app to force use of latin digits/separators instead
of locali
On Thu, May 21, 2009 at 12:19 AM, wrote:
> LGTM
Thanks, committed to trunk in r5450.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~
LGTM
http://gwt-code-reviews.appspot.com/34817
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Google Web Toolkit Contributors" group.
To post to this group, send email to
Google-Web-Toolkit-Contributors@googlegro
LGTM
http://gwt-code-reviews.appspot.com/34816
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: scottb,
Description:
Fix for
http://code.google.com/p/google-web-toolkit/issues/detail?id=3679
Please review this at http://gwt-code-reviews.appspot.com/34817
Affected files:
user/src/com/google/gwt/user/client/ui/RadioButton.java
Index: user/src/com/google/gwt/user/client/ui/Ra
Author: b...@google.com
Date: Wed May 20 16:14:31 2009
New Revision: 5449
Added:
trunk/user/src/com/google/gwt/resources/css/ast/CssExternalSelectors.java
(contents, props changed)
Modified:
trunk/user/src/com/google/gwt/resources/client/CssResource.java
trunk/user/src/com/googl
Reviewers: andreasst_google.com,
Description:
This patch allows an app to force use of latin digits/separators instead
of localized digits.
Please review this at http://gwt-code-reviews.appspot.com/34816
Affected files:
user/src/com/google/gwt/i18n/client/NumberFormat.java
user/test/com/g
LGTM.
BTW: if you want to go the extra mile, you can get even more speed up by
reusing the StringBuilder. Call setLength(0) to "start fresh", but it
retains the internal char buffer so you can avoid tons of allocations.
You could probably either pass a reusable buffer through as a param, or
kee
http://gwt-code-reviews.appspot.com/33827/diff/1/12
File user/src/com/google/gwt/resources/client/CssResource.java (right):
http://gwt-code-reviews.appspot.com/33827/diff/1/12#newcode229
Line 229: * recommended as the default behavior for CssResources.
Should have made it the default behavior, a
Author: b...@google.com
Date: Wed May 20 14:49:15 2009
New Revision: 5448
Modified:
wiki/CssResource.wiki
wiki/CssResourceCookbook.wiki
Log:
Update CssResource documentation to trunk, document the proposed @external
directive.
Modified: wiki/CssResource.wiki
=
Author: sco...@google.com
Date: Wed May 20 14:35:08 2009
New Revision: 5447
Added:
branches/snapshot-2009.05.12-r5406/dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java
- copied, changed from r5414,
/branches/snapshot-2009.05.12-r5406/dev/core/src/com/google/gwt
Author: b...@google.com
Date: Wed May 20 14:19:56 2009
New Revision: 5446
Added:
wiki/CssResource.wiki
wiki/CssResourceCookbook.wiki
Log:
Copy CssResource documentation from incubator project into GWT trunk.
Added: wiki/CssResource.wiki
=
Author: sco...@google.com
Date: Wed May 20 14:09:16 2009
New Revision: 5445
Added:
trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java
- copied, changed from r5442,
/trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorderImpl.java
trun
http://gwt-code-reviews.appspot.com/34814/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
(right):
http://gwt-code-reviews.appspot.com/34814/diff/1/2#newcode423
Line 423: char c = unescaped.charAt(index + 1);
On 2009/05/20 20:47:23, jat wrote:
> You need to ch
http://gwt-code-reviews.appspot.com/34814/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
(right):
http://gwt-code-reviews.appspot.com/34814/diff/1/2#newcode406
Line 406: private static String escapeXml(String unescaped) {
On 2009/05/20 20:47:23, jat wrote:
>
http://gwt-code-reviews.appspot.com/34814/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
(right):
http://gwt-code-reviews.appspot.com/34814/diff/1/2#newcode406
Line 406: private static String escapeXml(String unescaped) {
Should this instead use the one in Ut
LGTM
Like you mentioned, with a more intrusive change we might (in the
future) be able to get away without ever converting to/from String.
http://gwt-code-reviews.appspot.com/34814
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributo
Reviewers: ,
Description:
This patch adds an @external directive to the CSS system to allow for
selective non-obfuscation of identifiers and to bypass strict-mode
checks.
Please review this at http://gwt-code-reviews.appspot.com/33827
Affected files:
user/src/com/google/gwt/resources/client/
Reviewers: Dan Rice, spoon,
Description:
This patch streamlines the story recording for SOYC. In particular, it
no longer creates nicely indented XML files, and it uses StringBuilder
instead of String in emitStory. This cuts down on the time spent dumping
stories to file.
Please review this at
Author: rj...@google.com
Date: Wed May 20 13:07:16 2009
New Revision: 5444
Modified:
releases/1.6/branch-info.txt
Log:
Note merge of trunk c5347
Modified: releases/1.6/branch-info.txt
==
--- releases/1.6/branch-inf
Author: rj...@google.com
Date: Wed May 20 13:06:15 2009
New Revision: 5443
Modified:
releases/1.6/user/test/com/google/gwt/user/client/ui/CheckBoxTest.java
Log:
Merge of trunk c5347, which removes broken CheckBoxTest#testLabelClick
introduced by trunk c5333
Modified:
releases/1.6/user/t
Reviewers: kprobst,
Description:
Convert \[&<>'"] into their XML equivalents without using the (very
slow) String.replaceAll method.
Please review this at http://gwt-code-reviews.appspot.com/34814
Affected files:
dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java
dev/co
As a practical example, ClientBundle can already generate deep
expressions for Css resource injection that exhaust the stack space of
the JVM when compiling. You end up with something like:
var cssText = a + b + c + . (hundreds)
which produces a very deeply nested binary expression tree.
-R
Thanks for getting back to me on this. I'll respond to the 5 issues
here, saving the first issue for last, as it's the longest and it's
easier to just skip over if it's not important to you, or if you
wholeheartedly agree or disagree with me.
> (ii) BitSet.toString() is incorrect because it does
It is still possible for super-deep expressions to come out of the
compiler. As yet it is not a practical problem, however. The depth
limit is 1. We are only bumping into such a large limit because of
the unusual encoding used for var statements.
That said, if it's a practical problem, wou
I'm also concerned that it only splits var statements; are we sure GWT
won't generate "too deep" expressions on other kind of statements?
http://gwt-code-reviews.appspot.com/33826/diff/1/6
File dev/core/src/com/google/gwt/dev/js/JsBreakUpLargeVarStatements.java
(right):
http://gwt-code-reviews.
Author: sp...@google.com
Date: Wed May 20 07:16:36 2009
New Revision: 5442
Modified:
trunk/tools/soyc-vis/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
trunk/tools/soyc-vis/src/com/google/gwt/soyc/Settings.java
trunk/tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java
Lo
Thanks. Committed at r5442.
http://gwt-code-reviews.appspot.com/33825
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jgw,
Description:
Per issue 3455, split up very long var lines to avoid a new Webkit bug.
This also adds a CompilerParameters module. It looks useful for testing
to be able to tune way down compiler settings such as this one.
Please review this at http://gwt-code-reviews.appspot.c
Author: j...@google.com
Date: Wed May 20 06:51:52 2009
New Revision: 5441
Modified:
releases/1.6/branch-info.txt
Log:
Updating branch-info again.
Modified: releases/1.6/branch-info.txt
==
--- releases/1.6/branch-in
Author: j...@google.com
Date: Wed May 20 06:50:05 2009
New Revision: 5440
Modified:
releases/1.6/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
releases/1.6/user/src/com/google/gwt/dom/client/DOMImplMozillaOld.java
releases/1.6/user/src/com/google/gwt/dom/client/DOMImplSafari.
Author: j...@google.com
Date: Wed May 20 06:49:41 2009
New Revision: 5439
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/CheckBox.java
releases/1.6/user/test/com/google/gwt/user/client/ui/RadioButtonTest.java
Log:
Merging /trunk r4820 into /releases/1.6.
Modified: releas
Thanks, commited to trunk as r5438.
On Wed, May 20, 2009 at 9:29 AM, wrote:
> LGTM.
>
> There was earlier a reason for some to be non-static, then that got
> removed through the review process, and then I forgot to make them
> consistent again.
>
>
>
> http://gwt-code-reviews.appspot.com/34813
Author: kpro...@google.com
Date: Wed May 20 06:36:47 2009
New Revision: 5438
Modified:
trunk/tools/soyc-vis/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
trunk/tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java
Log:
MakeTopLevelHtmlForPerm had some inconsistencies in which
LGTM.
There was earlier a reason for some to be non-static, then that got
removed through the review process, and then I forgot to make them
consistent again.
http://gwt-code-reviews.appspot.com/34813
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-
Author: kpro...@google.com
Date: Wed May 20 06:17:16 2009
New Revision: 5437
Modified:
trunk/user/src/com/google/gwt/user/client/Cookies.java
trunk/user/test/com/google/gwt/user/client/CookieTest.java
Log:
Addresses public issue 3566: Offer option to not decode cookies
Addresses public i
Reviewers: spoon,
Description:
MakeTopLevelHtmlForPerm had some inconsistencies in which methods were
static and which weren't. This resulted in inconsistent-looking code in
SoycDashboard, which calls a number of the methods in
MakeTopLevelHtmlForPerm. I don't see a reason for keeping the metho
I've updated the patch against the current SVN trunk... And added a 'sanity'
(i..e not very thorough) test method into GwtQueryCoreTest to verify that it
works
Cheers
Cam
2009/5/17 Ray Cromwell
>
> Ok, i'll check out the patch. I suspect after Google I/O that the # of
> users/contributors will
38 matches
Mail list logo
