[gwt-contrib] Re: I've submitted a new issue with a patch for a bug in IFrameLinker which causes HTML Parsing Error (KB927917) in IE8/IE7/IE6

2009-06-02 Thread Scott Blum
Thanks, Cameron! I assigned the issue to Joel, who's working on this. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] I've submitted a new issue with a patch for a bug in IFrameLinker which causes HTML Parsing Error (KB927917) in IE8/IE7/IE6

2009-06-02 Thread Cameron Braid
The issues arises because the selection script mutates the DOM by inserting an iframe element into the body before the body tag has completed. The only time this issue arises is when the compiled script completes loading before the host page finished loading. i.e. there are two sequences of event

[gwt-contrib] [google-web-toolkit commit] r5498 - Record merge from releases/1.6

2009-06-02 Thread codesite-noreply
Author: j...@google.com Date: Tue Jun 2 15:01:47 2009 New Revision: 5498 Modified: branches/snapshot-2009.05.12-r5406/branch-info.txt Log: Record merge from releases/1.6 Modified: branches/snapshot-2009.05.12-r5406/branch-info.txt ==

[gwt-contrib] [google-web-toolkit commit] r5497 - Merge r5332 from releases/1.6 - add null checks on Element/Node.is and a test.

2009-06-02 Thread codesite-noreply
Author: j...@google.com Date: Tue Jun 2 14:59:18 2009 New Revision: 5497 Modified: branches/snapshot-2009.05.12-r5406/user/build.xml branches/snapshot-2009.05.12-r5406/user/src/com/google/gwt/dom/client/Element.java branches/snapshot-2009.05.12-r5406/user/src/com/google/gwt/dom/c

[gwt-contrib] Re: GWT-RPC broken in GAE/J

2009-06-02 Thread Ray Ryan
I'm really skeptical of #1. The new AdWords UI uses a tool supported variant of #2, and I think that's the direction any general GWT support needs to go. ORM objects just don't make good decoupled wire objects. I think what we need to do is provide tooling to make the inevitable DRY violations as m

[gwt-contrib] [google-web-toolkit commit] r5496 - This patch modifies the IFrame linker to use multiple script tags instead of one

2009-06-02 Thread codesite-noreply
Author: sp...@google.com Date: Tue Jun 2 12:09:40 2009 New Revision: 5496 Added: trunk/dev/core/src/com/google/gwt/core/ext/linker/StatementRanges.java (contents, props changed) trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardStatementRanges.java (contents, prop

[gwt-contrib] Re: chunk script tags into smaller ones to improve load time

2009-06-02 Thread spoon
Okay, it's in at r5496. http://gwt-code-reviews.appspot.com/33804 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] [google-web-toolkit commit] r5495 - Merge trunk 5485, 5492 to snapshot branch.

2009-06-02 Thread codesite-noreply
Author: j...@google.com Date: Tue Jun 2 10:48:36 2009 New Revision: 5495 Modified: branches/snapshot-2009.05.12-r5406/branch-info.txt branches/snapshot-2009.05.12-r5406/user/src/com/google/gwt/dom/client/DOMImplIE6.java branches/snapshot-2009.05.12-r5406/user/src/com/google/gwt/d

[gwt-contrib] Re: chunk script tags into smaller ones to improve load time

2009-06-02 Thread spoon
http://gwt-code-reviews.appspot.com/33804/diff/24/42 File user/test/com/google/gwt/emultest/EmulSuite.gwt.xml (right): http://gwt-code-reviews.appspot.com/33804/diff/24/42#newcode25 Line 25: Gotcha. I'll move them both to CompilerSuite. http://gwt-code-reviews.appspot.com/33804 --~--~---

[gwt-contrib] [google-web-toolkit commit] r5494 - Tweaks Class.setName to avoid an autobox and thus avoid

2009-06-02 Thread codesite-noreply
Author: sp...@google.com Date: Tue Jun 2 08:28:10 2009 New Revision: 5494 Modified: trunk/user/super/com/google/gwt/emul/java/lang/Class.java Log: Tweaks Class.setName to avoid an autobox and thus avoid needing the Integer class to be initialized. Review by: scottb Modified: trunk/user/s

[gwt-contrib] Re: chunk script tags into smaller ones to improve load time

2009-06-02 Thread spoon
I'll upload a new patch in a minute. http://gwt-code-reviews.appspot.com/33804/diff/24/31 File dev/core/src/com/google/gwt/core/ext/linker/impl/StandardStatementRanges.java (right): http://gwt-code-reviews.appspot.com/33804/diff/24/31#newcode27 Line 27: private static int[] toArray(List list) {

[gwt-contrib] Comment on UsingOOPHM in google-web-toolkit

2009-06-02 Thread codesite-noreply
Comment by PaRaDoXXX.ZeRo: Same as mark here, rev 5393 breaks oophm with document.body is null as an error. Reverted to 5392 and it works... For more information: http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM --~--~-~--~~~---~--~~ http://groups.g

[gwt-contrib] [google-web-toolkit commit] r5493 - Fix checkstyle violation.

2009-06-02 Thread codesite-noreply
Author: r...@google.com Date: Tue Jun 2 07:35:31 2009 New Revision: 5493 Modified: trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardClassMember.java Log: Fix checkstyle violation. Review by: b...@google.com Modified: trunk/dev/core/src/com/google/gwt/core/ext/soyc/impl/S

[gwt-contrib] Re: Fix checkstyle violation

2009-06-02 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/33839 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Fix checkstyle violation

2009-06-02 Thread rice
Reviewers: bobv, Please review this at http://gwt-code-reviews.appspot.com/33839 Affected files: dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardClassMember.java Index: dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardClassMember.java ===

[gwt-contrib] [google-web-toolkit commit] r5492 - Fixes test failure on FF2 with a bit of a hack in the test (FF2 has an

2009-06-02 Thread codesite-noreply
Author: j...@google.com Date: Tue Jun 2 07:19:52 2009 New Revision: 5492 Modified: trunk/user/test/com/google/gwt/dom/client/ElementTest.java Log: Fixes test failure on FF2 with a bit of a hack in the test (FF2 has an off-by-one error in getBoxObjectFor() that cannot easily be fixed). TBR: